drm/rockchip: Don't spam logs in atomic check
Subsystems (4)
PATCH 1/1 drm/rockchip: Don't spam logs in atomic check
Userspace should not be able to trigger DRM_ERROR messages to spam the logs; especially not through atomic commit parameters which are completely legitimate for userspace to attempt.
Signed-off-by Daniel Stone <[email protected]>
Fixes 7707f7227f09 ("drm/rockchip: Add support for afbc")
--- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +9 -8
@@ -832,12 +832,12 @@ static int vop_plane_atomic_check(struct drm_plane *plane,* need align with 2 pixel. */ if (fb->format->is_yuv && ((new_plane_state->src.x1 >>16 ) %2 )) { -DRM_ERROR ("Invalid Source: Yuv format not support odd xpos\n" ); +DRM_DEBUG_KMS ("Invalid Source: Yuv format not support odd xpos\n" );return -EINVAL ; }if (fb->format->is_yuv && new_plane_state->rotation &DRM_MODE_REFLECT_Y ) { -DRM_ERROR ("Invalid Source: Yuv format does not support this rotation\n" ); +DRM_DEBUG_KMS ("Invalid Source: Yuv format does not support this rotation\n" );return -EINVAL ; }
@@ -845,7 +845,7 @@ static int vop_plane_atomic_check(struct drm_plane *plane,struct vop *vop =to_vop (crtc);if (!vop->data->afbc) { -DRM_ERROR ("vop does not support AFBC\n" ); +DRM_DEBUG_KMS ("vop does not support AFBC\n" );return -EINVAL ; }
@@ -854,15 +854,16 @@ static int vop_plane_atomic_check(struct drm_plane *plane,return ret;if (new_plane_state->src.x1 || new_plane_state->src.y1) { -DRM_ERROR ("AFBC does not support offset display, xpos=%d, ypos=%d, offset=%d\n" , - new_plane_state->src.x1, - new_plane_state->src.y1, fb->offsets[0 ]); +DRM_DEBUG_KMS ("AFBC does not support offset display, " \ +"xpos=%d, ypos=%d, offset=%d\n" , + new_plane_state->src.x1, new_plane_state->src.y1, + fb->offsets[0 ]);return -EINVAL ; }if (new_plane_state->rotation && new_plane_state->rotation !=DRM_MODE_ROTATE_0 ) { -DRM_ERROR ("No rotation support in AFBC, rotation=%d\n" , - new_plane_state->rotation); +DRM_DEBUG_KMS ("No rotation support in AFBC, rotation=%d\n" , + new_plane_state->rotation);return -EINVAL ; } }
Signature · 1 line
2.41.0
Quoted 5 lines · Daniel Stone
Userspace should not be able to trigger
DRM_ERRORmessages to spam the logs; especially not through atomic commit parameters which are completely legitimate for userspace to attempt.
Applied, thanks!
[1/1] drm/rockchip: Don't spam logs in atomic check
commit: 43dae319b50fac075ad864f84501c703ef20eb2b
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>