Skip to contentSkip to conversation

bus: ti-sysc: Fix a build warning with W=1 for sysconfig

PATCH In review Tony Lindgren 2 participants 3 messages Aug 9, 2023 – Aug 10, 2023 OMAP2+ support

lore
Share & tools
lore

Tony Lindgren

author maintainer
#0 lore raw

PATCH 1/1 bus: ti-sysc: Fix a build warning with W=1 for sysconfig

Dhruva reported a build warning with W=1 for "Function parameter or member 'sysconfig' not described in 'sysc'". Let's document sysconfig to fix this.

---
 drivers/bus/ti-sysc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/bus/ti-sysc.c +1 -0
@@ -109,6 +109,7 @@ static const char * const clock_names[SYSC_MAX_CLOCKS] = {
  * @cookie: data used by legacy platform callbacks
  * @name: name if available
  * @revision: interconnect target module revision
+ * @sysconfig: saved sysconfig register value
  * @reserved: target module is reserved and already in use
  * @enabled: sysc runtime enabled status
  * @needs_resume: runtime resume needed on resume from suspend
Signature · 1 line
2.41.0
#1 lore raw
Quoted 6 lines · Tony Lindgren

Dhruva reported a build warning with W=1 for "Function parameter or member 'sysconfig' not described in 'sysc'". Let's document sysconfig to fix this.

---

Probably best to include a Fixes: commit no?

Quoted 16 lines
 drivers/bus/ti-sysc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/bus/ti-sysc.c +1 -0
@@ -109,6 +109,7 @@ static const char * const clock_names[SYSC_MAX_CLOCKS] = {
  * @cookie: data used by legacy platform callbacks
  * @name: name if available
  * @revision: interconnect target module revision
+ * @sysconfig: saved sysconfig register value
  * @reserved: target module is reserved and already in use
  * @enabled: sysc runtime enabled status
  * @needs_resume: runtime resume needed on resume from suspend
Signature · 1 line
2.41.0
Signature · 2 lines
Best regards,
Dhruva Gole <[email protected]>
author maintainer
#2 lore raw
Quoted 1 line · Dhruva Gole

Probably best to include a Fixes: commit no?

Nah, it's a comment fix for W=1 warning for a driver private data struct :) No need to have it applied in stable kernels as far as I can tell.

Regards,

Tony