Skip to contentSkip to conversation

Fixed a regression in the junction code

PATCH In review Steve Dickson 1 participant 2 messages Aug 9, 2023 – Aug 10, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fixed a regression in the junction code

commit cdbef4e9 created a regression in the
in the junction code by adding a O_PATH flag
to the open() in junction_open_path()

---
 support/junction/junction.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/junction/junction.c +1 -1
index 0628bb0f..c1ec8ff8 100644
@@ -63,7 +63,7 @@ junction_open_path(const char *pathname, int *fd)
 	if (pathname == NULL || fd == NULL)
 		return FEDFS_ERR_INVAL;
 
-	tmp = open(pathname, O_PATH|O_DIRECTORY);
+	tmp = open(pathname, O_DIRECTORY);
 	if (tmp == -1) {
 		switch (errno) {
 		case EPERM:
Signature · 1 line
2.41.0
#1 lore raw
Quoted 6 lines · Steve Dickson

commit cdbef4e9 created a regression in the
in the junction code by adding a O_PATH flag
to the open() in junction_open_path()

Committed...

steved.

Quoted 17 lines
---
  support/junction/junction.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
support/junction/junction.c +1 -1
index 0628bb0f..c1ec8ff8 100644
@@ -63,7 +63,7 @@ junction_open_path(const char *pathname, int *fd)
  	if (pathname == NULL || fd == NULL)
  		return FEDFS_ERR_INVAL;
 
-	tmp = open(pathname, O_PATH|O_DIRECTORY);
+	tmp = open(pathname, O_DIRECTORY);
  	if (tmp == -1) {
  		switch (errno) {
  		case EPERM: