staging: nvec: paz00: remove unneeded call to platform_set_drvdata()
Subsystems (3)
PATCH 1/1 staging: nvec: paz00: remove unneeded call to platform_set_drvdata()
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
--- drivers/staging/nvec/nvec_paz00.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/nvec/nvec_paz00.c +0 -2
@@ -53,8 +53,6 @@ static int nvec_paz00_probe(struct platform_device *pdev) led->cdev.flags |=LED_CORE_SUSPENDRESUME ; led->nvec = nvec; -platform_set_drvdata (pdev, led); - ret =devm_led_classdev_register (&pdev->dev, &led->cdev);if (ret <0 )return ret;
Signature · 1 line
2.34.1
Quoted 7 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Signed-off-by Andrei Coardos <[email protected]>---
I think you are right, but why are we doing this? That one line is hardly a huge eyesore. It's all risk and no reward.
Have you tested this change on real hardware?
regards,
dan carpenter
Marc Dietrich
maintainerHi,
Quoted 11 lines · Dan Carpenter
Quoted 7 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Signed-off-by Andrei Coardos <[email protected]>---
I think you are right, but why are we doing this? That one line is hardly a huge eyesore. It's all risk and no reward.
I guess this was placed in order to implement a module unload function, but this was never done. The driver also seems to have found another method to get its private data, so this can be safely removed.
Quoted 1 line
Have you tested this change on real hardware?
I just checked that it compiles and works on my AC100.
Thanks!
Marc
Quoted 9 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Signed-off-by Andrei Coardos <[email protected]>--- drivers/staging/nvec/nvec_paz00.c | 2 -- 1 file changed, 2 deletions(-)
Seems fine, and if Marc has tested it, that's good enough for me: