Skip to contentSkip to conversation

mlxbf-bootctl: Support access to the large icm size and setting the BlueField boot state.

PATCH In review Asmaa Mnebhi 3 participants 6 messages Aug 9, 2023 Mellanox hardware platform support

lore
Share & tools
lore
#0 lore raw

v2 cover mlxbf-bootctl: Support access to the large icm size and setting the BlueField boot state.

Support 2 new features for the mlxbf-bootctl driver:
1) Enable reading and writing the size of the memory region dedicated to the large ICM carveout.
2) Enable setting the BlueField ARM boot state to "os up". The SMC call involved will handle updating the state in BlueField registers.

Asmaa Mnebhi (2):
mlxbf-bootctl: Support the large icmc write/read
mlxbf-bootctl: Support setting the ARM boot state to "OS up"

 drivers/platform/mellanox/mlxbf-bootctl.c | 67 +++++++++++++++++++++++
 drivers/platform/mellanox/mlxbf-bootctl.h | 19 +++++++
 2 files changed, 86 insertions(+)
Signature · 1 line
2.30.1
#1 lore raw

PATCH v2 1/2 mlxbf-bootctl: Support the large icmc write/read

Enable reading and writing the size of the memory region associated with the large ICM carveout.
The max size of the large ICM carveout is 1TB, has a granularity of 128MB and will be passed and printed in hex. The size unit is MB.

---
v1->v2:
- added defines for icmc related integers
- removed unnecessary parentheses.

 drivers/platform/mellanox/mlxbf-bootctl.c | 42 +++++++++++++++++++++++
 drivers/platform/mellanox/mlxbf-bootctl.h | 14 ++++++++
 2 files changed, 56 insertions(+)
drivers/platform/mellanox/mlxbf-bootctl.c +42 -0
index fb9f7815c6cd..52d1272478a4 100644
@@ -79,6 +79,8 @@ static void __iomem *mlxbf_rsh_scratch_buf_data;
 static const char * const mlxbf_rsh_log_level[] = {
 	"INFO", "WARN", "ERR", "ASSERT"};
 
+static DEFINE_MUTEX(icm_ops_lock);
+
 /* ARM SMC call which is atomic and no need for lock. */
 static int mlxbf_bootctl_smc(unsigned int smc_op, int smc_arg)
 {
@@ -391,6 +393,44 @@ static ssize_t rsh_log_store(struct device *dev,
 	return count;
 }
 
+static ssize_t large_icm_show(struct device *dev,
+				struct device_attribute *attr, char *buf)
+{
+	struct arm_smccc_res res;
+
+	mutex_lock(&icm_ops_lock);
+	arm_smccc_smc(MLNX_HANDLE_GET_ICM_INFO, 0, 0, 0, 0,
+		      0, 0, 0, &res);
+	mutex_unlock(&icm_ops_lock);
+	if (res.a0)
+		return -EPERM;
+
+	return snprintf(buf, PAGE_SIZE, "0x%lx", res.a1);
+}
+
+static ssize_t large_icm_store(struct device *dev,
+			       struct device_attribute *attr,
+			       const char *buf, size_t count)
+{
+	struct arm_smccc_res res;
+	unsigned long icm_data;
+	int err;
+
+	err = kstrtoul(buf, MLXBF_LARGE_ICMC_MAX_STRING_SIZE, &icm_data);
+	if (err)
+		return err;
+
+	if ((icm_data != 0 && icm_data < MLXBF_LARGE_ICMC_SIZE_MIN) ||
+	    icm_data > MLXBF_LARGE_ICMC_SIZE_MAX || icm_data % MLXBF_LARGE_ICMC_GRANULARITY)
+		return -EPERM;
+
+	mutex_lock(&icm_ops_lock);
+	arm_smccc_smc(MLNX_HANDLE_SET_ICM_INFO, icm_data, 0, 0, 0, 0, 0, 0, &res);
+	mutex_unlock(&icm_ops_lock);
+
+	return res.a0 ? -EPERM : count;
+}
+
 static DEVICE_ATTR_RW(post_reset_wdog);
 static DEVICE_ATTR_RW(reset_action);
 static DEVICE_ATTR_RW(second_reset_action);
@@ -398,6 +438,7 @@ static DEVICE_ATTR_RO(lifecycle_state);
 static DEVICE_ATTR_RO(secure_boot_fuse_state);
 static DEVICE_ATTR_WO(fw_reset);
 static DEVICE_ATTR_WO(rsh_log);
+static DEVICE_ATTR_RW(large_icm);
 
 static struct attribute *mlxbf_bootctl_attrs[] = {
 	&dev_attr_post_reset_wdog.attr,
@@ -407,6 +448,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
 	&dev_attr_secure_boot_fuse_state.attr,
 	&dev_attr_fw_reset.attr,
 	&dev_attr_rsh_log.attr,
+	&dev_attr_large_icm.attr,
 	NULL
 };
 
drivers/platform/mellanox/mlxbf-bootctl.h +14 -0
index b48243f60a59..fc5019c90fc5 100644
@@ -81,6 +81,15 @@
  */
 #define MLXBF_BOOTCTL_FW_RESET  0x8200000D
 
+/*
+ * SMC function IDs to set and get the large ICM carveout size
+ * stored in the eeprom.
+ */
+#define MLNX_HANDLE_SET_ICM_INFO    0x82000012
+#define MLNX_HANDLE_GET_ICM_INFO    0x82000013
+
+#define MAX_ICM_BUFFER_SIZE 10
+
 /* SMC function IDs for SiP Service queries */
 #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT	0x8200ff00
 #define MLXBF_BOOTCTL_SIP_SVC_UID		0x8200ff01
@@ -106,4 +115,9 @@
 /* Additional value to disable the MLXBF_BOOTCTL_SET_SECOND_RESET_ACTION. */
 #define MLXBF_BOOTCTL_NONE	0x7fffffff /* Don't change next boot action */
 
+#define MLXBF_LARGE_ICMC_MAX_STRING_SIZE 16
+#define MLXBF_LARGE_ICMC_SIZE_MIN        0x80
+#define MLXBF_LARGE_ICMC_SIZE_MAX        0x100000
+#define MLXBF_LARGE_ICMC_GRANULARITY     MLXBF_LARGE_ICMC_SIZE_MIN
+
 #endif /* __MLXBF_BOOTCTL_H__ */
Signature · 1 line
2.30.1
maintainer Reviewed-by on v2 1/2
#2 lore raw

RE: [PATCH v2 1/2] mlxbf-bootctl: Support the large icmc write/read

Quoted 10 lines

-----Original Message-----
From: Asmaa Mnebhi <[email protected]>
Sent: Wednesday, 9 August 2023 19:29
To: [email protected]; Vadim Pasternak <[email protected]>; [email protected]; [email protected]
Cc: Asmaa Mnebhi <[email protected]>
Subject: [PATCH v2 1/2] mlxbf-bootctl: Support the large icmc write/read

Quoted 6 lines

Enable reading and writing the size of the memory region associated with the large ICM carveout.
The max size of the large ICM carveout is 1TB, has a granularity of 128MB and will be passed and printed in hex. The size unit is MB.

Quoted 119 lines

---
v1->v2:
- added defines for icmc related integers
- removed unnecessary parentheses.

 drivers/platform/mellanox/mlxbf-bootctl.c | 42 +++++++++++++++++++++++
drivers/platform/mellanox/mlxbf-bootctl.h | 14 ++++++++
 2 files changed, 56 insertions(+)
drivers/platform/mellanox/mlxbf-bootctl.c +2 -0
index fb9f7815c6cd..52d1272478a4 100644
@@ -79,6 +79,8 @@ static void __iomem *mlxbf_rsh_scratch_buf_data;
 static const char * const mlxbf_rsh_log_level[] = {
 	"INFO", "WARN", "ERR", "ASSERT"};
 
+static DEFINE_MUTEX(icm_ops_lock);
+
 /* ARM SMC call which is atomic and no need for lock. */  static int

mlxbf_bootctl_smc(unsigned int smc_op, int smc_arg) { @@ -391,6 +393,44 @@ static ssize_t rsh_log_store(struct device *dev,

drivers/platform/mellanox/mlxbf-bootctl.c +21 -0
 	return count;
 }
 
+static ssize_t large_icm_show(struct device *dev,
+				struct device_attribute *attr, char *buf) {
+	struct arm_smccc_res res;
+
+	mutex_lock(&icm_ops_lock);
+	arm_smccc_smc(MLNX_HANDLE_GET_ICM_INFO, 0, 0, 0, 0,
+		      0, 0, 0, &res);
+	mutex_unlock(&icm_ops_lock);
+	if (res.a0)
+		return -EPERM;
+
+	return snprintf(buf, PAGE_SIZE, "0x%lx", res.a1); }
+
+static ssize_t large_icm_store(struct device *dev,
+			       struct device_attribute *attr,
+			       const char *buf, size_t count) {
+	struct arm_smccc_res res;
+	unsigned long icm_data;
+	int err;
+
+	err = kstrtoul(buf, MLXBF_LARGE_ICMC_MAX_STRING_SIZE,

&icm_data);

drivers/platform/mellanox/mlxbf-bootctl.c +5 -0
+	if (err)
+		return err;
+
+	if ((icm_data != 0 && icm_data < MLXBF_LARGE_ICMC_SIZE_MIN) ||
+	    icm_data > MLXBF_LARGE_ICMC_SIZE_MAX || icm_data %

MLXBF_LARGE_ICMC_GRANULARITY)

drivers/platform/mellanox/mlxbf-bootctl.c +4 -0
+		return -EPERM;
+
+	mutex_lock(&icm_ops_lock);
+	arm_smccc_smc(MLNX_HANDLE_SET_ICM_INFO, icm_data, 0, 0, 0,

0, 0, 0, &res);

drivers/platform/mellanox/mlxbf-bootctl.c +5 -0
+	mutex_unlock(&icm_ops_lock);
+
+	return res.a0 ? -EPERM : count;
+}
+
 static DEVICE_ATTR_RW(post_reset_wdog);  static

DEVICE_ATTR_RW(reset_action); static
DEVICE_ATTR_RW(second_reset_action);

drivers/platform/mellanox/mlxbf-bootctl.c +2 -0
@@ -398,6 +438,7 @@ static DEVICE_ATTR_RO(lifecycle_state);  static
 DEVICE_ATTR_RO(secure_boot_fuse_state);
 static DEVICE_ATTR_WO(fw_reset);
 static DEVICE_ATTR_WO(rsh_log);
+static DEVICE_ATTR_RW(large_icm);
 
 static struct attribute *mlxbf_bootctl_attrs[] = {
 	&dev_attr_post_reset_wdog.attr,
@@ -407,6 +448,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
 	&dev_attr_secure_boot_fuse_state.attr,
 	&dev_attr_fw_reset.attr,
 	&dev_attr_rsh_log.attr,
+	&dev_attr_large_icm.attr,
 	NULL
 };
 
drivers/platform/mellanox/mlxbf-bootctl.h +9 -0
index b48243f60a59..fc5019c90fc5 100644
@@ -81,6 +81,15 @@
  */
 #define MLXBF_BOOTCTL_FW_RESET  0x8200000D
 
+/*
+ * SMC function IDs to set and get the large ICM carveout size
+ * stored in the eeprom.
+ */
+#define MLNX_HANDLE_SET_ICM_INFO    0x82000012
+#define MLNX_HANDLE_GET_ICM_INFO    0x82000013
+
+#define MAX_ICM_BUFFER_SIZE 10
+
 /* SMC function IDs for SiP Service queries */
 #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT	0x8200ff00
 #define MLXBF_BOOTCTL_SIP_SVC_UID		0x8200ff01
@@ -106,4 +115,9 @@
 /* Additional value to disable the

MLXBF_BOOTCTL_SET_SECOND_RESET_ACTION. */
#define MLXBF_BOOTCTL_NONE 0x7fffffff /* Don't change next boot
action */

drivers/platform/mellanox/mlxbf-bootctl.h +4 -0
+#define MLXBF_LARGE_ICMC_MAX_STRING_SIZE 16
+#define MLXBF_LARGE_ICMC_SIZE_MIN        0x80
+#define MLXBF_LARGE_ICMC_SIZE_MAX        0x100000
+#define MLXBF_LARGE_ICMC_GRANULARITY

MLXBF_LARGE_ICMC_SIZE_MIN
+
#endif /* __MLXBF_BOOTCTL_H__ */
--
2.30.1

#3 lore raw

PATCH v2 2/2 mlxbf-bootctl: Support setting the ARM boot state to "OS up"

In reply to Asmaa Mnebhi

The BlueField has internal registers to store the ARM boot states. Support setting the BlueField ARM boot state to "OS up".

---
v1->v2:
- No changes made to this patch. It has already been approved. This is just to update [PATCH v2 1/2]

 drivers/platform/mellanox/mlxbf-bootctl.c | 25 +++++++++++++++++++++++
 drivers/platform/mellanox/mlxbf-bootctl.h |  5 +++++
 2 files changed, 30 insertions(+)
drivers/platform/mellanox/mlxbf-bootctl.c +25 -0
index 52d1272478a4..0bf29eee1e70 100644
@@ -80,6 +80,7 @@ static const char * const mlxbf_rsh_log_level[] = {
 	"INFO", "WARN", "ERR", "ASSERT"};
 
 static DEFINE_MUTEX(icm_ops_lock);
+static DEFINE_MUTEX(os_up_lock);
 
 /* ARM SMC call which is atomic and no need for lock. */
 static int mlxbf_bootctl_smc(unsigned int smc_op, int smc_arg)
@@ -431,6 +432,28 @@ static ssize_t large_icm_store(struct device *dev,
 	return res.a0 ? -EPERM : count;
 }
 
+static ssize_t os_up_store(struct device *dev,
+			   struct device_attribute *attr,
+			   const char *buf, size_t count)
+{
+	struct arm_smccc_res res;
+	unsigned long val;
+	int err;
+
+	err = kstrtoul(buf, 10, &val);
+	if (err)
+		return err;
+
+	if (val != 1)
+		return -EINVAL;
+
+	mutex_lock(&os_up_lock);
+	arm_smccc_smc(MLNX_HANDLE_OS_UP, 0, 0, 0, 0, 0, 0, 0, &res);
+	mutex_unlock(&os_up_lock);
+
+	return count;
+}
+
 static DEVICE_ATTR_RW(post_reset_wdog);
 static DEVICE_ATTR_RW(reset_action);
 static DEVICE_ATTR_RW(second_reset_action);
@@ -439,6 +462,7 @@ static DEVICE_ATTR_RO(secure_boot_fuse_state);
 static DEVICE_ATTR_WO(fw_reset);
 static DEVICE_ATTR_WO(rsh_log);
 static DEVICE_ATTR_RW(large_icm);
+static DEVICE_ATTR_WO(os_up);
 
 static struct attribute *mlxbf_bootctl_attrs[] = {
 	&dev_attr_post_reset_wdog.attr,
@@ -449,6 +473,7 @@ static struct attribute *mlxbf_bootctl_attrs[] = {
 	&dev_attr_fw_reset.attr,
 	&dev_attr_rsh_log.attr,
 	&dev_attr_large_icm.attr,
+	&dev_attr_os_up.attr,
 	NULL
 };
 
drivers/platform/mellanox/mlxbf-bootctl.h +5 -0
index fc5019c90fc5..613963d448f2 100644
@@ -90,6 +90,11 @@
 
 #define MAX_ICM_BUFFER_SIZE 10
 
+/*
+ * SMC function ID to set the ARM boot state to up
+ */
+#define MLNX_HANDLE_OS_UP    0x82000014
+
 /* SMC function IDs for SiP Service queries */
 #define MLXBF_BOOTCTL_SIP_SVC_CALL_COUNT	0x8200ff00
 #define MLXBF_BOOTCTL_SIP_SVC_UID		0x8200ff01
Signature · 1 line
2.30.1
#4 lore raw
In reply to Asmaa Mnebhi

HI,

Quoted 7 lines · Asmaa Mnebhi

Support 2 new features for the mlxbf-bootctl driver:
1) Enable reading and writing the size of the memory region dedicated to the large ICM carveout.
2) Enable setting the BlueField ARM boot state to "os up". The SMC call involved will handle updating the state in BlueField registers.

Quoted 7 lines

Asmaa Mnebhi (2):
mlxbf-bootctl: Support the large icmc write/read
mlxbf-bootctl: Support setting the ARM boot state to "OS up"

 drivers/platform/mellanox/mlxbf-bootctl.c | 67 +++++++++++++++++++++++
 drivers/platform/mellanox/mlxbf-bootctl.h | 19 +++++++
 2 files changed, 86 insertions(+)

Thank you for your patch-series, I've applied the series to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

#5 lore raw
Quoted 5 lines
Quoted 4 lines
 drivers/platform/mellanox/mlxbf-bootctl.c | 67
+++++++++++++++++++++++  drivers/platform/mellanox/mlxbf-bootctl.h |
19 +++++++
 2 files changed, 86 insertions(+)
Quoted 9 lines

Thank you for your patch-series, I've applied the series to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-
x86.git/log/?h=review-hans

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Thank you very much Hans!