Skip to contentSkip to conversation

thermal: broadcom: sr-thermal: removed call to platform_set_drvdata()

PATCH Applied Andrei Coardos 3 participants 3 messages Aug 10, 2023 – Aug 16, 2023 Thermal

lore
Share & tools
lore

Andrei Coardos

author
#0 lore raw

PATCH 1/1 thermal: broadcom: sr-thermal: removed call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Signed-off-by Andrei Coardos <[email protected]>
---
 drivers/thermal/broadcom/sr-thermal.c | 1 -
 1 file changed, 1 deletion(-)
drivers/thermal/broadcom/sr-thermal.c +0 -1
index 747915890022..9a29dfd4c7fe 100644
@@ -91,7 +91,6 @@ static int sr_thermal_probe(struct platform_device *pdev)
 
 		dev_dbg(dev, "thermal sensor %d registered\n", i);
 	}
-	platform_set_drvdata(pdev, sr_thermal);
 
 	return 0;
 }
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

I had to take a look over how "thermal_zone_device_priv()" works, and it looks like it has nothing to do with the platform_set_drvdata() / dev_set_drvdata() / dev->driver_data stuff.
It defines it's own devdata pointer.
Though, it looks like "thermal_zone_device_priv()" could potentially be converted to use "dev->driver_data"
But that requires a bit of going through all drivers to convert them.

Anyway, for this:

Reviewed-by Alexandru Ardelean <[email protected]>
Quoted 20 lines
Signed-off-by Andrei Coardos <[email protected]>
---
 drivers/thermal/broadcom/sr-thermal.c | 1 -
 1 file changed, 1 deletion(-)
drivers/thermal/broadcom/sr-thermal.c +0 -2
index 747915890022..9a29dfd4c7fe 100644
@@ -91,7 +91,6 @@ static int sr_thermal_probe(struct platform_device *pdev)
 
                dev_dbg(dev, "thermal sensor %d registered\n", i);
        }
-       platform_set_drvdata(pdev, sr_thermal);
 
        return 0;
 }
--

2.34.1

Applied
#2 lore raw
In reply to Andrei Coardos
Quoted 7 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

Signed-off-by Andrei Coardos <[email protected]>

---

Applied, thanks

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog