Skip to contentSkip to conversation

usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict

PATCH In review Grant B Adams 2 participants 2 messages Aug 11, 2023 – Aug 22, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict

Enabling the tps65217-charger driver/module causes an interrupt conflict with the vbus driver resulting in a probe failure.
The conflict is resolved by changing both driver's threaded interrupt request function from IRQF_ONESHOT to IRQF_SHARED.

---
 drivers/usb/musb/musb_dsps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/musb/musb_dsps.c +1 -1
index 9119b1d51370..cbb45de5a76f 100644
@@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev,
 
 	error = devm_request_threaded_irq(glue->dev, glue->vbus_irq,
 					  NULL, dsps_vbus_threaded_irq,
-					  IRQF_ONESHOT,
+					  IRQF_SHARED,
 					  "vbus", glue);
 	if (error) {
 		glue->vbus_irq = 0;
Signature · 1 line
2.34.1
#1 lore raw
Quoted 26 lines · Grant B Adams

Enabling the tps65217-charger driver/module causes an interrupt conflict with the vbus driver resulting in a probe failure.
The conflict is resolved by changing both driver's threaded interrupt request function from IRQF_ONESHOT to IRQF_SHARED.

---
 drivers/usb/musb/musb_dsps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/musb/musb_dsps.c +1 -1
index 9119b1d51370..cbb45de5a76f 100644
@@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev,
 
 	error = devm_request_threaded_irq(glue->dev, glue->vbus_irq,
 					  NULL, dsps_vbus_threaded_irq,
-					  IRQF_ONESHOT,
+					  IRQF_SHARED,
 					  "vbus", glue);
 	if (error) {
 		glue->vbus_irq = 0;
Signature · 1 line
2.34.1

Where is patch 1/2 of this series?

Please resend the whole series.

thanks,

greg k-h