Skip to contentSkip to conversation

bpftool: fix perf help message

PATCH Applied Daniel T. Lee 3 participants 3 messages Aug 11, 2023 – Aug 12, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bpftool: fix perf help message

Currently, bpftool perf subcommand has typo with the help message.

    $ tools/bpf/bpftool/bpftool perf help
    Usage: bpftool perf { show | list }
           bpftool perf help }

Since this bpftool perf subcommand help message has the extra bracket, this commit fix the typo by removing the extra bracket.

---
 tools/bpf/bpftool/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/bpf/bpftool/perf.c +1 -1
index 91743445e4c7..80de2874dabe 100644
@@ -236,7 +236,7 @@ static int do_help(int argc, char **argv)
 {
 	fprintf(stderr,
 		"Usage: %1$s %2$s { show | list }\n"
-		"       %1$s %2$s help }\n"
+		"       %1$s %2$s help\n"
 		"\n"
 		"       " HELP_SPEC_OPTIONS " }\n"
 		"",
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Daniel T. Lee

Currently, bpftool perf subcommand has typo with the help message.

    $ tools/bpf/bpftool/bpftool perf help
    Usage: bpftool perf { show | list }
           bpftool perf help }

Since this bpftool perf subcommand help message has the extra bracket, this commit fix the typo by removing the extra bracket.

Fixes c07ba629df97 ("tools: bpftool: Update and synchronise option list in doc and help msg")

Thank you

#2 lore raw
In reply to Daniel T. Lee
This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Martin KaFai Lau <[email protected]>:

Quoted 10 lines · On Fri, 11 Aug 2023 21:16:03 +0900 you wrote:

Currently, bpftool perf subcommand has typo with the help message.

    $ tools/bpf/bpftool/bpftool perf help
    Usage: bpftool perf { show | list }
           bpftool perf help }

Since this bpftool perf subcommand help message has the extra bracket, this commit fix the typo by removing the extra bracket.

[...]

Here is the summary with links:
- bpftool: fix perf help message

    https://git.kernel.org/bpf/bpf-next/c/6da4fea89d25

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html