ARC: -Wmissing-prototype warning fixes
Subsystems (2)
Vineet Gupta
maintainerPATCH 1/1 ARC: -Wmissing-prototype warning fixes
Anrd reported [1] new compiler warnings due to -Wmissing-protype. These are for non static functions mostly used in asm code hence not exported already. Fix this by adding the prototypes.
[1] https://lore.kernel.org/lkml/[email protected]
--- arch/arc/include/asm/entry.h | 21 +++++++++++++++++++++ arch/arc/include/asm/irq.h | 1 + arch/arc/include/asm/mmu.h | 2 ++ arch/arc/include/asm/ptrace.h | 3 +++ arch/arc/include/asm/setup.h | 2 ++ arch/arc/include/asm/smp.h | 2 ++ arch/arc/kernel/ctx_sw.c | 2 +- arch/arc/kernel/devtree.c | 1 + arch/arc/kernel/intc-arcv2.c | 2 +- arch/arc/kernel/signal.c | 1 + arch/arc/kernel/smp.c | 7 ++++--- arch/arc/kernel/stacktrace.c | 1 + arch/arc/kernel/traps.c | 1 + arch/arc/mm/cache.c | 8 ++++---- arch/arc/mm/fault.c | 1 + arch/arc/mm/init.c | 1 + arch/arc/mm/tlb.c | 2 +- 17 files changed, 48 insertions(+), 10 deletions(-)
arch/arc/include/asm/entry.h +21 -0
@@ -13,6 +13,8 @@#include <asm/processor.h> /* For VMALLOC_START */ #include <asm/mmu.h> +#ifdef __ASSEMBLY__ +#ifdef CONFIG_ISA_ARCOMPACT #include <asm/entry-compact.h> /* ISA specific bits */ #else
@@ -295,4 +297,23 @@#endif /* CONFIG_ARC_CURR_IN_REG */ +#else /* !__ASSEMBLY__ */ + +extern void do_signal (struct pt_regs *); +extern void do_notify_resume (struct pt_regs *); +extern int do_privilege_fault (unsigned long ,struct pt_regs *); +extern int do_extension_fault (unsigned long ,struct pt_regs *); +extern int insterror_is_error (unsigned long ,struct pt_regs *); +extern int do_memory_error (unsigned long ,struct pt_regs *); +extern int trap_is_brkpt (unsigned long ,struct pt_regs *); +extern int do_misaligned_error (unsigned long ,struct pt_regs *); +extern int do_trap5_error (unsigned long ,struct pt_regs *); +extern int do_misaligned_access (unsigned long ,struct pt_regs *,struct callee_regs *); +extern void do_machine_check_fault (unsigned long ,struct pt_regs *); +extern void do_non_swi_trap (unsigned long ,struct pt_regs *); +extern void do_insterror_or_kprobe (unsigned long ,struct pt_regs *); +extern void do_page_fault (unsigned long ,struct pt_regs *); + +#endif +#endif /* __ASM_ARC_ENTRY_H */
arch/arc/include/asm/irq.h +1 -0
@@ -25,5 +25,6 @@#include <asm-generic/irq.h> extern void arc_init_IRQ (void ); +extern void arch_do_IRQ (unsigned int ,struct pt_regs *);#endif
arch/arc/include/asm/mmu.h +2 -0
@@ -14,6 +14,8 @@ typedef struct { unsigned long asid[NR_CPUS]; /* 8 bit MMU PID + Generation cycle */ } mm_context_t; +extern void do_tlb_overlap_fault (unsigned long ,unsigned long ,struct pt_regs *); +#endif #include <asm/mmu-arcv2.h>
arch/arc/include/asm/ptrace.h +3 -0
@@ -181,6 +181,9 @@ static inline unsigned long regs_get_register(struct pt_regs *regs,return *(unsigned long *)((unsigned long )regs + offset); } +extern int syscall_trace_entry (struct pt_regs *); +extern void syscall_trace_exit (struct pt_regs *); +#endif /* !__ASSEMBLY__ */ #endif /* __ASM_PTRACE_H */
arch/arc/include/asm/setup.h +2 -0
@@ -42,4 +42,6 @@ extern void arc_cache_init(void);extern char *arc_cache_mumbojumbo (int cpu_id,char *buf,int len);extern void read_decode_cache_bcr (void ); +extern void __init handle_uboot_args (void ); +#endif /* __ASMARC_SETUP_H */
arch/arc/include/asm/smp.h +2 -0
@@ -29,6 +29,8 @@ extern void arch_send_call_function_ipi_mask(const struct cpumask *mask);extern void __init smp_init_cpus (void );extern void first_lines_of_secondary (void );extern const char *arc_platform_smp_cpuinfo (void ); +extern void arc_platform_smp_wait_to_boot (int ); +extern void start_kernel_secondary (void );/* * API expected BY platform smp code (FROM arch smp code)
arch/arc/kernel/ctx_sw.c +1 -1
@@ -12,7 +12,7 @@*/ #include <asm/asm-offsets.h> -#include <linux/sched.h> +#include <asm/switch_to.h> #include <linux/sched/debug.h> #define KSP_WORD_OFF ((TASK_THREAD + THREAD_KSP) / 4)
arch/arc/kernel/devtree.c +1 -0
@@ -12,6 +12,7 @@#include <linux/of.h> #include <linux/of_fdt.h> #include <asm/mach_desc.h> +#include <asm/serial.h> #ifdef CONFIG_SERIAL_EARLYCON
arch/arc/kernel/intc-arcv2.c +1 -1
@@ -108,7 +108,7 @@ static void arcv2_irq_unmask(struct irq_data *data)write_aux_reg (AUX_IRQ_ENABLE ,1 ); } -void arcv2_irq_enable (struct irq_data *data) +static void arcv2_irq_enable (struct irq_data *data) {/* set default priority */ write_aux_reg (AUX_IRQ_SELECT , data->hwirq);
arch/arc/kernel/signal.c +1 -0
@@ -53,6 +53,7 @@#include <linux/sched/task_stack.h> #include <asm/ucontext.h> +#include <asm/entry.h> struct rt_sigframe {struct siginfo info;
arch/arc/kernel/smp.c +4 -3
@@ -23,9 +23,10 @@#include <linux/export.h> #include <linux/of_fdt.h> -#include <asm/processor.h> -#include <asm/setup.h> #include <asm/mach_desc.h> +#include <asm/setup.h> +#include <asm/smp.h> +#include <asm/processor.h> #ifndef CONFIG_ARC_HAS_LLSC arch_spinlock_t smp_atomic_ops_lock = __ARCH_SPIN_LOCK_UNLOCKED;
@@ -351,7 +352,7 @@ static inline int __do_IPI(unsigned long msg)* arch-common ISR to handle for inter-processor interrupts * Has hooks for platform specific IPI */ -irqreturn_t do_IPI (int irq,void *dev_id) +static irqreturn_t do_IPI (int irq,void *dev_id) {unsigned long pending;unsigned long __maybe_unused copy;
arch/arc/kernel/stacktrace.c +1 -0
@@ -29,6 +29,7 @@#include <asm/arcregs.h> #include <asm/unwind.h> +#include <asm/stacktrace.h> #include <asm/switch_to.h> /*-------------------------------------------------------------------------
arch/arc/kernel/traps.c +1 -0
@@ -16,6 +16,7 @@#include <linux/ptrace.h> #include <linux/kprobes.h> #include <linux/kgdb.h> +#include <asm/entry.h> #include <asm/setup.h> #include <asm/unaligned.h> #include <asm/kprobes.h>
arch/arc/mm/cache.c +4 -4
@@ -580,7 +580,7 @@ static void __ic_line_inv_vaddr(phys_addr_t paddr, unsigned long vaddr,#endif /* CONFIG_ARC_HAS_ICACHE */ -noinline void slc_op_rgn(phys_addr_t paddr, unsigned long sz, const int op) +static noinline void slc_op_rgn(phys_addr_t paddr, unsigned long sz, const int op) {#ifdef CONFIG_ISA_ARCV2 /*
@@ -643,7 +643,7 @@ noinline void slc_op_rgn(phys_addr_t paddr, unsigned long sz, const int op)#endif } -noinline void slc_op_line(phys_addr_t paddr, unsigned long sz, const int op) +static __maybe_unused noinline void slc_op_line(phys_addr_t paddr, unsigned long sz, const int op) {#ifdef CONFIG_ISA_ARCV2 /*
@@ -966,7 +966,7 @@ SYSCALL_DEFINE3(cacheflush, uint32_t, start, uint32_t, sz, uint32_t, flags)* 3. All Caches need to be disabled when setting up IOC to elide any in-flight * Coherency transactions */ -noinline void __init arc_ioc_setup(void) +static noinline void __init arc_ioc_setup(void) {unsigned int ioc_base, mem_sz;
@@ -1028,7 +1028,7 @@ noinline void __init arc_ioc_setup(void)* one core suffices for all * - IOC setup / dma callbacks only need to be done once */ -void __init arc_cache_init_master (void ) +static noinline void __init arc_cache_init_master(void) {unsigned int __maybe_unused cpu =smp_processor_id ();
arch/arc/mm/fault.c +1 -0
@@ -13,6 +13,7 @@#include <linux/kdebug.h> #include <linux/perf_event.h> #include <linux/mm_types.h> +#include <asm/entry.h> #include <asm/mmu.h> /*
arch/arc/mm/init.c +1 -0
@@ -15,6 +15,7 @@#include <linux/highmem.h> #include <asm/page.h> #include <asm/sections.h> +#include <asm/setup.h> #include <asm/arcregs.h> pgd_t swapper_pg_dir[PTRS_PER_PGD ]__aligned(PAGE_SIZE) ;
arch/arc/mm/tlb.c +1 -1
@@ -389,7 +389,7 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end)/* * Routine to create a TLB entry */ -void create_tlb (struct vm_area_struct *vma,unsigned long vaddr,pte_t *ptep) +static void create_tlb (struct vm_area_struct *vma,unsigned long vaddr,pte_t *ptep) {unsigned long flags;unsigned int asid_or_sasid, rwx;
Signature · 1 line
2.34.1
Quoted 7 lines · Vineet Gupta
Anrd reported [1] new compiler warnings due to -Wmissing-protype. These are for non static functions mostly used in asm code hence not exported already. Fix this by adding the prototypes.
[1] https://lore.kernel.org/lkml/[email protected]
Signed-off-by Vineet Gupta <[email protected]>
Looks good to me,
Vineet Gupta
maintainerQuoted 11 lines · Arnd Bergmann
Quoted 7 lines · Vineet Gupta
Anrd reported [1] new compiler warnings due to -Wmissing-protype. These are for non static functions mostly used in asm code hence not exported already. Fix this by adding the prototypes.
[1] https://lore.kernel.org/lkml/[email protected]
Signed-off-by Vineet Gupta <[email protected]>Looks good to me,
Reviewed-by Arnd Bergmann <[email protected]>
Thx, Arnd.
Added to for-curr.
-Vineet
_______________________________________________
linux-snps-arc mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-snps-arc