Skip to contentSkip to conversation

selftests/bpf: fix repeat option when kfunc_call verify fail

bpf-next Applied Yipeng Zou 2 participants 2 messages Aug 14, 2023

Subsystems (3)
lore
Share & tools
lore

Yipeng Zou

author
#0 lore raw

There is no way to set topts.repeat=1 when tc_test going to verify fail.

Maybe it's clerical error, fix it directly.

Fixes fb66223a244f ("selftests/bpf: add test for accessing ctx from syscall program type")
---
 tools/testing/selftests/bpf/prog_tests/kfunc_call.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/kfunc_call.c +1 -1
index a543742cd7bd..2eb71559713c 100644
@@ -173,8 +173,8 @@ static void verify_fail(struct kfunc_test_params *param)
 	case tc_test:
 		topts.data_in = &pkt_v4;
 		topts.data_size_in = sizeof(pkt_v4);
-		break;
 		topts.repeat = 1;
+		break;
 	}
 
 	skel = kfunc_call_fail__open_opts(&opts);
Signature · 1 line
2.34.1
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann <[email protected]>:

Quoted 9 lines · On Mon, 14 Aug 2023 11:14:34 +0800 you wrote:

There is no way to set topts.repeat=1 when tc_test going to verify fail.

Maybe it's clerical error, fix it directly.

Fixes fb66223a244f ("selftests/bpf: add test for accessing ctx from syscall program type")

[...]

Here is the summary with links:
- [bpf-next] selftests/bpf: fix repeat option when kfunc_call verify fail

    https://git.kernel.org/bpf/bpf-next/c/811915db674f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html