Skip to contentSkip to conversation

libusbgx: usbgx.service: use Type=oneshot

PATCH New [email protected] 1 participant 1 message Aug 14, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libusbgx: usbgx.service: use Type=oneshot

From: Ming Liu <[email protected]>

A regression was introduced by commit:

```
commit 48bc4b2d5e4688bac10bcca26657a5fe660b93ab
Author: Ming Liu <[email protected]>
Date:   Tue May 9 13:36:20 2023 +0200

    libusbgx: fix some systemd service conditions

    Let usbgx.service require and run after sys-kernel-config.mount.

    Use "Type=simple" rather than "Type=oneshot", this ensures
    usbgx.service would not hang on failures, failures could happen in
    many conditions, like if the end user has manually configured
    something in configfs, or start usbgx.service twice, or someting
    wrong in /etc/default/usbgx or /etc/usbgx/*.schema.

    Signed-off-by: Ming Liu <[email protected]>
    Signed-off-by: Khem Raj <[email protected]>
```

In the case when 'Type=simple' is set, 'ExecStartPost=' will execute right after the process in 'ExecStart=' is started, but we need it execute after the last 'ExecStart=' process exited successfully, so change back to "Type=oneshot".

---
 meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-support/libusbgx/libusbgx/usbgx.service +1 -1
index ba92f1ab8..d7d394cfe 100644
@@ -4,7 +4,7 @@ Requires=sys-kernel-config.mount
 After=sys-kernel-config.mount
 
 [Service]
-Type=simple
+Type=oneshot
 ExecStart=/usr/bin/gadget-start
 
 [Install]
Signature · 1 line
2.25.1