Skip to contentSkip to conversation

arm64: dts: socfpga: fix dtbs_check warnings for clocks

PATCH In review Dinh Nguyen 2 participants 2 messages Aug 14, 2023 – Aug 15, 2023

Subsystems (2)
Device tree bindings Arm/socfpga architecture
lore
Share & tools
lore

Dinh Nguyen

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: socfpga: fix dtbs_check warnings for clocks

Fix dtbs_check warning: 'clock-frequency' is a required property.

Signed-off-by Dinh Nguyen <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++++
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi     | 4 ++++
 2 files changed, 8 insertions(+)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +4 -0
index 439497ab967d..cd8123ada2bc 100644
@@ -101,21 +101,25 @@ clocks {
 		cb_intosc_hs_div2_clk: cb-intosc-hs-div2-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;
 		};
 
 		cb_intosc_ls_clk: cb-intosc-ls-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;
 		};
 
 		f2s_free_clk: f2s-free-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;
 		};
 
 		osc1: osc1 {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;
 		};
 
 		qspi_clk: qspi-clk {
arch/arm64/boot/dts/intel/socfpga_agilex.dtsi +4 -0
index d3adb6a130ae..6726f88822f9 100644
@@ -92,21 +92,25 @@ clocks {
 		cb_intosc_hs_div2_clk: cb-intosc-hs-div2-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;
 		};
 
 		cb_intosc_ls_clk: cb-intosc-ls-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;
 		};
 
 		f2s_free_clk: f2s-free-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;
 		};
 
 		osc1: osc1 {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;
 		};
 
 		qspi_clk: qspi-clk {
Signature · 1 line
2.25.1
#1 lore raw
Quoted 1 line · Dinh Nguyen

Fix dtbs_check warning: 'clock-frequency' is a required property.

Frequency of 0 is not usually correct, so this does not look like correct fix.

Quoted 12 lines
Signed-off-by Dinh Nguyen <[email protected]>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 4 ++++
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi     | 4 ++++
 2 files changed, 8 insertions(+)
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +0 -0
index 439497ab967d..cd8123ada2bc 100644

arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi clocks { · line 104

Quoted 4 lines
arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi +1 -0
@@ -101,21 +101,25 @@ clocks {
 		cb_intosc_hs_div2_clk: cb-intosc-hs-div2-clk {
 			#clock-cells = <0>;
 			compatible = "fixed-clock";
+			clock-frequency = <0>;

Best regards,
Krzysztof