platform/mellanox: Fix mlxbf-tmfifo not handling all virtio CONSOLE notifictions
Subsystems (2)
PATCH 1/1 platform/mellanox: Fix mlxbf-tmfifo not handling all virtio CONSOLE notifictions
From: shihyic <[email protected]>
rshim console does not show all entries of dmesg.
Fixed by setting MLXBF_TM_TX_LWM_IRQ for every CONSOLE notification.
Signed-off-by shihyic <[email protected]>
Review-by [email protected]
--- drivers/platform/mellanox/mlxbf-tmfifo.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/platform/mellanox/mlxbf-tmfifo.c +2 -0
@@ -887,6 +887,8 @@ static bool mlxbf_tmfifo_virtio_notify(struct virtqueue *vq) tm_vdev = fifo->vdev[VIRTIO_ID_CONSOLE ];mlxbf_tmfifo_console_output (tm_vdev, vring);spin_unlock_irqrestore (&fifo->spin_lock[0 ], flags); +test_and_set_bit (MLXBF_TM_TX_LWM_IRQ , + &fifo->pend_events); }else if (test_and_set_bit (MLXBF_TM_TX_LWM_IRQ , &fifo->pend_events)) {return true;
Signature · 1 line
2.30.1
Hi,
Quoted 19 lines · Shiih-Yi Chen
From: shihyic <[email protected]>
rshim console does not show all entries of dmesg.
Fixed by setting
MLXBF_TM_TX_LWM_IRQfor every CONSOLE notification.Signed-off-by shihyic <[email protected]>Review-by [email protected]--- drivers/platform/mellanox/mlxbf-tmfifo.c | 2 ++ 1 file changed, 2 insertions(+)drivers/platform/mellanox/mlxbf-tmfifo.c +0
-0
drivers/platform/mellanox/mlxbf-tmfifo.c static bool mlxbf_tmfifo_virtio_notify(struct virtqueue *vq) · line 891
Quoted 5 lines
drivers/platform/mellanox/mlxbf-tmfifo.c +2
-0@@ -887,6 +887,8 @@ static bool mlxbf_tmfifo_virtio_notify(struct virtqueue *vq) tm_vdev = fifo->vdev[VIRTIO_ID_CONSOLE ];mlxbf_tmfifo_console_output (tm_vdev, vring);spin_unlock_irqrestore (&fifo->spin_lock[0 ], flags); +test_and_set_bit (MLXBF_TM_TX_LWM_IRQ , + &fifo->pend_events);
You are not doing anything with the test result of test_and_set_bit() here, so I think you can just use a (cheaper) set_bit() call here ?
Regards,
Hans
Quoted 3 lines
drivers/platform/mellanox/mlxbf-tmfifo.c +0
-0}else if (test_and_set_bit (MLXBF_TM_TX_LWM_IRQ , &fifo->pend_events)) {return true;