drm/amd/display: Simplify bool conversion
Subsystems (3)
PATCH 1/1 drm/amd/display: Simplify bool conversion
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:94:102-107: WARNING: conversion to bool not needed here ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:102:72-77: WARNING: conversion to bool not needed here
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c +2 -2
@@ -91,7 +91,7 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *ac pr_config.replay_supported = true; pr_config.replay_power_opt_supported =0 ; pr_config.replay_enable_option |= pr_enable_option_static_screen; - pr_config.replay_timing_sync_supported = aconnector->max_vfreq >=2 * aconnector->min_vfreq ? true : false; + pr_config.replay_timing_sync_supported = aconnector->max_vfreq >=2 * aconnector->min_vfreq;if (!pr_config.replay_timing_sync_supported) pr_config.replay_enable_option &= ~pr_enable_option_general_ui;
@@ -99,7 +99,7 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *ac debug_flags = (union replay_debug_flags *)&pr_config.debug_flags; debug_flags->u32All =0 ; debug_flags->bitfields.visual_confirm = - link->ctx->dc->debug.visual_confirm ==VISUAL_CONFIRM_REPLAY ? true : false; + link->ctx->dc->debug.visual_confirm ==VISUAL_CONFIRM_REPLAY ; link->replay_settings.replay_feature_enabled = true;
Signature · 1 line
2.20.1.7.g153144c
[AMD Official Use Only - General]
Thanks Li, for the fix, the fix is already in process of merging into amd-staging-drm-next.
https://patchwork.freedesktop.org/patch/552568/
-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Yang Li
Sent: Wednesday, August 16, 2023 6:16 AM
To: [email protected]; [email protected]; Deucher, Alexander <[email protected]>; Wentland, Harry <[email protected]>; Siqueira, Rodrigo <[email protected]>
Cc: Yang Li <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: [PATCH -next] drm/amd/display: Simplify bool conversion
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:94:102-107: WARNING: conversion to bool not needed here ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c:102:72-77: WARNING: conversion to bool not needed here
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_replay.c +2 -1
@@ -91,7 +91,7 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *ac pr_config.replay_supported = true; pr_config.replay_power_opt_supported =0 ; pr_config.replay_enable_option |= pr_enable_option_static_screen; - pr_config.replay_timing_sync_supported = aconnector->max_vfreq >=2 * aconnector->min_vfreq ? true : false; + pr_config.replay_timing_sync_supported = aconnector->max_vfreq >=2 * +aconnector->min_vfreq;if (!pr_config.replay_timing_sync_supported)
pr_config.replay_enable_option &= ~pr_enable_option_general_ui; @@ -99,7 +99,7 @@ bool amdgpu_dm_setup_replay(struct dc_link *link, struct amdgpu_dm_connector *ac
debug_flags = (union replay_debug_flags *)&pr_config.debug_flags;
debug_flags->u32All = 0;
debug_flags->bitfields.visual_confirm =- link->ctx->dc->debug.visual_confirm == VISUAL_CONFIRM_REPLAY ? true : false;
+ link->ctx->dc->debug.visual_confirm == VISUAL_CONFIRM_REPLAY;
link->replay_settings.replay_feature_enabled = true;
--
2.20.1.7.g153144c