Skip to contentSkip to conversation

qga: Start qemu-ga service after NetworkManager start

PATCH In review Efim Shevrin via 5 participants 7 messages Aug 16, 2023 – Aug 17, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qga: Start qemu-ga service after NetworkManager start

From: Fima Shevrin <[email protected]>

When the guest OS starts, qemu-ga sends an event to the host. This event allows services on the host to start configuring the already running guest OS. When configuring network settings, it is possible that an external service will receive a signal from qemu-ga about the start of guest OS, while NetworkManager may not be running yet. Therefore, network setting may not be available. With the current patch, we eliminate the described race condition between qemu-ga and NetworkManager for guest OS network setting cases.

---
 contrib/systemd/qemu-guest-agent.service | 1 +
 1 file changed, 1 insertion(+)
contrib/systemd/qemu-guest-agent.service +1 -0
index 51cd7b37ff..6e2d059356 100644
@@ -2,6 +2,7 @@
 Description=QEMU Guest Agent
 BindTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device
 After=dev-virtio\x2dports-org.qemu.guest_agent.0.device
+After=NetworkManager.service
 
 [Service]
 ExecStart=-/usr/bin/qemu-ga
Signature · 1 line
2.34.1
#1 lore raw

Hi, Efim

Thanks for your contribution.

I think your patch is a partial solution because other network managers can be used
for example systemd-networkd or dhcpcd. Maybe a better solution is After=network.target.

Do you have any other suggestions?

Best Regards,
Konstantin Kostiuk.

Quoted 34 lines · Efim Shevrin

From: Fima Shevrin <[email protected]>

When the guest OS starts, qemu-ga sends an event to the host. This event allows services on the host to start configuring the already running guest OS. When configuring network settings, it is possible that an external service will receive a signal from qemu-ga about the start of guest OS, while NetworkManager may not be running yet. Therefore, network setting may not be available. With the current patch, we eliminate the described race condition between qemu-ga and NetworkManager for guest OS network setting cases.

---
 contrib/systemd/qemu-guest-agent.service | 1 +
 1 file changed, 1 insertion(+)
contrib/systemd/qemu-guest-agent.service +1 -1
index 51cd7b37ff..6e2d059356 100644
@@ -2,6 +2,7 @@
 Description=QEMU Guest Agent
 BindTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device
 After=dev-virtio\x2dports-org.qemu.guest_agent.0.device
+After=NetworkManager.service
 
 [Service]
 ExecStart=-/usr/bin/qemu-ga
--

2.34.1

#2 lore raw
Quoted 8 lines · Konstantin Kostiuk

Hi, Efim

Thanks for your contribution.

I think your patch is a partial solution because other network managers can be used
for example systemd-networkd or dhcpcd. Maybe a better solution is After=network.target.

network.target does not imply that any NICs are configured with an IP address, merely that the networking mgmt daemon(s) are running. A dep on NetworkManager.service has the same issue. NetworkManager has started, but this doesn't imply DHCP has completed

network-online.target has the semantics that an IP is present, but per my other reply I don't think we should be serializing QGA startup against network configuration.

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#3 lore raw
In reply to Efim Shevrin via
Quoted 11 lines · Efim Shevrin via

From: Fima Shevrin <[email protected]>

When the guest OS starts, qemu-ga sends an event to the host. This event allows services on the host to start configuring the already running guest OS. When configuring network settings, it is possible that an external service will receive a signal from qemu-ga about the start of guest OS, while NetworkManager may not be running yet. Therefore, network setting may not be available. With the current patch, we eliminate the described race condition between qemu-ga and NetworkManager for guest OS network setting cases.

A host mgmt app should not be assuming that networking is running at all, and if it is, the guest might not even be on the same subnet as the host. Conceivably someone could even be using QGA to inject files to configure networking.

Overall, IMHO, it is wrong to correlate host notification that QGA is running, with any assumption about state of the guest networking.

IOW, I don't think we should make an attempt to serialize startup of QGA after guest networking. The QGA should be run as soon as its data transport (virtio-serial/vsock) is available, which is the current state.

If a host consumer of QGA wants to do something with guest networking, they should check for guest network state with the 'guest-network-get-interfaces' command.

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#4 lore raw
Quoted 21 lines · Daniel P. Berrangé
Quoted 11 lines · Efim Shevrin via

From: Fima Shevrin <[email protected]>

When the guest OS starts, qemu-ga sends an event to the host. This event allows services on the host to start configuring the already running guest OS. When configuring network settings, it is possible that an external service will receive a signal from qemu-ga about the start of guest OS, while NetworkManager may not be running yet. Therefore, network setting may not be available. With the current patch, we eliminate the described race condition between qemu-ga and NetworkManager for guest OS network setting cases.

A host mgmt app should not be assuming that networking is running at all, and if it is, the guest might not even be on the same subnet as the host. Conceivably someone could even be using QGA to inject files to configure networking.

Overall, IMHO, it is wrong to correlate host notification that QGA is running, with any assumption about state of the guest networking.

Quoted 8 lines

IOW, I don't think we should make an attempt to serialize startup of QGA after guest networking. The QGA should be run as soon as its data transport (virtio-serial/vsock) is available, which is the current state.

If a host consumer of QGA wants to do something with guest networking, they should check for guest network state with the 'guest-network-get-interfaces' command.

This is very tight question at my opinion.

Frankly speaking my original intention here would be to put QGA at the very end of the startup sequence in order to avoid complications. In the other case any host side software, which would like to control the guest behavior will be in trouble.

For example, yet another common application is a guest backup, here I would say application based backup. In a normal case this is done through /etc/qemu-ga/fsfreeze-hook

I would say that agent should start very last, in the other case *ANY* software working through the agent must take efforts to avoid such transient state, which is complicated.

Den

#5 lore raw
Quoted 39 lines · Denis V. Lunev
Quoted 21 lines · Daniel P. Berrangé
Quoted 11 lines · Efim Shevrin via

From: Fima Shevrin <[email protected]>

When the guest OS starts, qemu-ga sends an event to the host. This event allows services on the host to start configuring the already running guest OS. When configuring network settings, it is possible that an external service will receive a signal from qemu-ga about the start of guest OS, while NetworkManager may not be running yet. Therefore, network setting may not be available. With the current patch, we eliminate the described race condition between qemu-ga and NetworkManager for guest OS network setting cases.

A host mgmt app should not be assuming that networking is running at all, and if it is, the guest might not even be on the same subnet as the host. Conceivably someone could even be using QGA to inject files to configure networking.

Overall, IMHO, it is wrong to correlate host notification that QGA is running, with any assumption about state of the guest networking.

Quoted 8 lines

IOW, I don't think we should make an attempt to serialize startup of QGA after guest networking. The QGA should be run as soon as its data transport (virtio-serial/vsock) is available, which is the current state.

If a host consumer of QGA wants to do something with guest networking, they should check for guest network state with the 'guest-network-get-interfaces' command.

This is very tight question at my opinion.

Frankly speaking my original intention here would be to put QGA at the very end of the startup sequence in order to avoid complications. In the other case any host side software, which would like to control the guest behavior will be in trouble.

Quoted 4 lines

For example, yet another common application is a guest backup, here I would say application based backup. In a normal case this is done through /etc/qemu-ga/fsfreeze-hook

It will already be started after local-fs.target, since it does not have DefaultDependencies=no set. This should be sufficient for fsfreeze use cases IIUC.

Quoted 4 lines

I would say that agent should start very last, in the other case *ANY* software working through the agent must take efforts to avoid such transient state, which is complicated.

With regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
#6 lore raw
In reply to Daniel P. Berrangé

17.08.2023 13:26, Daniel P. Berrangé wrote:
..

Quoted 9 lines

A host mgmt app should not be assuming that networking is running at all, and if it is, the guest might not even be on the same subnet as the host. Conceivably someone could even be using QGA to inject files to configure networking.

Overall, IMHO, it is wrong to correlate host notification that QGA is running, with any assumption about state of the guest networking.

Quoted 8 lines

IOW, I don't think we should make an attempt to serialize startup of QGA after guest networking. The QGA should be run as soon as its data transport (virtio-serial/vsock) is available, which is the current state.

If a host consumer of QGA wants to do something with guest networking, they should check for guest network state with the 'guest-network-get-interfaces' command.

Full nod.

/mjt