drm/amd/pm: Fix unsigned expression compared with zero
PATCH 1/1 drm/amd/pm: Fix unsigned expression compared with zero
The val is defined as unsigned int type, if(val<0) is invalid, modify to int type.
drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_pm.c:2813 amdgpu_hwmon_show_power_input() warn: unsigned 'val' is never less than zero. drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_pm.c:2800 amdgpu_hwmon_show_power_avg() warn: unsigned 'val' is never less than zero.
--- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +2 -2
@@ -2794,7 +2794,7 @@ static ssize_t amdgpu_hwmon_show_power_avg(struct device *dev,struct device_attribute *attr, char *buf) { - unsigned int val; + int val; val =amdgpu_hwmon_get_power (dev,AMDGPU_PP_SENSOR_GPU_AVG_POWER );if (val <0 )
@@ -2807,7 +2807,7 @@ static ssize_t amdgpu_hwmon_show_power_input(struct device *dev,struct device_attribute *attr, char *buf) { - unsigned int val; + int val; val =amdgpu_hwmon_get_power (dev,AMDGPU_PP_SENSOR_GPU_INPUT_POWER );if (val <0 )
Signature · 1 line
2.20.1.7.g153144c
Quoted 10 lines · Jiapeng Chong
The val is defined as unsigned int type, if(val<0) is invalid, modify to int type.
drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_pm.c:2813amdgpu_hwmon_show_power_input()warn: unsigned 'val' is never less than zero.drivers/gpu/drm/amd/amdgpu/../pm/amdgpu_pm.c:2800amdgpu_hwmon_show_power_avg()warn: unsigned 'val' is never less than zero.Reported-by Abaci Robot <[email protected]>Signed-off-by Jiapeng Chong <[email protected]>
Thanks. The function signatures for amdgpu_hwmon_get_power() and amdgpu_hwmon_get_sensor_generic() should be fixed up as well. I'll send out a fix.
Alex
Quoted 29 lines
--- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/pm/amdgpu_pm.c +2
-3@@ -2794,7 +2794,7 @@ static ssize_t amdgpu_hwmon_show_power_avg(struct device *dev,struct device_attribute *attr, char *buf) { - unsigned int val; + int val; val =amdgpu_hwmon_get_power (dev,AMDGPU_PP_SENSOR_GPU_AVG_POWER );if (val <0 )@@ -2807,7 +2807,7 @@ static ssize_t amdgpu_hwmon_show_power_input(struct device *dev,struct device_attribute *attr, char *buf) { - unsigned int val; + int val; val =amdgpu_hwmon_get_power (dev,AMDGPU_PP_SENSOR_GPU_INPUT_POWER );if (val <0 ) --2.20.1.7.g153144c