22.11.3 patches review and test
Hi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1
These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/
Thanks.
Xueming Li <[email protected]>
---
Aakash Sasidharan (1):
test/crypto: fix PDCP-SDAP test vectors
Akhil Goyal (1):
doc: fix auth algos in cryptoperf app
Alexander Kozyrev (4):
net/mlx5: forbid MPRQ restart net/mlx5: fix MPRQ stride size for headroom net/mlx5: fix handle validation for meter mark app/testpmd: fix meter mark handle update
Ali Alnubani (2):
doc: fix typos and wording in flow API guide
doc: improve wording of cuda guide
Alvaro Karsz (1):
dma/dpaa2: set VFA bit for route-by-port with VF
Anoob Joseph (1):
cryptodev: clarify error codes for symmetric session
Artemii Morozov (1):
common/sfc_efx/base: fix Rx queue without RSS hash prefix
Ashwin Sekhar T K (2):
mempool/cnxk: avoid hang when counting batch allocs
doc: fix typo in graph guide
Bing Zhao (12):
app/testpmd: fix flow rule number parsing net/mlx5: fix error set in Tx representor tagging net/mlx5: fix return value of vport action net/mlx5: fix error set in control tables create net/mlx5: fix error set for age pool initialization net/mlx5: fix error in VLAN actions creation common/mlx5: fix obtaining IB device in LAG mode net/mlx5: fix profile check of meter mark net/mlx5: reduce counter pool name length net/mlx5: fix drop action memory leak net/mlx5: fix validation for conntrack indirect action
doc: add flow template API requirements for mlx5
Boleslav Stankevich (2):
net/virtio: propagate interrupt configuration error values net/virtio: fix initialization to return negative errno
Bruce Richardson (4):
kernel/freebsd: fix function parameter list
telemetry: fix autotest on Alpine
eal: avoid calling cleanup twice test/bonding: fix include of standard header
Chaoyong He (14):
net/nfp: fix VLAN push flow action
net/nfp: fix IPv6 flow item
net/nfp: fix TOS of IPv6 VXLAN encap flow action net/nfp: fix TOS of IPv6 GENEVE encap flow action net/nfp: fix TOS of IPv6 NVGRE encap flow action net/nfp: fix TP flow action for UDP
net/nfp: fix IPv6 address for set flow action net/nfp: fix unneeded endian conversion net/nfp: fix endian conversion for tunnel decap action net/nfp: fix VNI of VXLAN encap action net/nfp: fix VNI of IPv4 NVGRE encap action net/nfp: fix VNI of IPv6 NVGRE encap action net/nfp: fix Tx descriptor free logic of NFD3 net/nfp: fix offloading flows
Chengwen Feng (4):
net/hns3: fix Rx multiple firmware reset interrupts net/hns3: fix mbuf leakage when RxQ started during reset net/hns3: fix mbuf leakage when RxQ started after reset net/hns3: fix device start return value
Ciara Power (6):
crypto/qat: fix stack buffer overflow in SGL loop crypto/scheduler: fix last element for valid args crypto/ipsec_mb: optimize allocation in session crypto/qat: fix null algorithm digest placement
cryptodev: fix device socket ID type app/crypto-perf: fix socket ID default value
Dariusz Sosnowski (1):
net/mlx5: fix drop action attribute validation
David Christensen (1):
net/tap: set locally administered bit for fixed MAC address
David Marchand (9):
ci: fix build for Arm cross compilation in GHA net/virtio-user: fix leak when initialisation fails net/mlx5: enhance error log for tunnel offloading examples/l2fwd-cat: fix external build examples/fips_validation: fix external build
test: add graph tests
mbuf: fix Doxygen comment of distributor metadata
ci: fix libabigail cache in GHA
doc: fix link to flow capabilities from bnxt guide
Dengdui Huang (3):
net/hns3: fix variable type mismatch
net/hns3: fix inaccurate log
net/hns3: fix redundant line break in log
Denis Pryazhennikov (3):
ethdev: update documentation for API to set FEC
ethdev: check that at least one FEC mode is specified
ethdev: update documentation for API to get FEC
Devendra Singh Rawat (1):
net/qede: fix RSS indirection table initialization
Didier Pallard (2):
crypto/openssl: fix memory leak in auth processing crypto/openssl: skip workaround at compilation time
Dmitry Kozlyuk (1):
member: fix PRNG seed reset in NitroSketch mode
Dongdong Liu (3):
doc: fix kernel patch link in hns3 guide
doc: fix syntax in hns3 guide
doc: fix number of leading spaces in hns3 guide
Elena Agostini (1):
net: fix return type of IPv4 L4 packet checksum
Erez Ferber (1):
common/mlx5: adjust fork call with new kernel API
Erik Gabriel Carrillo (1):
eventdev/timer: fix buffer flush
Feifei Wang (1):
ring: fix dequeue parameter name
Fengnan Chang (2):
eal/linux: fix legacy mem init with many segments
mem: fix memsegs exhausted message
Ferruh Yigit (3):
kni: fix build with Linux 6.3
app/testpmd: revert primary process polling all queues fix
kni: fix build with Linux 6.5
Gregory Etelson (1):
net/mlx5: fix flow workspace destruction
Heng Jiang (1):
net/mlx5: fix LRO TCP checksum
Hernan Vargas (2):
baseband/fpga_5gnr_fec: fix possible division by zero baseband/fpga_5gnr_fec: fix starting unconfigured queue
Huisong Li (10):
ethdev: fix MAC address occupies two entries net/hns3: fix never set MAC flow control net/hns3: fix RTC time on initialization net/hns3: fix RTC time after reset net/hns3: uninitialize PTP
net/hns3: extract PTP to its own header file net/hns3: fix IMP reset trigger net/hns3: delete duplicate macro definition net/hns3: fix non-zero weight for disabled TC net/hns3: fix index to look up table in NEON Rx
Ivan Malov (2):
net/sfc: stop misuse of Rx ingress m-port metadata on EF100 net/sfc: invalidate dangling MAE flow action FW resource IDs
Jerin Jacob (4):
examples/ip_pipeline: fix build with GCC 13
examples/ntb: fix build with GCC 13
net/hns3: fix build warning
doc: remove warning with Doxygen 1.9.7
Jiawen Wu (11):
net/txgbe/base: fix Tx with fiber hotplug
net/txgbe: fix interrupt enable mask
net/txgbe: adapt to MNG veto bit setting
net/txgbe: fix to set autoneg for 1G speed
net/txgbe: fix extended statistics
net/ngbe: fix extended statistics
net/ngbe: adapt to MNG veto bit setting
net/ngbe: fix link status in no LSC mode
net/ngbe: remove redundant codes
net/txgbe: fix blocking system events
net/ngbe: fix RSS offload capability
Jie Hai (6):
net/hns3: fix FEC mode for 200G ports net/hns3: fix FEC mode check
net/hns3: fix missing FEC capability net/hns3: fix uninitialized variable
ethdev: fix calloc arguments
app/testpmd: fix primary process not polling all queues
Jieqiang Wang (1):
net/i40e: fix comments
Junfeng Guo (4):
net/ice: fix protocol agnostic offloading with big packets net/iavf: fix protocol agnostic offloading with big packets raw/ntb: avoid disabling interrupt twice
doc: update BIOS settings and supported HW for NTB
Kai Ji (1):
examples/ipsec-secgw: fix socket ID default value
Kaijun Zeng (1):
net/vmxnet3: fix return code in initializing
Kaiwen Deng (3):
net/ice: fix DCF RSS initialization net/iavf: fix virtchnl command called in interrupt net/ice: fix MAC type of E822 and E823
Kaiyu Zhang (1):
ethdev: fix potential leak in PCI probing helper
Kamalakannan R (1):
pipeline: fix double free for table stats
Ke Xu (1):
net/iavf: fix tunnel TSO path selection
Leyi Rong (1):
eal/x86: improve multiple of 64 bytes memcpy performance
Long Li (7):
net/mana: use datapath logging
net/mana: avoid unnecessary assignments in data path net/mana: optimize completion queue by batch processing net/mana: return probing failure if no device found net/mana: fix counter overflow for posted WQE net/mana: fix WQE count for ringing RQ doorbell net/mana: fix Tx queue statistics
Long Wu (5):
net/nfp: fix control mempool creation net/nfp: fix representor creation net/nfp: fix flow hash table creation net/bonding: fix destroy dedicated queues flow net/nfp: fix representor name too long
Maayan Kashani (1):
net/mlx5: fix RSS expansion inner buffer overflow
Mattias Rönnblom (1):
event/dsw: free rings on close
Maxime Coquelin (3):
vhost: fix notification stats for packed ring
vhost: fix invalid call FD handling crypto/qat: fix sym device prototype
Michael Baum (1):
doc: fix format in flow API guide
Michal Schmidt (1):
net/iavf: fix VLAN offload with AVX512
Min Zhou (1):
net/ixgbe: add proper memory barriers in Rx
Mingjin Ye (3):
net/ice: fix statistics
net/ice: fix DCF control thread crash
net/iavf: fix abnormal disable HW interrupt
Mohammad Iqbal Ahmad (1):
examples/l3fwd: fix duplicate expression for default nexthop
Nithin Dabilpuram (2):
common/cnxk: fix inline device VF identification net/cnxk: fix cookies check with security offload
Ori Kam (1):
net/mlx5: fix query for NIC flow capability
Pavan Nikhilesh (2):
doc: fix event timer adapter guide event/cnxk: fix nanoseconds to ticks conversion
Peng Zhang (1):
net/nfp: fix address always related with PF ID 0
Philip Prindeville (1):
vfio: fix include with musl runtime
Qi Zhang (2):
common/idpf: remove device stop flag
net/ice: initialize parser for double VLAN
Qiming Yang (7):
net/ice/base: fix incorrect defines for DCBx net/ice/base: remove unreachable code net/e1000: fix queue number initialization net/ice: fix VLAN mode parser net/ixgbe: fix Rx and Tx queue status net/igc: fix Rx and Tx queue status net/e1000: fix Rx and Tx queue status
Qin Ke (1):
net/nfp: fix disabling promiscuous mode
Rahul Bhansali (6):
examples/ipsec-secgw: fix zero address in ethernet header common/cnxk: fix IPsec IPv6 tunnel address byte swap event/cnxk: fix Tx adapter data pointer event/cnxk: fix mempool cookies check test/security: fix event inline IPsec reassembly tests common/cnxk: fix CPT backpressure disable on LBK
Rakesh Kudurumalla (1):
common/cnxk: fix receive queue with multiple mask
Raslan Darawsheh (2):
app/testpmd: fix GTP L2 length in checksum engine
devtools: fix bashism in mailmap check
Ronak Doshi (1):
net/vmxnet3: fix drop of empty segments in Tx
Rongwei Liu (4):
net/mlx5: fix matcher layout size calculation net/mlx5: fix VXLAN matching with zero value net/mlx5: forbid duplicated tag index in pattern template net/mlx5: fix duplicated tag index matching in SWS
Ruifeng Wang (5):
test/malloc: fix missing free test/malloc: fix statistics checks
build: fix warning when getting NUMA nodes test/mbuf: fix crash in a forked process net/mlx5: fix risk in NEON Rx descriptor read
Samina Arshad (1):
examples/fips_validation: fix digest length in AES-GCM
Saoirse O'Donovan (3):
test/crypto: fix return value for SNOW3G crypto/openssl: fix memory free crypto/ipsec_mb: fix enqueue counter for SNOW3G
Satha Rao (1):
net/cnxk: flush SQ before configuring MTU
Satheesh Paul (3):
common/cnxk: fix setting channel mask for SDP interfaces common/cnxk: fix uninitialized pointer read net/cnxk: fix flow queue index validation
Sean Zhang (1):
net/mlx5: fix flow dump for modify field
Shijith Thotton (2):
eventdev/timer: fix timeout event wait behavior event/cnxk: fix setting attributes in empty get work
Shiyang He (4):
net/iavf: release large VF when closing device net/ice: fix tunnel packet Tx descriptor net/i40e: fix tunnel packet Tx descriptor app/testpmd: fix checksum engine with GTP on 32-bit
Stephen Hemminger (2):
net/netvsc: fix sizeof calculation
doc: fix description of runtime directories
Suanming Mou (1):
ethdev: fix indirect action conversion
Tejasree Kondoj (3):
test/crypto: fix session creation check
crypto/cnxk: fix IPsec CCM capabilities
test/crypto: fix IPsec AES CCM vector
Thierry Herbelot (1):
doc: fix typo in cnxk platform guide
Thomas Monjalon (3):
pci: fix comment referencing renamed function
cryptodev: fix comments of modular operation parameters
devtools: fix mailmap check for parentheses
Tianli Lai (1):
net/dpaa2: fix checksum good flags
Viacheslav Ovsiienko (2):
net/mlx5: fix device removal event handling
ipc: fix file descriptor leakage with unhandled messages
Vikash Poddar (2):
common/qat: fix command parameter corruption common/qat: detach crypto from compress build
Vladimir Medvedkin (3):
fib: fix adding default route
hash: fix reading unaligned bits in Toeplitz hash examples/ipsec-secgw: fix TAP default MAC address
Wenjing Qiao (7):
common/idpf/base: fix control queue send and receive common/idpf/base: fix ITR register definitions for AVF common/idpf/base: fix parameters when send msg to cp common/idpf/base: fix memory leaks on control queue net/ice: adjust timestamp mbuf register net/ice: fix timestamp enabling
common/iavf: fix MAC type for 710 NIC
Wenjun Wu (5):
net/i40e: fix Rx data buffer size
net/ice: fix Rx data buffer size
net/iavf: fix Rx data buffer size
net/idpf: fix Rx data buffer size common/idpf: fix memory leak on AVX512 Tx queue close
Wenzhuo Lu (1):
net/iavf: fix VLAN insertion in vector path
Xiao Liang (1):
ipsec: fix NAT-T header length
Yiding Zhou (1):
net/ice: fix 32-bit build
Yunjian Wang (2):
ring: fix use after free
net/txgbe: fix use-after-free on remove
Yuying Zhang (1):
net/ice: fix RSS hash key generation
Zerun Fu (1):
net/bonding: fix startup when NUMA is not supported
Zhichao Zeng (2):
net/ice: fix outer UDP checksum offload
net/iavf: fix stop ordering
Zhihong Wang (1):
eal/linux: fix secondary process crash for mp hotplug requests
Quoted 31 lines
-----Original Message-----
From: Xueming(Steven) Li <[email protected]>
Sent: Thursday, August 17, 2023 9:14 AM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; [email protected]; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Ian Stokes <[email protected]>; Jerin Jacob <[email protected]>; John McNamara <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; [email protected]; Raslan Darawsheh <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Yanghang Liu <[email protected]>; [email protected]; [email protected]
Subject: 22.11.3 patches review and testHi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1
Quoted 8 lines
These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
Xueming Li <[email protected]>
---
Hello,
We ran the following functional tests with Nvidia hardware on v22.11.3-rc1:
- Basic functionality:
Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
- rte_flow tests.
- Some RSS tests.
- VLAN filtering, stripping and insertion tests.
- Checksum and TSO tests.
- ptype tests.
- link_status_interrupt example application tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.
- Hardware LRO tests.
- Regex application tests.
- Buffer Split tests.
- Tx scheduling tests.
Functional tests ran on:
- NIC: ConnectX-6 Dx / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-23.07-0.5.0.0 / Firmware: 22.38.1002
- NIC: ConnectX-7 / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-23.07-0.5.0.0 / Firmware: 28.38.1002
- DPU: BlueField-2 / DOCA SW version: 2.2.0 / Firmware: 24.38.1002
Build tests (all passed):
- Ubuntu 20.04.6 with MLNX_OFED_LINUX-23.04-1.1.3.0.
- Ubuntu 20.04.6 with rdma-core master (4cce53f).
- Ubuntu 20.04.6 with rdma-core v28.0.
- Ubuntu 18.04.6 with rdma-core master (4cce53f) (i386).
- Fedora 38 with rdma-core v44.0.
- Fedora 39 (Rawhide) with rdma-core v46.0.
- OpenSUSE Leap 15.5 with rdma-core v42.0.
- Windows Server 2019 with Clang 11.0.0.
We don't see new issues caused by the changes in this release.
Thanks,
Ali
Hi Ali,
Thanks for testing and report!
Regards,
Xueming
Quoted 101 lines
-----Original Message-----
From: Ali Alnubani <[email protected]>
Sent: 8/25/2023 0:02
To: Xueming(Steven) Li <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; [email protected]; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Ian Stokes <[email protected]>; Jerin Jacob <[email protected]>; John McNamara <[email protected]>; Ju- Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; [email protected]; Raslan Darawsheh <[email protected]>; NBU-Contact- Thomas Monjalon (EXTERNAL) <[email protected]>; Yanghang Liu <[email protected]>; [email protected]; [email protected]; Wael Abualrub <[email protected]>
Subject: RE: 22.11.3 patches review and testQuoted 6 lines
-----Original Message-----
From: Xueming(Steven) Li <[email protected]>
Sent: Thursday, August 17, 2023 9:14 AM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>;Quoted 8 lines
[email protected]; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Ian Stokes <[email protected]>; Jerin Jacob <[email protected]>; John McNamara <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; [email protected]; Raslan Darawsheh <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>;
Yanghang
Quoted 1 line
Liu <[email protected]>; [email protected];
Quoted 16 lines
Subject: 22.11.3 patches review and test
Hi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1Quoted 8 lines
These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
Xueming Li <[email protected]>
---
Hello,
We ran the following functional tests with Nvidia hardware on v22.11.3-rc1:
- Basic functionality:
Send and receive multiple types of traffic.
- testpmd xstats counter test.
- testpmd timestamp test.
- Changing/checking link status through testpmd.
-rte_flowtests.
- Some RSS tests.
- VLAN filtering, stripping and insertion tests.
- Checksum and TSO tests.
- ptype tests.
-link_status_interruptexample application tests.
- l3fwd-power example application tests.
- Multi-process example applications tests.
- Hardware LRO tests.
- Regex application tests.
- Buffer Split tests.
- Tx scheduling tests.Functional tests ran on:
- NIC: ConnectX-6 Dx / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-23.07- 0.5.0.0 / Firmware: 22.38.1002
- NIC: ConnectX-7 / OS: Ubuntu 20.04 / Driver: MLNX_OFED_LINUX-23.07- 0.5.0.0 / Firmware: 28.38.1002
- DPU: BlueField-2 / DOCA SW version: 2.2.0 / Firmware: 24.38.1002Build tests (all passed):
- Ubuntu 20.04.6 with MLNX_OFED_LINUX-23.04-1.1.3.0.
- Ubuntu 20.04.6 with rdma-core master (4cce53f).
- Ubuntu 20.04.6 with rdma-core v28.0.
- Ubuntu 18.04.6 with rdma-core master (4cce53f) (i386).
- Fedora 38 with rdma-core v44.0.
- Fedora 39 (Rawhide) with rdma-core v46.0.
- OpenSUSE Leap 15.5 with rdma-core v42.0.
- Windows Server 2019 with Clang 11.0.0.We don't see new issues caused by the changes in this release.
Thanks,
Ali
Quoted 27 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: 22.11.3 patches review and testHi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not backported to 22.11.3. Fix patch commit id on DPDK main: 7e7b6762eac292e78c77ad37ec0973c0c944b845
2. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 on v22.11.3-rc1.
This commit is for the new feature (avx512 checksum offload) in DPDK 23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Regards,
Xu, Hailin
Quoted 58 lines
-----Original Message-----
From: Xu, HailinX <[email protected]>
Sent: 8/29/2023 16:22
To: Xueming(Steven) Li <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; NBU- Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: RE: 22.11.3 patches review and testQuoted 5 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek MaratheQuoted 8 lines
<[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>;
Thomas
Quoted 15 lines
Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: 22.11.3 patches review and testHi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
Quoted 7 lines
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not backported to
22.11.3.
Fix patch commit id on DPDK main:7e7b6762eac292e78c77ad37ec0973c0c944b845
Hailin, thanks for the verification and feedback!
From original patch discussion, the origin decision is no backport, that's why "cc:[email protected]" get removed.
Quoted 6 lines
2. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode commit
9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3on v22.11.3-rc1. This commit is for the new feature (avx512 checksum offload) in DPDK 23.03,
which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Okay, I'll revert this patch. Please note the patch has been backported to 21.11, Do we want to fix it? @Kevin Traynor
Quoted 3 lines
Regards,
Xu, Hailin
Quoted 90 lines
-----Original Message-----
From: Xueming(Steven) Li <[email protected]>
Sent: Tuesday, August 29, 2023 4:56 PM
To: Xu, HailinX <[email protected]>; [email protected]; Kevin Traynor <[email protected]>
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: RE: 22.11.3 patches review and testQuoted 57 lines
-----Original Message-----
From: Xu, HailinX <[email protected]>
Sent: 8/29/2023 16:22
To: Xueming(Steven) Li <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; NBU- Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: RE: 22.11.3 patches review and testQuoted 6 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>;Quoted 8 lines
Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>;
Thomas
Quoted 15 lines
Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: 22.11.3 patches review and testHi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
Quoted 7 lines
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not
backported to 22.11.3.
Fix patch commit id on DPDK main:7e7b6762eac292e78c77ad37ec0973c0c944b845Hailin, thanks for the verification and feedback!
From original patch discussion, the origin decision is no backport, that's why "cc:[email protected]" get removed.Quoted 1 line
Quoted 12 lines
Quoted 5 lines
2. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode commit
9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3on v22.11.3-rc1. This commit is for the new feature (avx512 checksum offload) in DPDK
23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.Okay, I'll revert this patch. Please note the patch has been backported to 21.11, Do we want to fix it? @Kevin Traynor
Quoted 3 lines
Regards,
Xu, Hailin
Update the test status for Intel part. dpdk22.11.3-rc1 all validation tests done. Found 1 crypto bug.
# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as
Ubuntu20.04, Ubuntu22.04, Fedora38, RHEL8.7, RHEL9.2, FreeBSD13.1, SUSE15, CentOS7.9, openEuler22.03-SP1，OpenAnolis8.8 etc.
- All test done. No new dpdk issue is found.
* PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new dpdk issue is found.
* VF(i40e, ixgbe): test scenarios including VF-RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new dpdk issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- All test done. Here have an issue. Need revert this patch.
The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode.
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 on v22.11.3-rc1.
This commit is for the new feature (avx512 checksum offload) in DPDK 23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
- All test done. No new dpdk issue is found.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- All test done. No new dpdk issue is found.
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
- All test done. No new dpdk issue is found.
* Cryptodev:
*Function test: test scenarios including Cryptodev API testing/CompressDev ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
- All test done. No new dpdk issue is found.
*Performance test: test scenarios including Thoughput Performance/Cryptodev Latency, etc.
- All test done. Found new bug.
crypto: Performance drop for 1c1t scenario -> Intel dev is under investigating.
Regards,
Xu, Hailin
Quoted 161 lines
-----Original Message-----
From: Xu, HailinX <[email protected]>
Sent: 8/31/2023 9:50
To: Xueming(Steven) Li <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: RE: 22.11.3 patches review and testQuoted 6 lines
-----Original Message-----
From: Xueming(Steven) Li <[email protected]>
Sent: Tuesday, August 29, 2023 4:56 PM
To: Xu, HailinX <[email protected]>; [email protected]; Kevin Traynor <[email protected]>
Cc: [email protected]; [email protected]; Abhishek MaratheQuoted 8 lines
<[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; NBU-Contact-Thomas Monjalon
(EXTERNAL)
Quoted 1 line
<[email protected]>; Yanghang Liu <[email protected]>; Peng,
Yuan
Quoted 13 lines
<[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: RE: 22.11.3 patches review and testQuoted 8 lines
-----Original Message-----
From: Xu, HailinX <[email protected]>
Sent: 8/29/2023 16:22
To: Xueming(Steven) Li <[email protected]>; [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 11 lines
Quoted 11 lines
Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; NBU- Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: RE: 22.11.3 patches review and testQuoted 9 lines
Quoted 9 lines
Quoted 9 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 14 lines
Quoted 14 lines
Quoted 6 lines
Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>;
Thomas
Quoted 7 lines
Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: 22.11.3 patches review and testHi all,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the
release notes.
Quoted 23 lines
Quoted 10 lines
Quoted 9 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
Quoted 7 lines
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not
backported to 22.11.3.
Fix patch commit id on DPDK main:7e7b6762eac292e78c77ad37ec0973c0c944b845Hailin, thanks for the verification and feedback!
From original patch discussion, the origin decision is no backport, that's why "cc:[email protected]" get removed.Quoted 1 line
Quoted 12 lines
Quoted 5 lines
2. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode commit
9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3on v22.11.3-rc1. This commit is for the new feature (avx512 checksum offload) in
DPDK 23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.Okay, I'll revert this patch. Please note the patch has been backported to 21.11, Do we want to fix it? @Kevin Traynor
Quoted 3 lines
Regards,
Xu, HailinUpdate the test status for Intel part. dpdk22.11.3-rc1 all validation tests done. Found 1 crypto bug.
# Basic Intel(R) NIC testing
* Build & CFLAG compile: cover the build test combination with latest GCC/Clang version and the popular OS revision such as Ubuntu20.04, Ubuntu22.04, Fedora38, RHEL8.7, RHEL9.2, FreeBSD13.1,
SUSE15, CentOS7.9, openEuler22.03-SP1，OpenAnolis8.8 etc.
- All test done. No new dpdk issue is found.
*PF(i40e, ixgbe): test scenarios including RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.
- All test done. No new dpdk issue is found.
*VF(i40e, ixgbe): test scenarios including VF- RTE_FLOW/TSO/Jumboframe/checksum offload/VLAN/VXLAN, etc.- All test done. No new dpdk issue is found.
* PF/VF(ice): test scenarios including Switch features/Package Management/Flow Director/Advanced Tx/Advanced RSS/ACL/DCF/Flexible Descriptor, etc.
- All test done. Here have an issue. Need revert this patch. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode. commit9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3on v22.11.3-rc1. This commit is for the new feature (avx512 checksum offload) in DPDK
23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
* Intel NIC single core/NIC performance: test scenarios including PF/VF single core performance test, etc.
- All test done. No new dpdk issue is found.
* IPsec: test scenarios including ipsec/ipsec-gw/ipsec library basic test - QAT&SW/FIB library, etc.
- All test done. No new dpdk issue is found.
Quoted 14 lines
# Basic cryptodev and virtio testing
* Virtio: both function and performance test are covered. Such as PVP/Virtio_loopback/virtio-user loopback/virtio-net VM2VM perf testing/VMAWARE ESXI 8.0, etc.
- All test done. No new dpdk issue is found.
* Cryptodev:
*Function test: test scenarios including Cryptodev API testing/CompressDev
ISA-L/QAT/ZLIB PMD Testing/FIPS, etc.
- All test done. No new dpdk issue is found.
*Performance test: test scenarios including Thoughput
Performance/Cryptodev Latency, etc.
- All test done. Found new bug.
crypto: Performance drop for 1c1t scenario -> Intel dev is under
investigating.
Hi Hailin,
Thanks for the verification and report, I'll hold the release, please kindly let me know if any progress of the crypto bug.
BTW, I reverted "net/iavf: fix tunnel TSO path selection" and pushed to stable/ 22.11-staging, it will be included in official 22.11.3 TLS if no objection.
Quoted 3 lines
Regards,
Xu, Hailin
Quoted 38 lines · HailinX
Quoted 27 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: 22.11.3 patches review and testHi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
We are conducting DPDK testing and have found two issues.
Quoted 8 lines
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not backported to 22.11.3. Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b8452. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
commit9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3on v22.11.3-rc1.
This commit is for the new feature (avx512 checksum offload) in DPDK 23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Thanks for flagging Xueming.
The issue is that it was listed as fixing 059f18ae2aec ("net/iavf: add offload path for Tx AVX512") which goes back to 21.05.
This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until 21.11.6 in December before it will be reverted in a released version.
thanks,
Kevin.
Quoted 3 lines
Regards,
Xu, Hailin
Quoted 37 lines · Kevin Traynor
Quoted 36 lines · HailinX
Quoted 35 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: 22.11.3 patches review and testHi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
Quoted 7 lines
Quoted 7 lines
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not backported to 22.11.3. Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b8452. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
Need to clarify this sentence. It looks like it is not a functional bug where avx512 mode is selected and then an SCTP tunnel packet cannot be sent. Instead, it is a possible performance issue that avx512 mode will not be selected where it might have been due to unneeded additions (RTE_ETH_TX_OFFLOAD_*_TNL_TSO) to IAVF_TX_NO_VECTOR_FLAGS.
@IAVF maintainers - please confirm my analysis is correct ?
In that case, as it is a possible performance issue in a specific case for a single driver I think it is non-critical for 21.11 and we can just revert the patch on the branch and wait for 21.11.6 release in December.
thanks,
Kevin.
Quoted 29 lines
Quoted 3 lines
commit
9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3on v22.11.3-rc1.
This commit is for the new feature (avx512 checksum offload) in DPDK 23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.Thanks for flagging Xueming.
The issue is that it was listed as fixing
059f18ae2aec("net/iavf: add offload path for Tx AVX512") which goes back to 21.05.This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until 21.11.6 in December before it will be reverted in a released version.
thanks,
Kevin.Quoted 3 lines
Regards,
Xu, Hailin
Quoted 72 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Thursday, August 31, 2023 8:18 PM
To: Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zeng, ZhichaoX <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 9 lines · Kevin Traynor
Quoted 8 lines · HailinX
Quoted 8 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 8 lines
Quoted 8 lines
Quoted 8 lines
Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Subject: 22.11.3 patches review and test
Hi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release
notes.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Thanks.
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not backported
to 22.11.3.
Quoted 4 lines
Quoted 4 lines
Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b8452. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
Need to clarify this sentence. It looks like it is not a functional bug where avx512 mode is selected and then an SCTP tunnel packet cannot be sent. Instead, it is a possible performance issue that avx512 mode will not be selected where it might have been due to unneeded additions (RTE_ETH_TX_OFFLOAD_*_TNL_TSO) to
IAVF_TX_NO_VECTOR_FLAGS.
Quoted 5 lines
@IAVF maintainers - please confirm my analysis is correct ?
In that case, as it is a possible performance issue in a specific case for a single driver I think it is non-critical for 21.11 and we can just revert the patch on the branch and wait for 21.11.6 release in December.
Hi Kevin,
Since the LTS version of the IAVF driver does not support avx512 checksum offload, the scalar path should be selected, but this patch makes it incorrectly select the avx512 path, and the SCTP tunnel packets can't be forwarded properly.
Yes, we can revert this commit for 21.11.6 release, thanks.
Regards
Zhichao
Quoted 35 lines
thanks,
Kevin.Quoted 1 line
Quoted 1 line
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 on v22.11.3-rc1.
Quoted 1 line
Quoted 1 line
This commit is for the new feature (avx512 checksum offload) in DPDK
23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Quoted 27 lines
Quoted 1 line
Thanks for flagging Xueming.
The issue is that it was listed as fixing
059f18ae2aec("net/iavf: add offload path for Tx AVX512") which goes back to 21.05.This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until 21.11.6 in December before it will be reverted in a released version.
thanks,
Kevin.Quoted 3 lines
Regards,
Xu, Hailin
Quoted 78 lines · ZhichaoX
Quoted 72 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Thursday, August 31, 2023 8:18 PM
To: Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zeng, ZhichaoX <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 9 lines · Kevin Traynor
Quoted 8 lines · HailinX
Quoted 8 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 8 lines
Quoted 8 lines
Quoted 8 lines
Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Subject: 22.11.3 patches review and test
Hi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release
notes.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Thanks.
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not backported
to 22.11.3.
Quoted 4 lines
Quoted 4 lines
Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b8452. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
Need to clarify this sentence. It looks like it is not a functional bug where avx512 mode is selected and then an SCTP tunnel packet cannot be sent. Instead, it is a possible performance issue that avx512 mode will not be selected where it might have been due to unneeded additions (RTE_ETH_TX_OFFLOAD_*_TNL_TSO) to
IAVF_TX_NO_VECTOR_FLAGS.Quoted 5 lines
@IAVF maintainers - please confirm my analysis is correct ?
In that case, as it is a possible performance issue in a specific case for a single driver I think it is non-critical for 21.11 and we can just revert the patch on the branch and wait for 21.11.6 release in December.
Quoted 6 lines
Hi Kevin,
Since the LTS version of the IAVF driver does not support avx512 checksum offload, the scalar path should be selected, but this patch makes it incorrectly select the avx512 path, and the SCTP tunnel packets can't be forwarded properly.
ok, let's take a look at the patch and usage.
drivers/net/iavf/iavf_rxtx.h +4 -0
@@ -32,4 +32,8 @@RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \RTE_ETH_TX_OFFLOAD_TCP_TSO | \ +RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)
<snip>
So we now have:
#define IAVF_TX_NO_VECTOR_FLAGS ( \ RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ RTE_ETH_TX_OFFLOAD_TCP_TSO | \ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)
<snip>
static inline int iavf_tx_vec_queue_default(struct iavf_tx_queue *txq)
{
if (!txq)
return -1;
if (txq->rs_thresh < IAVF_VPMD_TX_MAX_BURST ||
txq->rs_thresh > IAVF_VPMD_TX_MAX_FREE_BUF)
return -1;
if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS)
return -1;
^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGS gives *more* reasons for why this statement might not be true, so returning -1 indicating that vector cannot be used for tx queue
<snip>
static inline boolcheck_tx_vec_allow(struct iavf_tx_queue *txq)
{
if (!(txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) &&
^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGS gives *more* reason for this statement will be false and then false returned indicating that vector cannot be used.
txq->rs_thresh >= IAVF_VPMD_TX_MAX_BURST &&
txq->rs_thresh <= IAVF_VPMD_TX_MAX_FREE_BUF) {
PMD_INIT_LOG(DEBUG, "Vector tx can be enabled on this txq.");
return true;
}
PMD_INIT_LOG(DEBUG, "Vector Tx cannot be enabled on this txq.");
return false;
}--
It looks like that adding the extra bits gives it less reasons to select vector mode. However, you are saying that this patch means there is a case where it now selects vector where it should not, meaning additional reason to select vector mode. So maybe I miss something ?
Quoted 41 lines
Yes, we can revert this commit for 21.11.6 release, thanks.
Regards
ZhichaoQuoted 35 lines
thanks,
Kevin.Quoted 1 line
Quoted 1 line
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 on v22.11.3-rc1.
Quoted 1 line
Quoted 1 line
This commit is for the new feature (avx512 checksum offload) in DPDK
23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Quoted 27 lines
Quoted 1 line
Thanks for flagging Xueming.
The issue is that it was listed as fixing
059f18ae2aec("net/iavf: add offload path for Tx AVX512") which goes back to 21.05.This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until 21.11.6 in December before it will be reverted in a released version.
thanks,
Kevin.Quoted 3 lines
Regards,
Xu, Hailin
Quoted 130 lines · Kevin Traynor
Quoted 78 lines · ZhichaoX
Quoted 72 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Thursday, August 31, 2023 8:18 PM
To: Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zeng, ZhichaoX <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 9 lines · Kevin Traynor
Quoted 8 lines · HailinX
Quoted 8 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 8 lines
Quoted 8 lines
Quoted 8 lines
Stokes, Ian <[email protected]>; Jerin Jacob <[email protected]>; Mcnamara, John <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Subject: 22.11.3 patches review and test
Hi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release
notes.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Quoted 6 lines
Quoted 6 lines
Quoted 1 line
Thanks.
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has not backported
to 22.11.3.
Quoted 4 lines
Quoted 4 lines
Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b8452. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
Need to clarify this sentence. It looks like it is not a functional bug where avx512 mode is selected and then an SCTP tunnel packet cannot be sent. Instead, it is a possible performance issue that avx512 mode will not be selected where it might have been due to unneeded additions (RTE_ETH_TX_OFFLOAD_*_TNL_TSO) to
IAVF_TX_NO_VECTOR_FLAGS.Quoted 5 lines
@IAVF maintainers - please confirm my analysis is correct ?
In that case, as it is a possible performance issue in a specific case for a single driver I think it is non-critical for 21.11 and we can just revert the patch on the branch and wait for 21.11.6 release in December.
Quoted 6 lines
Hi Kevin,
Since the LTS version of the IAVF driver does not support avx512 checksum offload, the scalar path should be selected, but this patch makes it incorrectly select the avx512 path, and the SCTP tunnel packets can't be forwarded properly.
ok, let's take a look at the patch and usage.
drivers/net/iavf/iavf_rxtx.h +4
-0@@ -32,4 +32,8 @@RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \RTE_ETH_TX_OFFLOAD_TCP_TSO | \ +RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)So we now have:
#define IAVF_TX_NO_VECTOR_FLAGS ( \ RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ RTE_ETH_TX_OFFLOAD_TCP_TSO | \ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)<snip>
static inline int
iavf_tx_vec_queue_default(struct iavf_tx_queue *txq){ if (!txq) return -1; if (txq->rs_thresh < IAVF_VPMD_TX_MAX_BURST || txq->rs_thresh > IAVF_VPMD_TX_MAX_FREE_BUF) return -1; if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) return -1; ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGS gives
Quoted 3 lines
*more* reasons for why this statement might not be true, so returning -1 indicating that vector cannot be used for tx queue
typo here - just to clarify, the new flags give more reasons for this statement to be true, so returning -1.
Quoted 70 lines
<snip>
static inline bool
check_tx_vec_allow(struct iavf_tx_queue *txq){ if (!(txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) && ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGS gives*more* reason for this statement will be false and then false returned indicating that vector cannot be used.
txq->rs_thresh >= IAVF_VPMD_TX_MAX_BURST && txq->rs_thresh <= IAVF_VPMD_TX_MAX_FREE_BUF) { PMD_INIT_LOG(DEBUG, "Vector tx can be enabled on this txq."); return true; } PMD_INIT_LOG(DEBUG, "Vector Tx cannot be enabled on this txq."); return false; }--
It looks like that adding the extra bits gives it less reasons to select vector mode. However, you are saying that this patch means there is a case where it now selects vector where it should not, meaning additional reason to select vector mode. So maybe I miss something ?
Quoted 41 lines
Yes, we can revert this commit for 21.11.6 release, thanks.
Regards
ZhichaoQuoted 35 lines
thanks,
Kevin.Quoted 1 line
Quoted 1 line
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 on v22.11.3-rc1.
Quoted 1 line
Quoted 1 line
This commit is for the new feature (avx512 checksum offload) in DPDK
23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Quoted 27 lines
Quoted 1 line
Thanks for flagging Xueming.
The issue is that it was listed as fixing
059f18ae2aec("net/iavf: add offload path for Tx AVX512") which goes back to 21.05.This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until 21.11.6 in December before it will be reverted in a released version.
thanks,
Kevin.Quoted 3 lines
Regards,
Xu, Hailin
Regards
Zhichao
Quoted 141 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Monday, September 4, 2023 10:15 PM
To: Zeng, ZhichaoX <[email protected]>; Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 27 lines · Kevin Traynor
Quoted 26 lines · ZhichaoX
Quoted 26 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Thursday, August 31, 2023 8:18 PM
To: Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zeng, ZhichaoX <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 10 lines · Kevin Traynor
Quoted 9 lines · HailinX
Quoted 9 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Stokes, Ian <[email protected]>; Jerin Jacob
<[email protected]>; Mcnamara, JohnQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>;
Peng,
Quoted 44 lines
Quoted 44 lines
Quoted 44 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Yuan <[email protected]>; Chen, Zhaoyan
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Subject: 22.11.3 patches review and test
Hi all,
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release
notes.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Thanks.
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has
not backportedto 22.11.3.
Quoted 5 lines
Quoted 5 lines
Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b8452. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
Need to clarify this sentence. It looks like it is not a functional bug where
avx512 mode is selected and then an SCTP tunnel packet cannot be sent. Instead, it is a possible performance issue that avx512 mode will not be selected where it might have been due to unneeded additions (RTE_ETH_TX_OFFLOAD_*_TNL_TSO) toIAVF_TX_NO_VECTOR_FLAGS.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
@IAVF maintainers - please confirm my analysis is correct ?
In that case, as it is a possible performance issue in a specific case for a single driver I think it is non-critical for 21.11 and we can just revert the patch on the branch and wait for 21.11.6 release in
December.
Quoted 38 lines
Quoted 8 lines
Hi Kevin,
Since the LTS version of the IAVF driver does not support avx512 checksum offload, the scalar path should be selected, but this patch makes it incorrectly select the
avx512 path, and the SCTP tunnel packets can't be forwarded properly.ok, let's take a look at the patch and usage.
(quoted diff) +0
-0
b/drivers/net/iavf/iavf_rxtx.hindex8d4a77271a..605ea3f824100644drivers/net/iavf/iavf_rxtx.h +4
-0@@ -32,4 +32,8 @@RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \RTE_ETH_TX_OFFLOAD_TCP_TSO | \ +RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)So we now have:
#define IAVF_TX_NO_VECTOR_FLAGS ( \ RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ RTE_ETH_TX_OFFLOAD_TCP_TSO | \ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)
Quoted 2 lines
Quoted 2 lines
<snip>
Hi Kevin,
This patch also removes two flags from IAVF_TX_NO_VECTOR_FLAGS, RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM and RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.
Quoted 42 lines
Quoted 12 lines
static inline int
iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) { if (!txq) return -1; if (txq->rs_thresh < IAVF_VPMD_TX_MAX_BURST || txq->rs_thresh > IAVF_VPMD_TX_MAX_FREE_BUF) return -1; if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) return -1; ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGSQuoted 4 lines
gives
*more* reasons for why this statement might not be true, so returning -1 indicating that vector cannot be used for tx queuetypo here - just to clarify, the new flags give more reasons for this statement to be true, so returning -1.
Quoted 8 lines
<snip>
static inline bool
check_tx_vec_allow(struct iavf_tx_queue *txq) { if (!(txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) && ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGSQuoted 7 lines
gives
*more* reason for this statement will be false and then false returned indicating that vector cannot be used.txq->rs_thresh >= IAVF_VPMD_TX_MAX_BURST && txq->rs_thresh <= IAVF_VPMD_TX_MAX_FREE_BUF) { PMD_INIT_LOG(DEBUG, "Vector tx can be enabled on thistxq.");
Quoted 6 lines
return true; } PMD_INIT_LOG(DEBUG, "Vector Tx cannot be enabled on this txq."); return false; }
Quoted 7 lines
Quoted 6 lines
--
It looks like that adding the extra bits gives it less reasons to select vector mode. However, you are saying that this patch means there is a case where it now selects vector where it should not, meaning additional reason to select vector mode. So maybe I miss
something ?
Originally, the vector path would not be selected after configuring outer checksum offload, but it will be selected after removing the two flags.
But the vector path doesn't support outer checksum offload on stable DPDK, so there will be a problem.
The key issue is that these two flags are removed, RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM and RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.
Regards
Zhichao
Quoted 45 lines
Quoted 10 lines
Quoted 10 lines
Yes, we can revert this commit for 21.11.6 release, thanks.
Regards
ZhichaoQuoted 4 lines
thanks,
Kevin.Quoted 1 line
Quoted 1 line
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 onv22.11.3-
Quoted 34 lines
Quoted 33 lines
Quoted 32 lines
rc1.
Quoted 2 lines
Quoted 2 lines
This commit is for the new feature (avx512 checksum offload)
in DPDK23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Quoted 27 lines
Quoted 1 line
Thanks for flagging Xueming.
The issue is that it was listed as fixing
059f18ae2aec("net/iavf:
add offload path for Tx AVX512") which goes back to 21.05.This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until 21.11.6 in December before it will be reverted in a released version.
thanks,
Kevin.Quoted 3 lines
Regards,
Xu, Hailin
Quoted 201 lines · ZhichaoX
Regards
ZhichaoQuoted 141 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Monday, September 4, 2023 10:15 PM
To: Zeng, ZhichaoX <[email protected]>; Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 27 lines · Kevin Traynor
Quoted 26 lines · ZhichaoX
Quoted 26 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Thursday, August 31, 2023 8:18 PM
To: Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zeng, ZhichaoX <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 10 lines · Kevin Traynor
Quoted 9 lines · HailinX
Quoted 9 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Stokes, Ian <[email protected]>; Jerin Jacob
<[email protected]>; Mcnamara, JohnQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>;
Peng,
Quoted 44 lines
Quoted 44 lines
Quoted 44 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Yuan <[email protected]>; Chen, Zhaoyan
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Subject: 22.11.3 patches review and test
Hi all,
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release
notes.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Thanks.
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has
not backportedto 22.11.3.
Quoted 5 lines
Quoted 5 lines
Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b8452. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
Need to clarify this sentence. It looks like it is not a functional bug where
avx512 mode is selected and then an SCTP tunnel packet cannot be sent. Instead, it is a possible performance issue that avx512 mode will not be selected where it might have been due to unneeded additions (RTE_ETH_TX_OFFLOAD_*_TNL_TSO) toIAVF_TX_NO_VECTOR_FLAGS.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
@IAVF maintainers - please confirm my analysis is correct ?
In that case, as it is a possible performance issue in a specific case for a single driver I think it is non-critical for 21.11 and we can just revert the patch on the branch and wait for 21.11.6 release in
December.
Quoted 38 lines
Quoted 8 lines
Hi Kevin,
Since the LTS version of the IAVF driver does not support avx512 checksum offload, the scalar path should be selected, but this patch makes it incorrectly select the
avx512 path, and the SCTP tunnel packets can't be forwarded properly.ok, let's take a look at the patch and usage.
(quoted diff) +0
-0
b/drivers/net/iavf/iavf_rxtx.hindex8d4a77271a..605ea3f824100644drivers/net/iavf/iavf_rxtx.h +4
-0@@ -32,4 +32,8 @@RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \RTE_ETH_TX_OFFLOAD_TCP_TSO | \ +RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)So we now have:
#define IAVF_TX_NO_VECTOR_FLAGS ( \ RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ RTE_ETH_TX_OFFLOAD_TCP_TSO | \ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)Quoted 2 lines
Quoted 2 lines
<snip>
Hi Kevin,
This patch also removes two flags from
IAVF_TX_NO_VECTOR_FLAGS,RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUMandRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.Quoted 48 lines
Quoted 12 lines
static inline int
iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) { if (!txq) return -1; if (txq->rs_thresh < IAVF_VPMD_TX_MAX_BURST || txq->rs_thresh > IAVF_VPMD_TX_MAX_FREE_BUF) return -1; if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) return -1; ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGSQuoted 4 lines
gives
*more* reasons for why this statement might not be true, so returning -1 indicating that vector cannot be used for tx queuetypo here - just to clarify, the new flags give more reasons for this statement to be true, so returning -1.
Quoted 8 lines
<snip>
static inline bool
check_tx_vec_allow(struct iavf_tx_queue *txq) { if (!(txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) && ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGSQuoted 7 lines
gives
*more* reason for this statement will be false and then false returned indicating that vector cannot be used.txq->rs_thresh >= IAVF_VPMD_TX_MAX_BURST && txq->rs_thresh <= IAVF_VPMD_TX_MAX_FREE_BUF) { PMD_INIT_LOG(DEBUG, "Vector tx can be enabled on thistxq.");
Quoted 12 lines
return true; } PMD_INIT_LOG(DEBUG, "Vector Tx cannot be enabled on this txq."); return false; }--
It looks like that adding the extra bits gives it less reasons to select vector mode. However, you are saying that this patch means there is a case where it now selects vector where it should not, meaning additional reason to select vector mode. So maybe I miss
Quoted 9 lines
Quoted 1 line
something ?
Originally, the vector path would not be selected after configuring outer checksum offload, but it will be selected after removing the two flags.
But the vector path doesn't support outer checksum offload on stable DPDK, so there will be a problem.The key issue is that these two flags are removed,
RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUMandRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.
ok, i got it now. In the main branch (ca34627be5d6) and the 21.11 backport (3eb4ad8ed694) those flags are not removed. Those flags are only removed in the 22.11 branch (9b7215f150d0).
So this is not an issue for 21.11. Thanks for helping clear it up.
Kevin.
Quoted 49 lines
Regards
ZhichaoQuoted 45 lines
Quoted 10 lines
Quoted 10 lines
Yes, we can revert this commit for 21.11.6 release, thanks.
Regards
ZhichaoQuoted 4 lines
thanks,
Kevin.Quoted 1 line
Quoted 1 line
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 onv22.11.3-
Quoted 34 lines
Quoted 33 lines
Quoted 32 lines
rc1.
Quoted 2 lines
Quoted 2 lines
This commit is for the new feature (avx512 checksum offload)
in DPDK23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Quoted 27 lines
Quoted 1 line
Thanks for flagging Xueming.
The issue is that it was listed as fixing
059f18ae2aec("net/iavf:
add offload path for Tx AVX512") which goes back to 21.05.This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until 21.11.6 in December before it will be reverted in a released version.
thanks,
Kevin.Quoted 3 lines
Regards,
Xu, Hailin
Quoted 241 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: 9/5/2023 16:50
To: Zeng, ZhichaoX <[email protected]>; Xu, HailinX <[email protected]>; Xueming(Steven) Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; NBU-Contact- Thomas Monjalon (EXTERNAL) <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>; Yang, Qiming <[email protected]>; Zhou, YidingX <[email protected]>; Cui, KaixinX <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 31 lines · ZhichaoX
Regards
ZhichaoQuoted 27 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Monday, September 4, 2023 10:15 PM
To: Zeng, ZhichaoX <[email protected]>; Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 11 lines · Kevin Traynor
Quoted 10 lines · ZhichaoX
Quoted 10 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Thursday, August 31, 2023 8:18 PM
To: Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zeng, ZhichaoX <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, JohnQuoted 48 lines
Quoted 48 lines
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 10 lines · Kevin Traynor
Quoted 9 lines · HailinX
Quoted 9 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Stokes, Ian <[email protected]>; Jerin Jacob
<[email protected]>; Mcnamara, JohnQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>;
Peng,
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Yuan <[email protected]>; Chen, Zhaoyan
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Subject: 22.11.3 patches review and test
Hi all,
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release
notes.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
A release candidate tarball can be found at:
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 4 lines
These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of
SUSE
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
This issue fix patch has been merged into main, But it
has not backportedto 22.11.3.
Quoted 3 lines
Quoted 3 lines
Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b845Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
2. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
Need to clarify this sentence. It looks like it is not a functional bug where
avx512 mode is selected and then an SCTP tunnel packet cannot besent.
Quoted 107 lines
Quoted 49 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Instead, it is a possible performance issue that avx512 mode will not be selected where it might have been due to unneeded additions (RTE_ETH_TX_OFFLOAD_*_TNL_TSO) to
IAVF_TX_NO_VECTOR_FLAGS.@IAVF maintainers - please confirm my analysis is correct ?
In that case, as it is a possible performance issue in a specific case for a single driver I think it is non-critical for 21.11 and we can just revert the patch on the branch and wait for 21.11.6 release in
December.
Quoted 38 lines
Quoted 8 lines
Hi Kevin,
Since the LTS version of the IAVF driver does not support avx512 checksum offload, the scalar path should be selected, but this patch makes it incorrectly select the
avx512 path, and the SCTP tunnel packets can't be forwarded properly.ok, let's take a look at the patch and usage.
(quoted diff) +0
-0
b/drivers/net/iavf/iavf_rxtx.hindex8d4a77271a..605ea3f824100644drivers/net/iavf/iavf_rxtx.h +4
-0@@ -32,4 +32,8 @@RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \RTE_ETH_TX_OFFLOAD_TCP_TSO | \ +RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)So we now have:
#define IAVF_TX_NO_VECTOR_FLAGS ( \ RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ RTE_ETH_TX_OFFLOAD_TCP_TSO | \ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)Quoted 2 lines
Quoted 2 lines
<snip>
Hi Kevin,
This patch also removes two flags from
IAVF_TX_NO_VECTOR_FLAGS,RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM
andRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.Quoted 49 lines
Quoted 12 lines
static inline int
iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) { if (!txq) return -1; if (txq->rs_thresh < IAVF_VPMD_TX_MAX_BURST || txq->rs_thresh > IAVF_VPMD_TX_MAX_FREE_BUF) return -1; if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) return -1; ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGSQuoted 5 lines
gives
*more* reasons for why this statement might not be true, so returning
-1 indicating that vector cannot be used for tx queuetypo here - just to clarify, the new flags give more reasons for this statement to be true, so returning -1.
Quoted 8 lines
<snip>
static inline bool
check_tx_vec_allow(struct iavf_tx_queue *txq) { if (!(txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) && ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGSQuoted 7 lines
gives
*more* reason for this statement will be false and then false returned indicating that vector cannot be used.txq->rs_thresh >= IAVF_VPMD_TX_MAX_BURST && txq->rs_thresh <= IAVF_VPMD_TX_MAX_FREE_BUF) { PMD_INIT_LOG(DEBUG, "Vector tx can be enabled on thistxq.");
Quoted 12 lines
return true; } PMD_INIT_LOG(DEBUG, "Vector Tx cannot be enabled on this txq."); return false; }--
It looks like that adding the extra bits gives it less reasons to select vector mode. However, you are saying that this patch means there is a case where it now selects vector where it should not, meaning additional reason to select vector mode. So maybe I miss
Quoted 5 lines
Quoted 1 line
something ?
Originally, the vector path would not be selected after configuring outer checksum offload, but it will be selected after removing the two flags. But the vector path doesn't support outer checksum offload on stable DPDK,
so there will be a problem.
Quoted 5 lines
The key issue is that these two flags are removed,
RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM
andRTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.
Quoted 5 lines
ok, i got it now. In the main branch (
ca34627be5d6) and the 21.11 backport (3eb4ad8ed694) those flags are not removed. Those flags are only removed in the 22.11 branch (9b7215f150d0).So this is not an issue for 21.11. Thanks for helping clear it up.
Hi Guys, thanks for the clarification, the patch has been reverted in 22.11 candidate branch.
Thanks,
Xueming
Quoted 53 lines
Kevin.
Quoted 50 lines
Regards
ZhichaoQuoted 46 lines
Quoted 10 lines
Quoted 10 lines
Yes, we can revert this commit for 21.11.6 release, thanks.
Regards
ZhichaoQuoted 4 lines
thanks,
Kevin.Quoted 1 line
Quoted 1 line
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 onv22.11.3-
Quoted 35 lines
Quoted 34 lines
Quoted 33 lines
rc1.
Quoted 2 lines
Quoted 2 lines
This commit is for the new feature (avx512 checksum
offload) in DPDK23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Quoted 28 lines
Quoted 1 line
Thanks for flagging Xueming.
The issue is that it was listed as fixing
059f18ae2aec("net/iavf:
add offload path for Tx AVX512") which goes back to 21.05.This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until
21.11.6 in December before it will be reverted in a released version.thanks,
Kevin.Quoted 3 lines
Regards,
Xu, Hailin
Quoted 141 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Monday, September 4, 2023 10:15 PM
To: Zeng, ZhichaoX <[email protected]>; Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 27 lines · Kevin Traynor
Quoted 26 lines · ZhichaoX
Quoted 26 lines
-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Thursday, August 31, 2023 8:18 PM
To: Xu, HailinX <[email protected]>; Xueming Li <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Xing, Beilei <[email protected]>; Xu, Ke1 <[email protected]>; Zeng, ZhichaoX <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: [email protected]; [email protected]; Stokes, Ian <[email protected]>; Mcnamara, John <[email protected]>; Luca Boccassi <[email protected]>; Xu, Qian Q <[email protected]>; Thomas Monjalon <[email protected]>; Peng, Yuan <[email protected]>; Chen, Zhaoyan <[email protected]>
Subject: Re: 22.11.3 patches review and testQuoted 10 lines · Kevin Traynor
Quoted 9 lines · HailinX
Quoted 9 lines
-----Original Message-----
From: Xueming Li <[email protected]>
Sent: Thursday, August 17, 2023 2:14 PM
To: [email protected]
Cc: [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; Walker, Benjamin <[email protected]>; David Christensen <[email protected]>; Hemant AgrawalQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Stokes, Ian <[email protected]>; Jerin Jacob
<[email protected]>; Mcnamara, JohnQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; Xu, Qian Q <[email protected]>; Raslan Darawsheh <[email protected]>; Thomas Monjalon <[email protected]>; Yanghang Liu <[email protected]>;
Peng,
Quoted 44 lines
Quoted 44 lines
Quoted 44 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Yuan <[email protected]>; Chen, Zhaoyan
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Subject: 22.11.3 patches review and test
Hi all,
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release
notes.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Quoted 7 lines
Quoted 7 lines
Quoted 1 line
Thanks.
We are conducting DPDK testing and have found two issues.
1. The startup speed of testpmd is significantly slower in the os of SUSE This issue fix patch has been merged into main, But it has
not backportedto 22.11.3.
Quoted 5 lines
Quoted 5 lines
Fix patch commit id on DPDK main:
7e7b6762eac292e78c77ad37ec0973c0c944b8452. The SCTP tunnel packet of iavf cannot be forwarded in avx512 mode
Need to clarify this sentence. It looks like it is not a functional bug where
avx512 mode is selected and then an SCTP tunnel packet cannot be sent. Instead, it is a possible performance issue that avx512 mode will not be selected where it might have been due to unneeded additions (RTE_ETH_TX_OFFLOAD_*_TNL_TSO) toIAVF_TX_NO_VECTOR_FLAGS.Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
@IAVF maintainers - please confirm my analysis is correct ?
In that case, as it is a possible performance issue in a specific case for a single driver I think it is non-critical for 21.11 and we can just revert the patch on the branch and wait for 21.11.6 release in
December.
Quoted 38 lines
Quoted 8 lines
Hi Kevin,
Since the LTS version of the IAVF driver does not support avx512 checksum offload, the scalar path should be selected, but this patch makes it incorrectly select the
avx512 path, and the SCTP tunnel packets can't be forwarded properly.ok, let's take a look at the patch and usage.
(quoted diff) +0
-0
b/drivers/net/iavf/iavf_rxtx.hindex8d4a77271a..605ea3f824100644drivers/net/iavf/iavf_rxtx.h +4
-0@@ -32,4 +32,8 @@RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \RTE_ETH_TX_OFFLOAD_TCP_TSO | \ +RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ +RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)So we now have:
#define IAVF_TX_NO_VECTOR_FLAGS ( \ RTE_ETH_TX_OFFLOAD_VLAN_INSERT | \ RTE_ETH_TX_OFFLOAD_QINQ_INSERT | \ RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \ RTE_ETH_TX_OFFLOAD_TCP_TSO | \ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \ RTE_ETH_TX_OFFLOAD_SECURITY)
Quoted 2 lines
Quoted 2 lines
<snip>
Hi Kevin,
This patch also removes two flags from IAVF_TX_NO_VECTOR_FLAGS, RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM and RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.
Quoted 42 lines
Quoted 12 lines
static inline int
iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) { if (!txq) return -1; if (txq->rs_thresh < IAVF_VPMD_TX_MAX_BURST || txq->rs_thresh > IAVF_VPMD_TX_MAX_FREE_BUF) return -1; if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) return -1; ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGSQuoted 4 lines
gives
*more* reasons for why this statement might not be true, so returning -1 indicating that vector cannot be used for tx queuetypo here - just to clarify, the new flags give more reasons for this statement to be true, so returning -1.
Quoted 8 lines
<snip>
static inline bool
check_tx_vec_allow(struct iavf_tx_queue *txq) { if (!(txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) && ^^^ Adding the extra bits to IAVF_TX_NO_VECTOR_FLAGSQuoted 7 lines
gives
*more* reason for this statement will be false and then false returned indicating that vector cannot be used.txq->rs_thresh >= IAVF_VPMD_TX_MAX_BURST && txq->rs_thresh <= IAVF_VPMD_TX_MAX_FREE_BUF) { PMD_INIT_LOG(DEBUG, "Vector tx can be enabled on thistxq.");
Quoted 6 lines
return true; } PMD_INIT_LOG(DEBUG, "Vector Tx cannot be enabled on this txq."); return false; }
Quoted 7 lines
Quoted 6 lines
--
It looks like that adding the extra bits gives it less reasons to select vector mode. However, you are saying that this patch means there is a case where it now selects vector where it should not, meaning additional reason to select vector mode. So maybe I miss
something ?
Originally, the vector path would not be selected after configuring outer checksum offload, but it will be selected after removing the two flags.
But the vector path doesn't support outer checksum offload on stable DPDK, so there will be a problem.
The key issue is that these two flags are removed, RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM and RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM.
Regards
Zhichao
Quoted 45 lines
Quoted 10 lines
Quoted 10 lines
Yes, we can revert this commit for 21.11.6 release, thanks.
Regards
ZhichaoQuoted 4 lines
thanks,
Kevin.Quoted 1 line
Quoted 1 line
commit 9b7215f150d0bfc5cb00fce68ff08e5217c7f2b3 onv22.11.3-
Quoted 34 lines
Quoted 33 lines
Quoted 32 lines
rc1.
Quoted 2 lines
Quoted 2 lines
This commit is for the new feature (avx512 checksum offload)
in DPDK23.03, which should not be backported to the LTS version since avx512 checksum offload is not supported in v22.11.3 LTS.
Quoted 27 lines
Quoted 1 line
Thanks for flagging Xueming.
The issue is that it was listed as fixing
059f18ae2aec("net/iavf:
add offload path for Tx AVX512") which goes back to 21.05.This could have been avoided if the 'Fixes:' tag was correct, or if the authors replied to the email about queued backports :/
Requesting iavf/next-net-intel maintainers to check Fixes: tags are correct before merging.
DPDK 21.11.5 is already released with this patch. Any idea why it did not show up in validation for 21.11.5 ? Is it an issue for 21.11.5 ? How critical is it ?
I can revert it on the 21.11 branch, but it will need to wait until 21.11.6 in December before it will be reverted in a released version.
thanks,
Kevin.Quoted 3 lines
Regards,
Xu, Hailin
Hi, Xueming
RedHat QE did not find any new issues about 22.11.3 rc1 dpdk during the tests.
I tested below 18 scenarios and all got PASS on RHEL9:
- Guest with device assignment(PF) throughput testing(1G hugepage size):
PASS
- Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS
- Guest with device assignment(VF) throughput testing: PASS
- PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
- PVP vhost-user 2Q throughput testing: PASS
- PVP vhost-user 1Q - cross numa node throughput testing: PASS
- Guest with vhost-user 2 queues throughput testing: PASS
- vhost-user reconnect with dpdk-client, qemu-server qemu reconnect: PASS
- vhost-user reconnect with dpdk-client, qemu-server ovs reconnect: PASS
- PVP reconnect with dpdk-client, qemu-server: PASS
- PVP 1Q live migration testing: PASS
- PVP 1Q cross numa node live migration testing: PASS
- Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
- Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
- Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
- Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
- Host PF + DPDK testing: PASS
- Host VF + DPDK testing: PASS
Test Versions:
- qemu-kvm-6.2.0 + qemu-kvm-7.2.0
- kernel 5.14
- git log
commit 5e87ad0cf8f2f90b18558913f3c71e7552aa0af5
Author: Xueming Li <[email protected]>
Date: Thu Aug 17 14:04:17 2023 +0800
version: 22.11.3-rc1
Signed-off-by: Xueming Li <[email protected]> - Test device : X540-AT2 NIC(ixgbe, 10G)
Best Regards,
YangHang Liu
Quoted 469 lines · Xueming Li
Hi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/Thanks.
Xueming Li <[email protected]>
---
Aakash Sasidharan (1):
test/crypto: fix PDCP-SDAP test vectorsAkhil Goyal (1):
doc: fix auth algos in cryptoperf appAlexander Kozyrev (4):
net/mlx5: forbid MPRQ restart net/mlx5: fix MPRQ stride size for headroom net/mlx5: fix handle validation for meter mark app/testpmd: fix meter mark handle updateAli Alnubani (2):
doc: fix typos and wording in flow API guide
doc: improve wording of cuda guideAlvaro Karsz (1):
dma/dpaa2: set VFA bit for route-by-port with VFAnoob Joseph (1):
cryptodev: clarify error codes for symmetric sessionArtemii Morozov (1):
common/sfc_efx/base: fix Rx queue without RSS hash prefixAshwin Sekhar T K (2):
mempool/cnxk: avoid hang when counting batch allocs
doc: fix typo in graph guideBing Zhao (12):
app/testpmd: fix flow rule number parsing net/mlx5: fix error set in Tx representor tagging net/mlx5: fix return value of vport action net/mlx5: fix error set in control tables create net/mlx5: fix error set for age pool initialization net/mlx5: fix error in VLAN actions creation common/mlx5: fix obtaining IB device in LAG mode net/mlx5: fix profile check of meter mark net/mlx5: reduce counter pool name length net/mlx5: fix drop action memory leak net/mlx5: fix validation for conntrack indirect action
doc: add flow template API requirements for mlx5Boleslav Stankevich (2):
net/virtio: propagate interrupt configuration error values net/virtio: fix initialization to return negative errnoBruce Richardson (4):
kernel/freebsd: fix function parameter list
telemetry: fix autotest on Alpine
eal: avoid calling cleanup twice test/bonding: fix include of standard headerChaoyong He (14):
net/nfp: fix VLAN push flow action
net/nfp: fix IPv6 flow item
net/nfp: fix TOS of IPv6 VXLAN encap flow action net/nfp: fix TOS of IPv6 GENEVE encap flow action net/nfp: fix TOS of IPv6 NVGRE encap flow action net/nfp: fix TP flow action for UDP
net/nfp: fix IPv6 address for set flow action net/nfp: fix unneeded endian conversion net/nfp: fix endian conversion for tunnel decap action net/nfp: fix VNI of VXLAN encap action net/nfp: fix VNI of IPv4 NVGRE encap action net/nfp: fix VNI of IPv6 NVGRE encap action net/nfp: fix Tx descriptor free logic of NFD3 net/nfp: fix offloading flowsChengwen Feng (4):
net/hns3: fix Rx multiple firmware reset interrupts net/hns3: fix mbuf leakage when RxQ started during reset net/hns3: fix mbuf leakage when RxQ started after reset net/hns3: fix device start return valueCiara Power (6):
crypto/qat: fix stack buffer overflow in SGL loopcrypto/scheduler: fix last element for valid argscrypto/ipsec_mb: optimize allocation in sessioncrypto/qat: fix null algorithm digest placement
cryptodev: fix device socket ID type app/crypto-perf: fix socket ID default valueDariusz Sosnowski (1):
net/mlx5: fix drop action attribute validationDavid Christensen (1):
net/tap: set locally administered bit for fixed MAC addressDavid Marchand (9):
ci: fix build for Arm cross compilation in GHAnet/virtio-user: fix leak when initialisation fails net/mlx5: enhance error log for tunnel offloading examples/l2fwd-cat: fix external build examples/fips_validation: fix external build
test: add graph tests
mbuf: fix Doxygen comment of distributor metadata
ci: fix libabigail cache in GHA
doc: fix link to flow capabilities from bnxt guideDengdui Huang (3):
net/hns3: fix variable type mismatch
net/hns3: fix inaccurate log
net/hns3: fix redundant line break in logDenis Pryazhennikov (3):
ethdev: update documentation for API to set FEC
ethdev: check that at least one FEC mode is specified
ethdev: update documentation for API to get FECDevendra Singh Rawat (1):
net/qede: fix RSS indirection table initializationDidier Pallard (2):
crypto/openssl: fix memory leak in auth processingcrypto/openssl: skip workaround at compilation timeDmitry Kozlyuk (1):
member: fix PRNG seed reset in NitroSketch modeDongdong Liu (3):
doc: fix kernel patch link in hns3 guide
doc: fix syntax in hns3 guide
doc: fix number of leading spaces in hns3 guideElena Agostini (1):
net: fix return type of IPv4 L4 packet checksumErez Ferber (1):
common/mlx5: adjust fork call with new kernel APIErik Gabriel Carrillo (1):
eventdev/timer: fix buffer flushFeifei Wang (1):
ring: fix dequeue parameter nameFengnan Chang (2):
eal/linux: fix legacy mem init with many segments
mem: fix memsegs exhausted messageFerruh Yigit (3):
kni: fix build with Linux 6.3
app/testpmd: revert primary process polling all queues fix
kni: fix build with Linux 6.5Gregory Etelson (1):
net/mlx5: fix flow workspace destructionHeng Jiang (1):
net/mlx5: fix LRO TCP checksumHernan Vargas (2):
baseband/fpga_5gnr_fec: fix possible division by zero baseband/fpga_5gnr_fec: fix starting unconfigured queueHuisong Li (10):
ethdev: fix MAC address occupies two entries net/hns3: fix never set MAC flow control net/hns3: fix RTC time on initialization net/hns3: fix RTC time after reset net/hns3: uninitialize PTP
net/hns3: extract PTP to its own header file net/hns3: fix IMP reset trigger net/hns3: delete duplicate macro definition net/hns3: fix non-zero weight for disabled TC net/hns3: fix index to look up table in NEON RxIvan Malov (2):
net/sfc: stop misuse of Rx ingress m-port metadata on EF100 net/sfc: invalidate dangling MAE flow action FW resource IDsJerin Jacob (4):
examples/ip_pipeline: fix build with GCC 13
examples/ntb: fix build with GCC 13
net/hns3: fix build warning
doc: remove warning with Doxygen 1.9.7Jiawen Wu (11):
net/txgbe/base: fix Tx with fiber hotplug
net/txgbe: fix interrupt enable mask
net/txgbe: adapt to MNG veto bit setting
net/txgbe: fix to set autoneg for 1G speed
net/txgbe: fix extended statistics
net/ngbe: fix extended statistics
net/ngbe: adapt to MNG veto bit setting
net/ngbe: fix link status in no LSC mode
net/ngbe: remove redundant codes
net/txgbe: fix blocking system events
net/ngbe: fix RSS offload capabilityJie Hai (6):
net/hns3: fix FEC mode for 200G ports net/hns3: fix FEC mode check
net/hns3: fix missing FEC capability net/hns3: fix uninitialized variable
ethdev: fix calloc arguments
app/testpmd: fix primary process not polling all queuesJieqiang Wang (1):
net/i40e: fix commentsJunfeng Guo (4):
net/ice: fix protocol agnostic offloading with big packets net/iavf: fix protocol agnostic offloading with big packets raw/ntb: avoid disabling interrupt twice
doc: update BIOS settings and supported HW for NTBKai Ji (1):
examples/ipsec-secgw: fix socket ID default valueKaijun Zeng (1):
net/vmxnet3: fix return code in initializingKaiwen Deng (3):
net/ice: fix DCF RSS initialization net/iavf: fix virtchnl command called in interrupt net/ice: fix MAC type of E822 and E823Kaiyu Zhang (1):
ethdev: fix potential leak in PCI probing helperKamalakannan R (1):
pipeline: fix double free for table statsKe Xu (1):
net/iavf: fix tunnel TSO path selectionLeyi Rong (1):
eal/x86: improve multiple of 64 bytes memcpy performanceLong Li (7):
net/mana: use datapath logging
net/mana: avoid unnecessary assignments in data path net/mana: optimize completion queue by batch processing net/mana: return probing failure if no device found net/mana: fix counter overflow for posted WQE net/mana: fix WQE count for ringing RQ doorbell net/mana: fix Tx queue statisticsLong Wu (5):
net/nfp: fix control mempool creation net/nfp: fix representor creation net/nfp: fix flow hash table creation net/bonding: fix destroy dedicated queues flow net/nfp: fix representor name too longMaayan Kashani (1):
net/mlx5: fix RSS expansion inner buffer overflowMattias Rönnblom (1):
event/dsw: free rings on closeMaxime Coquelin (3):
vhost: fix notification stats for packed ring
vhost: fix invalid call FD handlingcrypto/qat: fix sym device prototypeMichael Baum (1):
doc: fix format in flow API guideMichal Schmidt (1):
net/iavf: fix VLAN offload with AVX512Min Zhou (1):
net/ixgbe: add proper memory barriers in RxMingjin Ye (3):
net/ice: fix statistics
net/ice: fix DCF control thread crash
net/iavf: fix abnormal disable HW interruptMohammad Iqbal Ahmad (1):
examples/l3fwd: fix duplicate expression for default nexthopNithin Dabilpuram (2):
common/cnxk: fix inline device VF identification net/cnxk: fix cookies check with security offloadOri Kam (1):
net/mlx5: fix query for NIC flow capabilityPavan Nikhilesh (2):
doc: fix event timer adapter guide event/cnxk: fix nanoseconds to ticks conversionPeng Zhang (1):
net/nfp: fix address always related with PF ID 0Philip Prindeville (1):
vfio: fix include with musl runtimeQi Zhang (2):
common/idpf: remove device stop flag
net/ice: initialize parser for double VLANQiming Yang (7):
net/ice/base: fix incorrect defines for DCBxnet/ice/base: remove unreachable code net/e1000: fix queue number initialization net/ice: fix VLAN mode parser net/ixgbe: fix Rx and Tx queue status net/igc: fix Rx and Tx queue status net/e1000: fix Rx and Tx queue statusQin Ke (1):
net/nfp: fix disabling promiscuous modeRahul Bhansali (6):
examples/ipsec-secgw: fix zero address in ethernet header common/cnxk: fix IPsec IPv6 tunnel address byte swap event/cnxk: fix Tx adapter data pointer event/cnxk: fix mempool cookies check test/security: fix event inline IPsec reassembly tests common/cnxk: fix CPT backpressure disable on LBKRakesh Kudurumalla (1):
common/cnxk: fix receive queue with multiple maskRaslan Darawsheh (2):
app/testpmd: fix GTP L2 length in checksum engine
devtools: fix bashism in mailmap checkRonak Doshi (1):
net/vmxnet3: fix drop of empty segments in TxRongwei Liu (4):
net/mlx5: fix matcher layout size calculation net/mlx5: fix VXLAN matching with zero value net/mlx5: forbid duplicated tag index in pattern template net/mlx5: fix duplicated tag index matching in SWSRuifeng Wang (5):
test/malloc: fix missing free test/malloc: fix statistics checks
build: fix warning when getting NUMA nodes test/mbuf: fix crash in a forked process net/mlx5: fix risk in NEON Rx descriptor readSamina Arshad (1):
examples/fips_validation: fix digest length in AES-GCMSaoirse O'Donovan (3):
test/crypto: fix return value for SNOW3Gcrypto/openssl: fix memory freecrypto/ipsec_mb: fix enqueue counter for SNOW3GSatha Rao (1):
net/cnxk: flush SQ before configuring MTUSatheesh Paul (3):
common/cnxk: fix setting channel mask for SDP interfaces common/cnxk: fix uninitialized pointer read net/cnxk: fix flow queue index validationSean Zhang (1):
net/mlx5: fix flow dump for modify fieldShijith Thotton (2):
eventdev/timer: fix timeout event wait behavior event/cnxk: fix setting attributes in empty get workShiyang He (4):
net/iavf: release large VF when closing device net/ice: fix tunnel packet Tx descriptor net/i40e: fix tunnel packet Tx descriptor app/testpmd: fix checksum engine with GTP on 32-bitStephen Hemminger (2):
net/netvsc: fix sizeof calculation
doc: fix description of runtime directoriesSuanming Mou (1):
ethdev: fix indirect action conversionTejasree Kondoj (3):
test/crypto: fix session creation check
crypto/cnxk: fix IPsec CCM capabilities
test/crypto: fix IPsec AES CCM vectorThierry Herbelot (1):
doc: fix typo in cnxk platform guideThomas Monjalon (3):
pci: fix comment referencing renamed function
cryptodev: fix comments of modular operation parameters
devtools: fix mailmap check for parenthesesTianli Lai (1):
net/dpaa2: fix checksum good flagsViacheslav Ovsiienko (2):
net/mlx5: fix device removal event handling
ipc: fix file descriptor leakage with unhandled messagesVikash Poddar (2):
common/qat: fix command parameter corruption common/qat: detach crypto from compress buildVladimir Medvedkin (3):
fib: fix adding default route
hash: fix reading unaligned bits in Toeplitz hash examples/ipsec-secgw: fix TAP default MAC addressWenjing Qiao (7):
common/idpf/base: fix control queue send and receive common/idpf/base: fix ITR register definitions for AVF common/idpf/base: fix parameters when send msg to cp common/idpf/base: fix memory leaks on control queue net/ice: adjust timestamp mbuf register net/ice: fix timestamp enabling
common/iavf: fix MAC type for 710 NICWenjun Wu (5):
net/i40e: fix Rx data buffer size
net/ice: fix Rx data buffer size
net/iavf: fix Rx data buffer size
net/idpf: fix Rx data buffer size common/idpf: fix memory leak on AVX512 Tx queue closeWenzhuo Lu (1):
net/iavf: fix VLAN insertion in vector pathXiao Liang (1):
ipsec: fix NAT-T header lengthYiding Zhou (1):
net/ice: fix 32-bit buildYunjian Wang (2):
ring: fix use after free
net/txgbe: fix use-after-free on removeYuying Zhang (1):
net/ice: fix RSS hash key generationZerun Fu (1):
net/bonding: fix startup when NUMA is not supportedZhichao Zeng (2):
net/ice: fix outer UDP checksum offload
net/iavf: fix stop orderingZhihong Wang (1):
eal/linux: fix secondary process crash for mp hotplug requests
Hi Yanghang,
Thanks for the verification and report, will include in release notes.
Regards,
Xueming Li
From: YangHang Liu <[email protected]>
Sent: 8/30/2023 0:03
To: Xueming(Steven) Li <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; Abhishek Marathe <[email protected]>; Ali Alnubani <[email protected]>; [email protected]; David Christensen <[email protected]>; Hemant Agrawal <[email protected]>; Ian Stokes <[email protected]>; Jerin Jacob <[email protected]>; John McNamara <[email protected]>; Ju-Hyoung Lee <[email protected]>; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]>; Pei Zhang <[email protected]>; [email protected]; Raslan Darawsheh <[email protected]>; NBU-Contact-Thomas Monjalon (EXTERNAL) <[email protected]>; [email protected]; [email protected]
Subject: Re: 22.11.3 patches review and test
Hi, Xueming
RedHat QE did not find any new issues about 22.11.3 rc1 dpdk during the tests.
I tested below 18 scenarios and all got PASS on RHEL9:
• Guest with device assignment(PF) throughput testing(1G hugepage size): PASS
• Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS
• Guest with device assignment(VF) throughput testing: PASS
• PVP (host dpdk testpmd as vswitch) 1Q: throughput testing: PASS
• PVP vhost-user 2Q throughput testing: PASS
• PVP vhost-user 1Q - cross numa node throughput testing: PASS
• Guest with vhost-user 2 queues throughput testing: PASS
• vhost-user reconnect with dpdk-client, qemu-server qemu reconnect: PASS
• vhost-user reconnect with dpdk-client, qemu-server ovs reconnect: PASS
• PVP reconnect with dpdk-client, qemu-server: PASS
• PVP 1Q live migration testing: PASS
• PVP 1Q cross numa node live migration testing: PASS
• Guest with ovs+dpdk+vhost-user 1Q live migration testing: PASS
• Guest with ovs+dpdk+vhost-user 1Q live migration testing (2M): PASS
• Guest with ovs+dpdk+vhost-user 2Q live migration testing: PASS
• Guest with ovs+dpdk+vhost-user 4Q live migration testing: PASS
• Host PF + DPDK testing: PASS
• Host VF + DPDK testing: PASS
Test Versions:
• qemu-kvm-6.2.0 + qemu-kvm-7.2.0
• kernel 5.14
• git log
commit 5e87ad0cf8f2f90b18558913f3c71e7552aa0af5
Author: Xueming Li <mailto:[email protected]>
Date: Thu Aug 17 14:04:17 2023 +0800
version: 22.11.3-rc1
• Test device : X540-AT2 NIC(ixgbe, 10G)
Best Regards,
YangHang Liu
On Thu, Aug 17, 2023 at 2:14 PM Xueming Li <mailto:[email protected]> wrote:
Hi all,
Here is a list of patches targeted for stable release 22.11.3.
The planned date for the final release is 31th August.
Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations will be added to the release notes.
A release candidate tarball can be found at:
https://dpdk.org/browse/dpdk-stable/tag/?id=v22.11.3-rc1
These patches are located at branch 22.11 of dpdk-stable repo:
https://dpdk.org/browse/dpdk-stable/
Thanks.
Xueming Li <mailto:[email protected]>
---
Aakash Sasidharan (1):
test/crypto: fix PDCP-SDAP test vectors
Akhil Goyal (1):
doc: fix auth algos in cryptoperf app
Alexander Kozyrev (4):
net/mlx5: forbid MPRQ restart net/mlx5: fix MPRQ stride size for headroom net/mlx5: fix handle validation for meter mark app/testpmd: fix meter mark handle update
Ali Alnubani (2):
doc: fix typos and wording in flow API guide
doc: improve wording of cuda guide
Alvaro Karsz (1):
dma/dpaa2: set VFA bit for route-by-port with VF
Anoob Joseph (1):
cryptodev: clarify error codes for symmetric session
Artemii Morozov (1):
common/sfc_efx/base: fix Rx queue without RSS hash prefix
Ashwin Sekhar T K (2):
mempool/cnxk: avoid hang when counting batch allocs
doc: fix typo in graph guide
Bing Zhao (12):
app/testpmd: fix flow rule number parsing net/mlx5: fix error set in Tx representor tagging net/mlx5: fix return value of vport action net/mlx5: fix error set in control tables create net/mlx5: fix error set for age pool initialization net/mlx5: fix error in VLAN actions creation common/mlx5: fix obtaining IB device in LAG mode net/mlx5: fix profile check of meter mark net/mlx5: reduce counter pool name length net/mlx5: fix drop action memory leak net/mlx5: fix validation for conntrack indirect action
doc: add flow template API requirements for mlx5
Boleslav Stankevich (2):
net/virtio: propagate interrupt configuration error values net/virtio: fix initialization to return negative errno
Bruce Richardson (4):
kernel/freebsd: fix function parameter list
telemetry: fix autotest on Alpine
eal: avoid calling cleanup twice test/bonding: fix include of standard header
Chaoyong He (14):
net/nfp: fix VLAN push flow action
net/nfp: fix IPv6 flow item
net/nfp: fix TOS of IPv6 VXLAN encap flow action net/nfp: fix TOS of IPv6 GENEVE encap flow action net/nfp: fix TOS of IPv6 NVGRE encap flow action net/nfp: fix TP flow action for UDP
net/nfp: fix IPv6 address for set flow action net/nfp: fix unneeded endian conversion net/nfp: fix endian conversion for tunnel decap action net/nfp: fix VNI of VXLAN encap action net/nfp: fix VNI of IPv4 NVGRE encap action net/nfp: fix VNI of IPv6 NVGRE encap action net/nfp: fix Tx descriptor free logic of NFD3 net/nfp: fix offloading flows
Chengwen Feng (4):
net/hns3: fix Rx multiple firmware reset interrupts net/hns3: fix mbuf leakage when RxQ started during reset net/hns3: fix mbuf leakage when RxQ started after reset net/hns3: fix device start return value
Ciara Power (6):
crypto/qat: fix stack buffer overflow in SGL loop crypto/scheduler: fix last element for valid args crypto/ipsec_mb: optimize allocation in session crypto/qat: fix null algorithm digest placement
cryptodev: fix device socket ID type app/crypto-perf: fix socket ID default value
Dariusz Sosnowski (1):
net/mlx5: fix drop action attribute validation
David Christensen (1):
net/tap: set locally administered bit for fixed MAC address
David Marchand (9):
ci: fix build for Arm cross compilation in GHA net/virtio-user: fix leak when initialisation fails net/mlx5: enhance error log for tunnel offloading examples/l2fwd-cat: fix external build examples/fips_validation: fix external build
test: add graph tests
mbuf: fix Doxygen comment of distributor metadata
ci: fix libabigail cache in GHA
doc: fix link to flow capabilities from bnxt guide
Dengdui Huang (3):
net/hns3: fix variable type mismatch
net/hns3: fix inaccurate log
net/hns3: fix redundant line break in log
Denis Pryazhennikov (3):
ethdev: update documentation for API to set FEC
ethdev: check that at least one FEC mode is specified
ethdev: update documentation for API to get FEC
Devendra Singh Rawat (1):
net/qede: fix RSS indirection table initialization
Didier Pallard (2):
crypto/openssl: fix memory leak in auth processing crypto/openssl: skip workaround at compilation time
Dmitry Kozlyuk (1):
member: fix PRNG seed reset in NitroSketch mode
Dongdong Liu (3):
doc: fix kernel patch link in hns3 guide
doc: fix syntax in hns3 guide
doc: fix number of leading spaces in hns3 guide
Elena Agostini (1):
net: fix return type of IPv4 L4 packet checksum
Erez Ferber (1):
common/mlx5: adjust fork call with new kernel API
Erik Gabriel Carrillo (1):
eventdev/timer: fix buffer flush
Feifei Wang (1):
ring: fix dequeue parameter name
Fengnan Chang (2):
eal/linux: fix legacy mem init with many segments
mem: fix memsegs exhausted message
Ferruh Yigit (3):
kni: fix build with Linux 6.3
app/testpmd: revert primary process polling all queues fix
kni: fix build with Linux 6.5
Gregory Etelson (1):
net/mlx5: fix flow workspace destruction
Heng Jiang (1):
net/mlx5: fix LRO TCP checksum
Hernan Vargas (2):
baseband/fpga_5gnr_fec: fix possible division by zero baseband/fpga_5gnr_fec: fix starting unconfigured queue
Huisong Li (10):
ethdev: fix MAC address occupies two entries net/hns3: fix never set MAC flow control net/hns3: fix RTC time on initialization net/hns3: fix RTC time after reset net/hns3: uninitialize PTP
net/hns3: extract PTP to its own header file net/hns3: fix IMP reset trigger net/hns3: delete duplicate macro definition net/hns3: fix non-zero weight for disabled TC net/hns3: fix index to look up table in NEON Rx
Ivan Malov (2):
net/sfc: stop misuse of Rx ingress m-port metadata on EF100 net/sfc: invalidate dangling MAE flow action FW resource IDs
Jerin Jacob (4):
examples/ip_pipeline: fix build with GCC 13
examples/ntb: fix build with GCC 13
net/hns3: fix build warning
doc: remove warning with Doxygen 1.9.7
Jiawen Wu (11):
net/txgbe/base: fix Tx with fiber hotplug
net/txgbe: fix interrupt enable mask
net/txgbe: adapt to MNG veto bit setting
net/txgbe: fix to set autoneg for 1G speed
net/txgbe: fix extended statistics
net/ngbe: fix extended statistics
net/ngbe: adapt to MNG veto bit setting
net/ngbe: fix link status in no LSC mode
net/ngbe: remove redundant codes
net/txgbe: fix blocking system events
net/ngbe: fix RSS offload capability
Jie Hai (6):
net/hns3: fix FEC mode for 200G ports net/hns3: fix FEC mode check
net/hns3: fix missing FEC capability net/hns3: fix uninitialized variable
ethdev: fix calloc arguments
app/testpmd: fix primary process not polling all queues
Jieqiang Wang (1):
net/i40e: fix comments
Junfeng Guo (4):
net/ice: fix protocol agnostic offloading with big packets net/iavf: fix protocol agnostic offloading with big packets raw/ntb: avoid disabling interrupt twice
doc: update BIOS settings and supported HW for NTB
Kai Ji (1):
examples/ipsec-secgw: fix socket ID default value
Kaijun Zeng (1):
net/vmxnet3: fix return code in initializing
Kaiwen Deng (3):
net/ice: fix DCF RSS initialization net/iavf: fix virtchnl command called in interrupt net/ice: fix MAC type of E822 and E823
Kaiyu Zhang (1):
ethdev: fix potential leak in PCI probing helper
Kamalakannan R (1):
pipeline: fix double free for table stats
Ke Xu (1):
net/iavf: fix tunnel TSO path selection
Leyi Rong (1):
eal/x86: improve multiple of 64 bytes memcpy performance
Long Li (7):
net/mana: use datapath logging
net/mana: avoid unnecessary assignments in data path net/mana: optimize completion queue by batch processing net/mana: return probing failure if no device found net/mana: fix counter overflow for posted WQE net/mana: fix WQE count for ringing RQ doorbell net/mana: fix Tx queue statistics
Long Wu (5):
net/nfp: fix control mempool creation net/nfp: fix representor creation net/nfp: fix flow hash table creation net/bonding: fix destroy dedicated queues flow net/nfp: fix representor name too long
Maayan Kashani (1):
net/mlx5: fix RSS expansion inner buffer overflow
Mattias Rönnblom (1):
event/dsw: free rings on close
Maxime Coquelin (3):
vhost: fix notification stats for packed ring
vhost: fix invalid call FD handling crypto/qat: fix sym device prototype
Michael Baum (1):
doc: fix format in flow API guide
Michal Schmidt (1):
net/iavf: fix VLAN offload with AVX512
Min Zhou (1):
net/ixgbe: add proper memory barriers in Rx
Mingjin Ye (3):
net/ice: fix statistics
net/ice: fix DCF control thread crash
net/iavf: fix abnormal disable HW interrupt
Mohammad Iqbal Ahmad (1):
examples/l3fwd: fix duplicate expression for default nexthop
Nithin Dabilpuram (2):
common/cnxk: fix inline device VF identification net/cnxk: fix cookies check with security offload
Ori Kam (1):
net/mlx5: fix query for NIC flow capability
Pavan Nikhilesh (2):
doc: fix event timer adapter guide event/cnxk: fix nanoseconds to ticks conversion
Peng Zhang (1):
net/nfp: fix address always related with PF ID 0
Philip Prindeville (1):
vfio: fix include with musl runtime
Qi Zhang (2):
common/idpf: remove device stop flag
net/ice: initialize parser for double VLAN
Qiming Yang (7):
net/ice/base: fix incorrect defines for DCBx net/ice/base: remove unreachable code net/e1000: fix queue number initialization net/ice: fix VLAN mode parser net/ixgbe: fix Rx and Tx queue status net/igc: fix Rx and Tx queue status net/e1000: fix Rx and Tx queue status
Qin Ke (1):
net/nfp: fix disabling promiscuous mode
Rahul Bhansali (6):
examples/ipsec-secgw: fix zero address in ethernet header common/cnxk: fix IPsec IPv6 tunnel address byte swap event/cnxk: fix Tx adapter data pointer event/cnxk: fix mempool cookies check test/security: fix event inline IPsec reassembly tests common/cnxk: fix CPT backpressure disable on LBK
Rakesh Kudurumalla (1):
common/cnxk: fix receive queue with multiple mask
Raslan Darawsheh (2):
app/testpmd: fix GTP L2 length in checksum engine
devtools: fix bashism in mailmap check
Ronak Doshi (1):
net/vmxnet3: fix drop of empty segments in Tx
Rongwei Liu (4):
net/mlx5: fix matcher layout size calculation net/mlx5: fix VXLAN matching with zero value net/mlx5: forbid duplicated tag index in pattern template net/mlx5: fix duplicated tag index matching in SWS
Ruifeng Wang (5):
test/malloc: fix missing free test/malloc: fix statistics checks
build: fix warning when getting NUMA nodes test/mbuf: fix crash in a forked process net/mlx5: fix risk in NEON Rx descriptor read
Samina Arshad (1):
examples/fips_validation: fix digest length in AES-GCM
Saoirse O'Donovan (3):
test/crypto: fix return value for SNOW3G crypto/openssl: fix memory free crypto/ipsec_mb: fix enqueue counter for SNOW3G
Satha Rao (1):
net/cnxk: flush SQ before configuring MTU
Satheesh Paul (3):
common/cnxk: fix setting channel mask for SDP interfaces common/cnxk: fix uninitialized pointer read net/cnxk: fix flow queue index validation
Sean Zhang (1):
net/mlx5: fix flow dump for modify field
Shijith Thotton (2):
eventdev/timer: fix timeout event wait behavior event/cnxk: fix setting attributes in empty get work
Shiyang He (4):
net/iavf: release large VF when closing device net/ice: fix tunnel packet Tx descriptor net/i40e: fix tunnel packet Tx descriptor app/testpmd: fix checksum engine with GTP on 32-bit
Stephen Hemminger (2):
net/netvsc: fix sizeof calculation
doc: fix description of runtime directories
Suanming Mou (1):
ethdev: fix indirect action conversion
Tejasree Kondoj (3):
test/crypto: fix session creation check
crypto/cnxk: fix IPsec CCM capabilities
test/crypto: fix IPsec AES CCM vector
Thierry Herbelot (1):
doc: fix typo in cnxk platform guide
Thomas Monjalon (3):
pci: fix comment referencing renamed function
cryptodev: fix comments of modular operation parameters
devtools: fix mailmap check for parentheses
Tianli Lai (1):
net/dpaa2: fix checksum good flags
Viacheslav Ovsiienko (2):
net/mlx5: fix device removal event handling
ipc: fix file descriptor leakage with unhandled messages
Vikash Poddar (2):
common/qat: fix command parameter corruption common/qat: detach crypto from compress build
Vladimir Medvedkin (3):
fib: fix adding default route
hash: fix reading unaligned bits in Toeplitz hash examples/ipsec-secgw: fix TAP default MAC address
Wenjing Qiao (7):
common/idpf/base: fix control queue send and receive common/idpf/base: fix ITR register definitions for AVF common/idpf/base: fix parameters when send msg to cp common/idpf/base: fix memory leaks on control queue net/ice: adjust timestamp mbuf register net/ice: fix timestamp enabling
common/iavf: fix MAC type for 710 NIC
Wenjun Wu (5):
net/i40e: fix Rx data buffer size
net/ice: fix Rx data buffer size
net/iavf: fix Rx data buffer size
net/idpf: fix Rx data buffer size common/idpf: fix memory leak on AVX512 Tx queue close
Wenzhuo Lu (1):
net/iavf: fix VLAN insertion in vector path
Xiao Liang (1):
ipsec: fix NAT-T header length
Yiding Zhou (1):
net/ice: fix 32-bit build
Yunjian Wang (2):
ring: fix use after free
net/txgbe: fix use-after-free on remove
Yuying Zhang (1):
net/ice: fix RSS hash key generation
Zerun Fu (1):
net/bonding: fix startup when NUMA is not supported
Zhichao Zeng (2):
net/ice: fix outer UDP checksum offload
net/iavf: fix stop ordering
Zhihong Wang (1):
eal/linux: fix secondary process crash for mp hotplug requests