Skip to contentSkip to conversation

media: dt-bindings: Convert Omnivision OV7251 to DT schema

PATCH Applied Rob Herring 2 participants 4 messages Aug 17, 2023 – Mar 20, 2024

Subsystems (5)
Device tree bindings Media (V4L/DVB) Arm Qualcomm mailing list I2C subsystem host drivers +1 more subsystems
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH v2 1/1 media: dt-bindings: Convert Omnivision OV7251 to DT schema

Convert the OmniVision OV7251 Image Sensor binding to DT schema format.

vddd-supply was listed as required, but the example and actual user don't have it. Also, the data brief says it has an internal regulator, so perhaps it is truly optional.

Add missing common "link-frequencies" which is used and required by the Linux driver.

Reviewed-by Conor Dooley <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
v2:
- Add link-frequencies which the driver requires

---
 .../devicetree/bindings/i2c/qcom,i2c-cci.yaml |   1 +
 .../devicetree/bindings/media/i2c/ov7251.txt  |  52 ---------
 .../bindings/media/i2c/ovti,ov7251.yaml       | 109 ++++++++++++++++++
 3 files changed, 110 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov7251.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml
Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml +1 -0
index ec79b7270437..042d4dc636ee 100644
@@ -269,6 +269,7 @@ examples:
                 port {
                     ov7251_ep: endpoint {
                         data-lanes = <0 1>;
+                        link-frequencies = /bits/ 64 <240000000 319200000>;
                         remote-endpoint = <&csiphy3_ep>;
                     };
                 };
Documentation/devicetree/bindings/media/i2c/ov7251.txt deleted +0 -52

52 lines not on this page · raw message

Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml new file +109 -0

109 lines not on this page · raw message

Signature · 1 line
2.40.1
Acked-by on v2 1/1
#1 lore raw
Quoted 11 lines · Rob Herring

Convert the OmniVision OV7251 Image Sensor binding to DT schema format.

vddd-supply was listed as required, but the example and actual user don't have it. Also, the data brief says it has an internal regulator, so perhaps it is truly optional.

Add missing common "link-frequencies" which is used and required by the Linux driver.

Reviewed-by Conor Dooley <[email protected]>
Signed-off-by Rob Herring <[email protected]>
Acked-by Wolfram Sang <[email protected]> # for I2C
author maintainer Applied
#2 lore raw
In reply to Rob Herring
Quoted 14 lines · Rob Herring

Convert the OmniVision OV7251 Image Sensor binding to DT schema format.

vddd-supply was listed as required, but the example and actual user don't have it. Also, the data brief says it has an internal regulator, so perhaps it is truly optional.

Add missing common "link-frequencies" which is used and required by the Linux driver.

Reviewed-by Conor Dooley <[email protected]>
Signed-off-by Rob Herring <[email protected]>

---
v2:
- Add link-frequencies which the driver requires

Quoted 8 lines
---
 .../devicetree/bindings/i2c/qcom,i2c-cci.yaml |   1 +
 .../devicetree/bindings/media/i2c/ov7251.txt  |  52 ---------
 .../bindings/media/i2c/ovti,ov7251.yaml       | 109 ++++++++++++++++++
 3 files changed, 110 insertions(+), 52 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/ov7251.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov7251.yaml

Applied, thanks!

#3 lore raw
In reply to Rob Herring
Quoted 11 lines · Rob Herring

Convert the OmniVision OV7251 Image Sensor binding to DT schema format.

vddd-supply was listed as required, but the example and actual user don't have it. Also, the data brief says it has an internal regulator, so perhaps it is truly optional.

Add missing common "link-frequencies" which is used and required by the Linux driver.

Reviewed-by Conor Dooley <[email protected]>
Signed-off-by Rob Herring <[email protected]>

Trivial fix. Applied to for-current, thanks!