Skip to contentSkip to conversation

lib/kunit/attributes.c:41: warning: Function parameter or member 'attr_default' not described in 'kunit_attr'

PATCH kernel test robot 1 participant 1 message Aug 17, 2023 Memory management

lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   47762f08697484cf0c2f2904b8c52375ed26c8cb
commit: 39e92cb1e4a1f6a12097ea2aa9e9ca6f2d2f8a83 [4031/10848] kunit: Add test attributes API structure
config: microblaze-randconfig-r032-20230817 (https://download.01.org/0day-ci/archive/20230818/[email protected]/config)
compiler: microblaze-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230818/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

All warnings (new ones prefixed by >>):

>> lib/kunit/attributes.c:41: warning: Function parameter or member 'attr_default' not described in 'kunit_attr'
>> lib/kunit/attributes.c:41: warning: Function parameter or member 'print' not described in 'kunit_attr'

vim +41 lib/kunit/attributes.c

    22	
    23	/**
    24	 * struct kunit_attr - represents a test attribute and holds flexible
    25	 * helper functions to interact with attribute.
    26	 *
    27	 * @name: name of test attribute, eg. speed
    28	 * @get_attr: function to return attribute value given a test
    29	 * @to_string: function to return string representation of given
    30	 * attribute value
    31	 * @filter: function to indicate whether a given attribute value passes a
    32	 * filter
    33	 */
    34	struct kunit_attr {
    35		const char *name;
    36		void *(*get_attr)(void *test_or_suite, bool is_test);
    37		const char *(*to_string)(void *attr, bool *to_free);
    38		int (*filter)(void *attr, const char *input, int *err);
    39		void *attr_default;
    40		enum print_ops print;
  > 41	};
    42	
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki