Skip to contentSkip to conversation

ubifs: fix missing error code err

PATCH In review Ferry Meng 2 participants 2 messages Aug 18, 2023 – Aug 19, 2023

Subsystems (2)
Memory technology devices (MTD) UBI file system (UBIFS)
lore
Share & tools
lore

Ferry Meng

author
#0 lore raw

PATCH 1/1 ubifs: fix missing error code err

Fix smatch warning:

fs/ubifs/journal.c:1610 ubifs_jnl_truncate() warn: missing error code 'err'

Signed-off-by Ferry Meng <[email protected]>
fs/ubifs/journal.c +1 -0
index dc52ac0f4a34..ab837b73d4b9 100644
@@ -1607,6 +1607,7 @@ int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode,
 				ubifs_err(c, "bad data node (block %u, inode %lu)",
 					  blk, inode->i_ino);
 				ubifs_dump_node(c, dn, dn_size);
+				err = -EUCLEAN;
 				goto out_free;
 			}
Signature · 6 lines
2.19.1.6.gb485710b


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Ferry Meng

Fix smatch warning:

fs/ubifs/journal.c:1610 ubifs_jnl_truncate() warn: missing error code 'err'

Signed-off-by Ferry Meng <[email protected]>
Reviewed-by Zhihao Cheng <[email protected]>

fs/ubifs/journal.c int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode, · line 1613

Quoted 13 lines
fs/ubifs/journal.c +1 -0
index dc52ac0f4a34..ab837b73d4b9 100644
@@ -1607,6 +1607,7 @@ int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode,
  				ubifs_err(c, "bad data node (block %u, inode %lu)",
  					  blk, inode->i_ino);
  				ubifs_dump_node(c, dn, dn_size);
+				err = -EUCLEAN;
  				goto out_free;
  			}

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/