Skip to contentSkip to conversation

driver core: Call in reversed order in device_platform_notify_remove()

PATCH New Andy Shevchenko 1 participant 1 message Aug 18, 2023 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 driver core: Call in reversed order in device_platform_notify_remove()

It's logically correct to call the removal notifiers in the reversed order as it might be dependent to each other. Luckily, platform_notify_remove() currently is not used and the others have no dependency use, but theoretically it's still possible.

---
 drivers/base/core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/base/core.c +4 -4
index 3afb7710ccb5..edcf0a2ccee4 100644
@@ -2306,12 +2306,12 @@ static void device_platform_notify(struct device *dev)
 
 static void device_platform_notify_remove(struct device *dev)
 {
-	acpi_device_notify_remove(dev);
-
-	software_node_notify_remove(dev);
-
 	if (platform_notify_remove)
 		platform_notify_remove(dev);
+
+	software_node_notify_remove(dev);
+
+	acpi_device_notify_remove(dev);
 }
 
 /**
Signature · 1 line
2.40.0.1.gaa8946217a0b