Skip to contentSkip to conversation

radix-tree-remove-unused-variable.patch removed from -mm tree

merged mm-hotfixes-stable Andrew Morton 1 participant 1 message Aug 21, 2023 Stable branch

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: radix tree: remove unused variable
has been removed from the -mm tree. Its filename was
radix-tree-remove-unused-variable.patch

This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Arnd Bergmann <[email protected]>
Subject: radix tree: remove unused variable
Date: Fri, 11 Aug 2023 15:10:13 +0200

Recent versions of clang warn about an unused variable, though older versions saw the 'slot++' as a use and did not warn:

radix-tree.c:1136:50: error: parameter 'slot' set but not used [-Werror,-Wunused-but-set-parameter]

It's clearly not needed any more, so just remove it.

Fixes 3a08cd52c37c7 ("radix tree: Remove multiorder support")
Cc Matthew Wilcox <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Peng Zhang <[email protected]>
Cc Rong Tao <[email protected]>
Cc Tom Rix <[email protected]>

---

 lib/radix-tree.c |    1 -
 1 file changed, 1 deletion(-)
lib/radix-tree.c renamed from lib/radix-tree.c~radix-tree-remove-unused-variable +0 -1
@@ -1136,7 +1136,6 @@ static void set_iter_tags(struct radix_t
 void __rcu **radix_tree_iter_resume(void __rcu **slot,
 					struct radix_tree_iter *iter)
 {
-	slot++;
 	iter->index = __radix_tree_iter_add(iter, 1);
 	iter->next_index = iter->index;
 	iter->tags = 0;

_

Patches currently in -mm which might be from [email protected] are

iomem-remove-__weak-ioremap_cache-helper.patch