Skip to contentSkip to conversation

lib-vsprintf-declare-no_hash_pointers-in-sprintfh.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Aug 21, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: lib/vsprintf: declare no_hash_pointers in sprintf.h
has been removed from the -mm tree. Its filename was
lib-vsprintf-declare-no_hash_pointers-in-sprintfh.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Andy Shevchenko <[email protected]>
Subject: lib/vsprintf: declare no_hash_pointers in sprintf.h
Date: Mon, 14 Aug 2023 19:33:44 +0300

Sparse is not happy to see non-static variable without declaration:
lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static?

Declare respective variable in the sprintf.h. With this, add a comment to discourage its use if no real need.

---

 include/linux/sprintf.h |    2 ++
 lib/test_printf.c       |    2 --
 mm/kfence/report.c      |    3 +--
 3 files changed, 3 insertions(+), 4 deletions(-)
include/linux/sprintf.h renamed from include/linux/sprintf.h~lib-vsprintf-declare-no_hash_pointers-in-sprintfh +2 -0
@@ -20,6 +20,8 @@ __printf(2, 0) const char *kvasprintf_co
 __scanf(2, 3) int sscanf(const char *, const char *, ...);
 __scanf(2, 0) int vsscanf(const char *, const char *, va_list);
 
+/* These are for specific cases, do not use without real need */
+extern bool no_hash_pointers;
 int no_hash_pointers_enable(char *str);
 
 #endif	/* _LINUX_KERNEL_SPRINTF_H */
lib/test_printf.c renamed from lib/test_printf.c~lib-vsprintf-declare-no_hash_pointers-in-sprintfh +0 -2
@@ -42,8 +42,6 @@ KSTM_MODULE_GLOBALS();
 static char *test_buffer __initdata;
 static char *alloced_buffer __initdata;
 
-extern bool no_hash_pointers;
-
 static int __printf(4, 0) __init
 do_test(int bufsize, const char *expect, int elen,
 	const char *fmt, va_list ap)
mm/kfence/report.c renamed from mm/kfence/report.c~lib-vsprintf-declare-no_hash_pointers-in-sprintfh +1 -2
@@ -13,6 +13,7 @@
 #include <linux/printk.h>
 #include <linux/sched/debug.h>
 #include <linux/seq_file.h>
+#include <linux/sprintf.h>
 #include <linux/stacktrace.h>
 #include <linux/string.h>
 #include <trace/events/error_report.h>
@@ -26,8 +27,6 @@
 #define ARCH_FUNC_PREFIX ""
 #endif
 
-extern bool no_hash_pointers;
-
 /* Helper function to either print to a seq_file or to console. */
 __printf(2, 3)
 static void seq_con_printf(struct seq_file *seq, const char *fmt, ...)

_

Patches currently in -mm which might be from [email protected] are