Skip to contentSkip to conversation

freevxfs: Fix comment on vxfs_readdir

PATCH In review GUO Zihua 2 participants 2 messages Aug 22, 2023

lore
Share & tools
lore

GUO Zihua

author
#0 lore raw

PATCH 1/1 freevxfs: Fix comment on vxfs_readdir

As vxfs_readdir now switches to iterate_shared interface, the parameter of the function is changed. However, the comment of has not been updated.

This patch updates function doc to reflect this change.

Fixes 9b5d5a170781 ("[readdir] convert freevxfs")
---
 fs/freevxfs/vxfs_lookup.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
fs/freevxfs/vxfs_lookup.c +3 -4
index f04ba2ed1e1a..53cbb7209324 100644
@@ -177,12 +177,11 @@ vxfs_lookup(struct inode *dip, struct dentry *dp, unsigned int flags)
 /**
  * vxfs_readdir - read a directory
  * @fp:		the directory to read
- * @retp:	return buffer
- * @filler:	filldir callback
+ * @ctx:	Dir context
  *
  * Description:
- *   vxfs_readdir fills @retp with directory entries from @fp
- *   using the VFS supplied callback @filler.
+ *   vxfs_readdir emits directory entries from @fp using the
+ *   VFS supplied @ctx.
  *
  * Returns:
  *   Zero.
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · GUO Zihua

As vxfs_readdir now switches to iterate_shared interface, the parameter of the function is changed. However, the comment of has not been updated.

This patch updates function doc to reflect this change.

Fixes 9b5d5a170781 ("[readdir] convert freevxfs")

Thanks.

Quoted 24 lines
---
 fs/freevxfs/vxfs_lookup.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
fs/freevxfs/vxfs_lookup.c +3 -4
index f04ba2ed1e1a..53cbb7209324 100644
@@ -177,12 +177,11 @@ vxfs_lookup(struct inode *dip, struct dentry *dp, unsigned int flags)
 /**
  * vxfs_readdir - read a directory
  * @fp:		the directory to read
- * @retp:	return buffer
- * @filler:	filldir callback
+ * @ctx:	Dir context
  *
  * Description:
- *   vxfs_readdir fills @retp with directory entries from @fp
- *   using the VFS supplied callback @filler.
+ *   vxfs_readdir emits directory entries from @fp using the
+ *   VFS supplied @ctx.
  *
  * Returns:
  *   Zero.
Signature · 1 line
~Randy