Skip to contentSkip to conversation

staging: axis-fifo: fix alignment of open parenthesis

PATCH In review Rohit Chavan 2 participants 2 messages Aug 22, 2023 Staging

lore
Share & tools
lore

Rohit Chavan

author
#0 lore raw

PATCH 1/1 staging: axis-fifo: fix alignment of open parenthesis

Fixed all CHECK: Alignment should match open parenthesis as reported by checkpatch to adhere to the Linux kernel coding-style guidelines.

Signed-off-by Rohit Chavan <[email protected]>
---
 drivers/staging/axis-fifo/axis-fifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +2 -2
index 727b956aa231..d0ca82a755e4 100644
@@ -381,7 +381,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
 		 */
 		mutex_lock(&fifo->read_lock);
 		ret = wait_event_interruptible_timeout(fifo->read_queue,
-			ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
+						       ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
 			read_timeout);
 
 		if (ret <= 0) {

@@ -522,7 +522,7 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		 */
 		mutex_lock(&fifo->write_lock);
 		ret = wait_event_interruptible_timeout(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+						       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
 				 >= words_to_write,
 			write_timeout);

--
2.30.2

#1 lore raw
Quoted 14 lines · Rohit Chavan

Fixed all CHECK: Alignment should match open parenthesis as reported by checkpatch to adhere to the Linux kernel coding-style guidelines.

Signed-off-by Rohit Chavan <[email protected]>
---
 drivers/staging/axis-fifo/axis-fifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/axis-fifo/axis-fifo.c +0 -0
index 727b956aa231..d0ca82a755e4 100644

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_read(struct file *f, char __user *buf, · line 385

Quoted 6 lines
drivers/staging/axis-fifo/axis-fifo.c +1 -1
@@ -381,7 +381,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
 		 */
 		mutex_lock(&fifo->read_lock);
 		ret = wait_event_interruptible_timeout(fifo->read_queue,
-			ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
+						       ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
 			read_timeout);

This "read_timeout" should have the same indentation as the line above.

drivers/staging/axis-fifo/axis-fifo.c static ssize_t axis_fifo_write(struct file *f, const char __user *buf, · line 527

Quoted 10 lines
drivers/staging/axis-fifo/axis-fifo.c +1 -1
 		if (ret <= 0) {

@@ -522,7 +522,7 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
 		 */
 		mutex_lock(&fifo->write_lock);
 		ret = wait_event_interruptible_timeout(fifo->write_queue,
-			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
+						       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
 				 >= words_to_write,
 			write_timeout);

Also here, this looks very ugly after your change :(

Best regards,
Nam