erofs: release ztailpacking pclusters properly
PATCH 1/1 erofs: release ztailpacking pclusters properly
Currently ztailpacking pclusters are chained with FOLLOWED_NOINPLACE and not recorded into the managed_pslots XArray.
After commit 7674a42f35ea ("erofs: use struct lockref to replace handcrafted approach"), ztailpacking pclusters won't be freed with erofs_workgroup_put() anymore, which will cause the following issue:
BUG erofs_pcluster-1 (Tainted: G OE ): Objects remaining in erofs_pcluster-1 on __kmem_cache_shutdown()
Use z_erofs_free_pcluster() directly to free ztailpacking pclusters.
--- fs/erofs/zdata.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
fs/erofs/zdata.c +4 -1
@@ -1410,7 +1410,10 @@ static void z_erofs_decompress_queue(const struct z_erofs_decompressqueue *io, owned =READ_ONCE (be.pcl->next);z_erofs_decompress_pcluster (&be, io->eio ? -EIO :0 ); -erofs_workgroup_put (&be.pcl->obj); +if (z_erofs_is_inline_pcluster (be.pcl)) +z_erofs_free_pcluster (be.pcl); +else +erofs_workgroup_put (&be.pcl->obj); } }
Signature · 1 line
2.19.1.6.gb485710b
Quoted 7 lines · Jingbo Xu
Currently ztailpacking pclusters are chained with
FOLLOWED_NOINPLACEand not recorded into themanaged_pslotsXArray.After commit
7674a42f35ea("erofs: use struct lockref to replace handcrafted approach"), ztailpacking pclusters won't be freed witherofs_workgroup_put()anymore, which will cause the following issue:
Quoted 6 lines
BUG erofs_pcluster-1 (Tainted: G OE ): Objects remaining in erofs_pcluster-1 on
__kmem_cache_shutdown()Use
z_erofs_free_pcluster()directly to free ztailpacking pclusters.Fixes 7674a42f35ea ("erofs: use struct lockref to replace handcrafted approach")Signed-off-by Jingbo Xu <[email protected]>
Thanks,
Gao Xiang
Quoted 7 lines · Jingbo Xu
Currently ztailpacking pclusters are chained with
FOLLOWED_NOINPLACEand not recorded into themanaged_pslotsXArray.After commit
7674a42f35ea("erofs: use struct lockref to replace handcrafted approach"), ztailpacking pclusters won't be freed witherofs_workgroup_put()anymore, which will cause the following issue:
Quoted 6 lines
BUG erofs_pcluster-1 (Tainted: G OE ): Objects remaining in erofs_pcluster-1 on
__kmem_cache_shutdown()Use
z_erofs_free_pcluster()directly to free ztailpacking pclusters.Fixes 7674a42f35ea ("erofs: use struct lockref to replace handcrafted approach")Signed-off-by Jingbo Xu <[email protected]>
Thanks,