Skip to contentSkip to conversation

fstests: btrfs/213: fix the _not_run spell

PATCH In review Qu Wenruo 2 participants 2 messages Aug 24, 2023 Btrfs file system

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH 1/1 fstests: btrfs/213: fix the _not_run spell

The proper function is _notrun, not _not_run.

This can cause false alerts if the write speed is too fast or has some cache causing the balance to finish eariler than expectation.

---
 tests/btrfs/213 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/btrfs/213 +1 -1
index 5666d9b9..6def4f6e 100755
@@ -55,7 +55,7 @@ sleep $(($runtime / 4))
 # any error about no balance currently running.
 $BTRFS_UTIL_PROG balance cancel "$SCRATCH_MNT" 2>&1 | grep -iq 'not in progress'
 if [ $? -eq 0 ]; then
-	_not_run "balance finished before we could cancel it"
+	_notrun "balance finished before we could cancel it"
 fi
 
 # Now check if we can finish relocating metadata, which should finish very
Signature · 1 line
2.41.0
#1 lore raw
Quoted 4 lines · Qu Wenruo

The proper function is _notrun, not _not_run.

This can cause false alerts if the write speed is too fast or has some cache causing the balance to finish eariler than expectation.

https://lore.kernel.org/fstests/71413edbeb1ee5b945f0b82faccaf4a75e8ba56b.1691924176.git.fdmanana@suse.com/

Quoted 22 lines
---
 tests/btrfs/213 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/btrfs/213 +1 -1
index 5666d9b9..6def4f6e 100755
@@ -55,7 +55,7 @@ sleep $(($runtime / 4))
 # any error about no balance currently running.
 $BTRFS_UTIL_PROG balance cancel "$SCRATCH_MNT" 2>&1 | grep -iq 'not in progress'
 if [ $? -eq 0 ]; then
-	_not_run "balance finished before we could cancel it"
+	_notrun "balance finished before we could cancel it"
 fi
 
 # Now check if we can finish relocating metadata, which should finish very
Signature · 1 line
2.41.0