Skip to contentSkip to conversation

add missing CVE_PRODUCT

PATCH In review Emil Kronborg Andersen 2 participants 11 messages Aug 24, 2023 – Aug 30, 2023

lore
Share & tools
lore
#0 lore raw

cover add missing CVE_PRODUCT

Some recipes does not have 'CVE_PRODUCT' set, and will thus pass a check against the NIST database with 0 CVEs, even though there could be several. Note that 'CVE_PRODUCT' for dbus is not added but rather extended.

Emil Kronborg Andersen (3):
dbus: add additional entries to CVE_PRODUCT
libxkbcommon: add CVE_PRODUCT
libx11-compose-data: add CVE_PRODUCT

 meta/recipes-core/dbus/dbus_1.14.8.bb                       | 2 +-
 meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb | 2 ++
 meta/recipes-graphics/xorg-lib/libxkbcommon_1.5.0.bb        | 2 ++
 3 files changed, 5 insertions(+), 1 deletion(-)
Signature · 1 line
2.41.0
#1 lore raw

PATCH 1/3 dbus: add additional entries to CVE_PRODUCT

---
 meta/recipes-core/dbus/dbus_1.14.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/dbus/dbus_1.14.8.bb +1 -1
index b6c245d40b..2dcbadd50b 100644
@@ -184,4 +184,4 @@ do_install:class-nativesdk() {
 }
 BBCLASSEXTEND = "native nativesdk"
 
-CVE_PRODUCT += "d-bus_project:d-bus"
+CVE_PRODUCT += "d-bus_project:d-bus freedesktop:dbus freedesktop:libdbus"
Signature · 1 line
2.41.0
#2 lore raw

PATCH 2/3 libxkbcommon: add CVE_PRODUCT

In reply to Emil Kronborg Andersen
---
 meta/recipes-graphics/xorg-lib/libxkbcommon_1.5.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/xorg-lib/libxkbcommon_1.5.0.bb +2 -0
index 01966c8973..62e9b158e4 100644
@@ -36,3 +36,5 @@ python populate_packages:prepend () {
 RDEPENDS:${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'libx11-locale', 'libx11-compose-data', d)}"
 
 BBCLASSEXTEND += "native"
+
+CVE_PRODUCT += "xkbcommon:libxkbcommon"
Signature · 1 line
2.41.0
#3 lore raw

PATCH 3/3 libx11-compose-data: add CVE_PRODUCT

In reply to Emil Kronborg Andersen
---
 meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb +2 -0
index 2131f46213..5d5762456c 100644
@@ -33,3 +33,5 @@ do_install() {
 PACKAGES = "${PN}"
 
 FILES:${PN} = "${datadir}/X11/locale ${libdir}/X11/locale"
+
+CVE_PRODUCT += "x.org:libx11"
Signature · 1 line
2.41.0
#4 lore raw

Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Quoted 14 lines · Emil Kronborg Andersen via lists.openembedded.org

---
meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb | 2 ++

1 file changed, 2 insertions(+)
meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb +0 -0
index 2131f46213..5d5762456c 100644
@@ -33,3 +33,5 @@ do_install() {

PACKAGES = "${PN}"

FILES:${PN} = "${datadir}/X11/locale ${libdir}/X11/locale"

meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb

Quoted 2 lines
meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb +2 -0
+
+CVE_PRODUCT += "x.org:libx11”

This is _just_ the compose data, is it feasible for this to have a CVE?

Ross

#5 lore raw

Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Hi Ross,

No, you are right. However, I think it would make sense to include CVE_PRODUCT​ in xorg-lib-common.inc​ instead. What do you think?

Emil
________________________________
From: Ross Burton <[email protected]>
Sent: Friday, August 25, 2023 17:16
To: Emil Kronborg Andersen <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Quoted 14 lines · Emil Kronborg Andersen via lists.openembedded.org

---
meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb | 2 ++

1 file changed, 2 insertions(+)
meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb +0 -0
index 2131f46213..5d5762456c 100644
@@ -33,3 +33,5 @@ do_install() {

PACKAGES = "${PN}"

FILES:${PN} = "${datadir}/X11/locale ${libdir}/X11/locale"

meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb

Quoted 2 lines
meta/recipes-graphics/xorg-lib/libx11-compose-data_1.8.4.bb +2 -0
+
+CVE_PRODUCT += "x.org:libx11”

This is _just_ the compose data, is it feasible for this to have a CVE?

Ross

#6 lore raw

Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Quoted 1 line · Emil Kronborg Andersen

No, you are right. However, I think it would make sense to include CVE_PRODUCT​ in xorg-lib-common.inc​ instead. What do you think?

That’s definitely wrong, as most of the X11 libraries use that file.

Ross

#7 lore raw

Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

That is why I want to include it in that file. Doesn't it make sense to capture CVEs for x.org:libx11​ if you use any of the libraries?

Emil
________________________________
From: Ross Burton <[email protected]>
Sent: Tuesday, August 29, 2023 11:45
To: Emil Kronborg Andersen <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Quoted 1 line · Emil Kronborg Andersen

No, you are right. However, I think it would make sense to include CVE_PRODUCT​ in xorg-lib-common.inc​ instead. What do you think?

That’s definitely wrong, as most of the X11 libraries use that file.

Ross

#8 lore raw

Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Quoted 2 lines · Emil Kronborg Andersen

That is why I want to include it in that file. Doesn't it make sense to capture CVEs for x.org:libx11​ if you use any of the libraries?

No, x.org <http://x.org/>:libx11 refers to libx11, not eg libxvmc.

Ross

#9 lore raw

Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Alright. I thought libx11​ was a dependency of the packages that include xorg-lib-common.inc​, which is why I asked.

So I guess this patch can just be dropped then? Do you need me to do anything further?

Emil
________________________________
From: Ross Burton <[email protected]>
Sent: Wednesday, August 30, 2023 11:27
To: Emil Kronborg Andersen <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Quoted 2 lines · Emil Kronborg Andersen

That is why I want to include it in that file. Doesn't it make sense to capture CVEs for x.org:libx11​ if you use any of the libraries?

No, x.org <http://x.org/>:libx11 refers to libx11, not eg libxvmc.

Ross

#10 lore raw

Re: [OE-core] [PATCH 3/3] libx11-compose-data: add CVE_PRODUCT

Quoted 4 lines · Emil Kronborg Andersen

Alright. I thought libx11​ was a dependency of the packages that include xorg-lib-common.inc​, which is why I asked.

It _mostly_ is, but issues in libx11 will be reported by the libx11 recipe, not in packages that depend on libx11.

Quoted 1 line

So I guess this patch can just be dropped then? Do you need me to do anything further?

Nope, nothing else to do.

Ross