python3: Add packagegroup-core-buildessential rdep to ptests
PATCH 1/1 python3: Add packagegroup-core-buildessential rdep to ptests
cppext test needs full toolchain as it tries to build an extention with C, using packagegroup-core-buildessential ensures that a function toolchain bits are pulled into ptest image, as an aside it also abstracts hardcoding compiler to be gcc
--- meta/recipes-devtools/python/python3_3.11.4.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/python/python3_3.11.4.bb +1 -1
@@ -424,7 +424,7 @@ FILES:${PN}-man = "${datadir}/man" # See https://bugs.python.org/issue18748 and https://bugs.python.org/issue37395 RDEPENDS:libpython3:append:libc-glibc = " libgcc" RDEPENDS:${PN}-ctypes:append:libc-glibc = " ${MLPREFIX}ldconfig" -RDEPENDS:${PN}-ptest = "${PN}-modules ${PN}-tests ${PN}-dev ${PN}-cgitb ${PN}-zipapp unzip bzip2 libgcc tzdata coreutils sed gcc g++ binutils" +RDEPENDS:${PN}-ptest = "${PN}-modules ${PN}-tests ${PN}-dev ${PN}-cgitb ${PN}-zipapp unzip bzip2 libgcc tzdata coreutils sed packagegroup-core-buildessential" RDEPENDS:${PN}-ptest:append:libc-glibc = " locale-base-fr-fr locale-base-en-us locale-base-tr-tr locale-base-de-de" RDEPENDS:${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', '${MLPREFIX}tk ${MLPREFIX}tk-lib', '', d)}" RDEPENDS:${PN}-idle += "${@bb.utils.contains('PACKAGECONFIG', 'tk', '${PN}-tkinter ${MLPREFIX}tcl', '', d)}"
Signature · 1 line
2.42.0
Quoted 15 lines · Khem Raj
cppext test needs full toolchain as it tries to build an extention with C, using packagegroup-core-buildessential ensures that a function toolchain bits are pulled into ptest image, as an aside it also abstracts hardcoding compiler to be gcc
Signed-off-by Khem Raj <[email protected]>--- meta/recipes-devtools/python/python3_3.11.4.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-devtools/python/python3_3.11.4.bb +0
-0
meta/recipes-devtools/python/python3_3.11.4.bb FILES:${PN}-man = "${datadir}/man" · line 430
Quoted 8 lines
meta/recipes-devtools/python/python3_3.11.4.bb +1
-1@@ -424,7 +424,7 @@ FILES:${PN}-man = "${datadir}/man" # See https://bugs.python.org/issue18748 and https://bugs.python.org/issue37395 RDEPENDS:libpython3:append:libc-glibc = " libgcc" RDEPENDS:${PN}-ctypes:append:libc-glibc = " ${MLPREFIX}ldconfig" -RDEPENDS:${PN}-ptest = "${PN}-modules ${PN}-tests ${PN}-dev ${PN}-cgitb ${PN}-zipapp unzip bzip2 libgcc tzdata coreutils sed gcc g++ binutils" +RDEPENDS:${PN}-ptest = "${PN}-modules ${PN}-tests ${PN}-dev ${PN}-cgitb ${PN}-zipapp unzip bzip2 libgcc tzdata coreutils sed packagegroup-core-buildessential" RDEPENDS:${PN}-ptest:append:libc-glibc = " locale-base-fr-fr locale-base-en-us locale-base-tr-tr locale-base-de-de" RDEPENDS:${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', '${MLPREFIX}tk ${MLPREFIX}tk-lib', '', d)}" RDEPENDS:${PN}-idle += "${@bb.utils.contains('PACKAGECONFIG', 'tk', '${PN}-tkinter ${MLPREFIX}tcl', '', d)}"
That also increases the dependencies needed to complete a build of target python and I'm not sure this is a great idea. Compiler dependencies in ptests are a real problem in this regard but this patch makes the situation a lot worse :(
Cheers,
Richard
Quoted 21 lines · Richard Purdie
Quoted 20 lines · Khem Raj
cppext test needs full toolchain as it tries to build an extention with C, using packagegroup-core-buildessential ensures that a function toolchain bits are pulled into ptest image, as an aside it also abstracts hardcoding compiler to be gcc
Signed-off-by Khem Raj <[email protected]>--- meta/recipes-devtools/python/python3_3.11.4.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-devtools/python/python3_3.11.4.bb +1
-1@@ -424,7 +424,7 @@ FILES:${PN}-man = "${datadir}/man" # See https://bugs.python.org/issue18748 and https://bugs.python.org/issue37395 RDEPENDS:libpython3:append:libc-glibc = " libgcc" RDEPENDS:${PN}-ctypes:append:libc-glibc = " ${MLPREFIX}ldconfig" -RDEPENDS:${PN}-ptest = "${PN}-modules ${PN}-tests ${PN}-dev ${PN}-cgitb ${PN}-zipapp unzip bzip2 libgcc tzdata coreutils sed gcc g++ binutils" +RDEPENDS:${PN}-ptest = "${PN}-modules ${PN}-tests ${PN}-dev ${PN}-cgitb ${PN}-zipapp unzip bzip2 libgcc tzdata coreutils sed packagegroup-core-buildessential"
Quoted 9 lines
meta/recipes-devtools/python/python3_3.11.4.bb FILES:${PN}-man = "${datadir}/man" · line 430
Quoted 3 lines
meta/recipes-devtools/python/python3_3.11.4.bb +0
-0RDEPENDS:${PN}-ptest:append:libc-glibc = " locale-base-fr-fr locale-base-en-us locale-base-tr-tr locale-base-de-de" RDEPENDS:${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', '${MLPREFIX}tk ${MLPREFIX}tk-lib', '', d)}" RDEPENDS:${PN}-idle += "${@bb.utils.contains('PACKAGECONFIG', 'tk', '${PN}-tkinter ${MLPREFIX}tcl', '', d)}"That also increases the dependencies needed to complete a build of target python and I'm not sure this is a great idea. Compiler dependencies in ptests are a real problem in this regard but this patch makes the situation a lot worse :(
We can drop it, I have added the needed bits into meta-clang
I think hardcoding dependencies for toolchain components could be made better.
for poky ptests is in default distro features so I can see your concern
Quoted 3 lines
Cheers,
Richard