Skip to contentSkip to conversation

cpufreq: tegra194: add online/offline hooks

PATCH Applied Sumit Gupta 2 participants 2 messages Aug 25, 2023 – Aug 28, 2023

Subsystems (2)
Tegra architecture support CPU frequency scaling framework
lore
Share & tools
lore

Sumit Gupta

author
#0 lore raw

PATCH 1/1 cpufreq: tegra194: add online/offline hooks

Implement the light-weight tear down and bring up helpers to reduce the amount of work to do on CPU offline/online operation.
This change helps to make the hotplugging paths much faster.

Suggested-by Viresh Kumar <[email protected]>
Signed-off-by Sumit Gupta <[email protected]>
Link https://lore.kernel.org/lkml/20230816033402.3abmugb5goypvllm@vireshk-i7/ open here
---
 drivers/cpufreq/tegra194-cpufreq.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
drivers/cpufreq/tegra194-cpufreq.c +17 -0
index 66a9c23544db..09582696b83d 100644
@@ -510,6 +510,21 @@ static int tegra194_cpufreq_init(struct cpufreq_policy *policy)
 	return 0;
 }
 
+static int tegra194_cpufreq_online(struct cpufreq_policy *policy)
+{
+	/* We did light-weight tear down earlier, nothing to do here */
+	return 0;
+}
+
+static int tegra194_cpufreq_offline(struct cpufreq_policy *policy)
+{
+	/*
+	 * Preserve policy->driver_data and don't free resources on light-weight
+	 * tear down.
+	 */
+	return 0;
+}
+
 static int tegra194_cpufreq_exit(struct cpufreq_policy *policy)
 {
 	struct device *cpu_dev = get_cpu_device(policy->cpu);

@@ -548,6 +563,8 @@ static struct cpufreq_driver tegra194_cpufreq_driver = {
 	.get = tegra194_get_speed,
 	.init = tegra194_cpufreq_init,
 	.exit = tegra194_cpufreq_exit,
+	.online = tegra194_cpufreq_online,
+	.offline = tegra194_cpufreq_offline,
 	.attr = cpufreq_generic_attr,
 };
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 38 lines · Sumit Gupta

Implement the light-weight tear down and bring up helpers to reduce the amount of work to do on CPU offline/online operation.
This change helps to make the hotplugging paths much faster.

Suggested-by Viresh Kumar <[email protected]>
Signed-off-by Sumit Gupta <[email protected]>
Link https://lore.kernel.org/lkml/20230816033402.3abmugb5goypvllm@vireshk-i7/ open here
---
 drivers/cpufreq/tegra194-cpufreq.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
drivers/cpufreq/tegra194-cpufreq.c +15 -0
index 66a9c23544db..09582696b83d 100644
@@ -510,6 +510,21 @@ static int tegra194_cpufreq_init(struct cpufreq_policy *policy)
 	return 0;
 }
 
+static int tegra194_cpufreq_online(struct cpufreq_policy *policy)
+{
+	/* We did light-weight tear down earlier, nothing to do here */
+	return 0;
+}
+
+static int tegra194_cpufreq_offline(struct cpufreq_policy *policy)
+{
+	/*
+	 * Preserve policy->driver_data and don't free resources on light-weight
+	 * tear down.
+	 */
+	return 0;
+}
+
 static int tegra194_cpufreq_exit(struct cpufreq_policy *policy)
 {
 	struct device *cpu_dev = get_cpu_device(policy->cpu);

drivers/cpufreq/tegra194-cpufreq.c static struct cpufreq_driver tegra194_cpufreq_driver = { · line 569

Quoted 7 lines
drivers/cpufreq/tegra194-cpufreq.c +2 -0
@@ -548,6 +563,8 @@ static struct cpufreq_driver tegra194_cpufreq_driver = {
 	.get = tegra194_get_speed,
 	.init = tegra194_cpufreq_init,
 	.exit = tegra194_cpufreq_exit,
+	.online = tegra194_cpufreq_online,
+	.offline = tegra194_cpufreq_offline,
 	.attr = cpufreq_generic_attr,
 };

Applied. Thanks.

Signature · 1 line
viresh