Skip to contentSkip to conversation

configs/freescale_imx6qsabresd_defconfig: fix defconfig

PATCH Applied Romain Naour 5 participants 7 messages Aug 26, 2023 – Sep 13, 2023 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs/freescale_imx6qsabresd_defconfig: fix defconfig

While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y symbol was not removed. Since then this defconfig fail to build in gitlab-ci due to invalid defconfig check.

WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y

[1] dd42b159a5f752921ee602530d289c810ad7ee51

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612

---
This defconfig will fail anyway due to too old ATF package (pre V2.9 version) and binutils 2.39+. But it should be backported up to 2023.02.

---
 configs/freescale_imx6qsabresd_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/freescale_imx6qsabresd_defconfig +0 -1
index 86513d8072..dddfaf5228 100644
@@ -37,7 +37,6 @@ BR2_PACKAGE_HOST_MTOOLS=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="mx6qsabresd"
 BR2_TARGET_UBOOT_FORMAT_IMX=y
-BR2_TARGET_UBOOT_CUSTOM_GIT=y
 BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
 BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,nxp-imx,uboot-imx,lf-5.10.y-1.0.0)/uboot-imx-lf-5.10.y-1.0.0.tar.gz"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
Signature · 6 lines
2.41.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/1 configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38

Backport an upstream patch fixing the build with binutils >= 2.38 for riscv's for Zicsr and Zifencei.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4936949340
https://gitlab.com/buildroot.org/buildroot/-/jobs/4936949329

---
All four sipeed_maix* defconfigs sipeed_maix_bit_sdcard_defconfig, sipeed_maix_dock_sdcard_defconfig, sipeed_maixduino_sdcard_defconfig and sipeed_maix_go_sdcard_defconfig are using the same uboot version. Only two were fixed by the previous commit ef4eea32261ed3f21af119936a080cb2fc8897fa "configs/sipeed_maix_{bit, dock}_sdcard_defconfig: fix build with binutils >= 2.38"

---
 configs/sipeed_maix_go_sdcard_defconfig   | 1 +
 configs/sipeed_maixduino_sdcard_defconfig | 1 +
 2 files changed, 2 insertions(+)
configs/sipeed_maix_go_sdcard_defconfig +1 -0
index 6c61e3aaaf..2bea0b97be 100644
@@ -17,6 +17,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_19=y
 BR2_BINFMT_FLAT=y
 BR2_BINFMT_FLAT_ONE=y
 # BR2_TARGET_ENABLE_ROOT_LOGIN is not set
+BR2_GLOBAL_PATCH_DIR="board/canaan/k210-soc/patches"
 
 # Kernel
 BR2_LINUX_KERNEL=y
configs/sipeed_maixduino_sdcard_defconfig +1 -0
index da8cbe45f9..db7896fadf 100644
@@ -17,6 +17,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_19=y
 BR2_BINFMT_FLAT=y
 BR2_BINFMT_FLAT_ONE=y
 # BR2_TARGET_ENABLE_ROOT_LOGIN is not set
+BR2_GLOBAL_PATCH_DIR="board/canaan/k210-soc/patches"
 
 # Kernel
 BR2_LINUX_KERNEL=y
Signature · 6 lines
2.41.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH] configs/sipeed_{maixduino, maix_go}_sdcard_defconfig: fix build with binutils >= 2.38

Quoted 14 lines · On Sat, 26 Aug 2023 18:56:28 +0200 Romain Naour <[email protected]> wrote:

Backport an upstream patch fixing the build with binutils >= 2.38 for riscv's for Zicsr and Zifencei.

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4936949340
https://gitlab.com/buildroot.org/buildroot/-/jobs/4936949329

---
All four sipeed_maix* defconfigs sipeed_maix_bit_sdcard_defconfig, sipeed_maix_dock_sdcard_defconfig, sipeed_maixduino_sdcard_defconfig and sipeed_maix_go_sdcard_defconfig are using the same uboot version. Only two were fixed by the previous commit ef4eea32261ed3f21af119936a080cb2fc8897fa "configs/sipeed_maix_{bit, dock}_sdcard_defconfig: fix build with binutils >= 2.38"

Quoted 4 lines
---
 configs/sipeed_maix_go_sdcard_defconfig   | 1 +
 configs/sipeed_maixduino_sdcard_defconfig | 1 +
 2 files changed, 2 insertions(+)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw
In reply to Romain Naour
Quoted 12 lines · On Sat, 26 Aug 2023 18:56:27 +0200 Romain Naour <[email protected]> wrote:

While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y symbol was not removed. Since then this defconfig fail to build in gitlab-ci due to invalid defconfig check.

WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y

[1] dd42b159a5f752921ee602530d289c810ad7ee51

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612

Quoted 7 lines

---
This defconfig will fail anyway due to too old ATF package (pre V2.9 version) and binutils 2.39+. But it should be backported up to 2023.02.

---
 configs/freescale_imx6qsabresd_defconfig | 1 -
 1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
reviewer
#4 lore raw
In reply to Romain Naour

Hi Romain,

Quoted 2 lines · Romain Naour

While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y

ATF?

I think you meant:

"While switching the kernel repository from codeaurora to github"

Quoted 8 lines

symbol was not removed. Since then this defconfig fail to build in gitlab-ci due to invalid defconfig check.

WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y

[1] dd42b159a5f752921ee602530d289c810ad7ee51

Quoted 7 lines

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612

---
This defconfig will fail anyway due to too old ATF package (pre V2.9 version) and binutils 2.39+. But it should be backported up to 2023.02.

I am confused by this statement as this defconfig does not use ATF.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Hello Fabio,

Le 26/08/2023 à 20:18, Fabio Estevam a écrit :

Quoted 7 lines

Hi Romain,

Quoted 2 lines · Romain Naour

While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y

ATF?

My bad, I was looking at other imx/freescale defconfig while working on this one. I've read BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_GIT=y (I don't know how...)

Quoted 4 lines

I think you meant:

"While switching the kernel repository from codeaurora to github"

Indeed.

Quoted 12 lines
Quoted 12 lines

symbol was not removed. Since then this defconfig fail to build in gitlab-ci due to invalid defconfig check.

WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y

[1] dd42b159a5f752921ee602530d289c810ad7ee51

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612

Quoted 6 lines
Quoted 4 lines

---
This defconfig will fail anyway due to too old ATF package (pre V2.9 version) and binutils 2.39+. But it should be backported up to 2023.02.

I am confused by this statement as this defconfig does not use ATF.

Me too now, I should double check commits made late in the evening before sending it to the mailing list.

I did a full build without any other issue. Still this patch needs to be backported.

Best regards,
Romain

Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#6 lore raw
In reply to Romain Naour
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

While switching ATF to github, the BR2_TARGET_UBOOT_CUSTOM_GIT=y symbol was not removed. Since then this defconfig fail to build in gitlab-ci due to invalid defconfig check.

WARN: defconfig ./configs/freescale_imx6qsabresd_defconfig can't be used:
Missing: BR2_TARGET_UBOOT_CUSTOM_GIT=y

[1] dd42b159a5f752921ee602530d289c810ad7ee51

Quoted 7 lines

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/4889436612

---
This defconfig will fail anyway due to too old ATF package (pre V2.9 version) and binutils 2.39+. But it should be backported up to 2023.02.

Committed to 2023.02.x and 2023.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot