Skip to contentSkip to conversation

Revert "bin_package.bbclass: Inhibit the default dependencies"

PATCH In review Max Krummenacher 4 participants 12 messages Aug 27, 2023 – Oct 27, 2023 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

cover Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue: /usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue: /usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue: /usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Max

Max Krummenacher (1):
Revert "bin_package.bbclass: Inhibit the default dependencies"

 meta/classes-recipe/bin_package.bbclass | 3 ---
 1 file changed, 3 deletions(-)
Signature · 1 line
2.35.3
#1 lore raw

PATCH 1/1 Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

This reverts commit d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727.

The commit not only removes the dependencies on the cross compiler but also does not depend on e.g. virtual/${TARGET_PREFIX}compilerlibs and virtual/libc which in turn makes the file-rdeps qa check fail if installing binaries linked against e.g. libc or libstdc++.

---
 meta/classes-recipe/bin_package.bbclass | 3 ---
 1 file changed, 3 deletions(-)
meta/classes-recipe/bin_package.bbclass +0 -3
index 9dd2489725..3a1befc29c 100644
@@ -20,9 +20,6 @@
 # they would be in ${WORKDIR}.
 #
 
-# Nothing is being built so there is no need for the cross-compiler.
-INHIBIT_DEFAULT_DEPS = "1"
-
 # Skip the unwanted steps
 do_configure[noexec] = "1"
 do_compile[noexec] = "1"
Signature · 1 line
2.35.3
#2 lore raw

*ping* This needs to be applied to both master and nanbield.

//Peter

Quoted 37 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 1/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

This reverts commit d1d09bd4d7be88f0e341d5fccbfbefeb98d4b727.

The commit not only removes the dependencies on the cross compiler but also does not depend on e.g. virtual/${TARGET_PREFIX}compilerlibs and virtual/libc which in turn makes the file-rdeps qa check fail if installing binaries linked against e.g. libc or libstdc++.

---
 meta/classes-recipe/bin_package.bbclass | 3 ---
 1 file changed, 3 deletions(-)
meta/classes-recipe/bin_package.bbclass +0 -4
index 9dd2489725..3a1befc29c 100644
@@ -20,9 +20,6 @@
 # they would be in ${WORKDIR}.
 #
 
-# Nothing is being built so there is no need for the cross-compiler.
-INHIBIT_DEFAULT_DEPS = "1"
-
 # Skip the unwanted steps
 do_configure[noexec] = "1"
 do_compile[noexec] = "1"
--

2.35.3

#3 lore raw
In reply to Max Krummenacher
Quoted 35 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

Quoted 7 lines

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

Quoted 11 lines

Max

Max Krummenacher (1):
Revert "bin_package.bbclass: Inhibit the default dependencies"

 meta/classes-recipe/bin_package.bbclass | 3 ---
 1 file changed, 3 deletions(-)

--
2.35.3

//Peter

#4 lore raw
Quoted 53 lines · Peter Kjellerstedt
Quoted 36 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

Quoted 7 lines

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

Quoted 6 lines

Max

Max Krummenacher (1):
Revert "bin_package.bbclass: Inhibit the default dependencies"

Quoted 8 lines
Quoted 5 lines
 meta/classes-recipe/bin_package.bbclass | 3 ---
 1 file changed, 3 deletions(-)

--
2.35.3

//Peter

From the bugzilla entry [1] which added the feature and from the commit adding the class [2] it looks to me that the class should simplify adding binaries externally built for the target.
Having the users of the class having to add the used libc / compiler shared objects to not trigger a qa warning seems really wrong to me.

Additionally I don't see the advantage in not installing the base dependencies. Doing anything usefull in a build would need to build them anyway for some other recipe, so one would save creating a few hard links. Do I miss something here?

So IMHO a recipe which inherits the class and really does not like the default dependencies should add the INHIBIT_DEFAULT_DEPS = "1".

Regards
Max

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 71 lines · Max Krummenacher via lists.openembedded.org
Quoted 53 lines · Peter Kjellerstedt
Quoted 36 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

Quoted 7 lines

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

Quoted 6 lines

Max

Max Krummenacher (1):
Revert "bin_package.bbclass: Inhibit the default dependencies"

Quoted 8 lines
Quoted 5 lines
 meta/classes-recipe/bin_package.bbclass | 3 ---
 1 file changed, 3 deletions(-)

--
2.35.3

//Peter

From the bugzilla entry [1] which added the feature and from the commit adding the class [2] it looks to me that the class should simplify adding binaries externally built for the target.
Having the users of the class having to add the used libc / compiler shared objects to not trigger a qa warning seems really wrong to me.

Quoted 7 lines

Additionally I don't see the advantage in not installing the base dependencies. Doing anything usefull in a build would need to build them anyway for some other recipe, so one would save creating a few hard links. Do I miss something here?

So IMHO a recipe which inherits the class and really does not like the default dependencies should add the INHIBIT_DEFAULT_DEPS = "1".

Adding the missing links, sorry about that:
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=1592
[2] https://www.openembedded.org/pipermail/openembedded-core/2012-September/067782.html

Quoted 12 lines

Regards
Max

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186832): https://lists.openembedded.org/g/openembedded-core/message/186832
Mute This Topic: https://lists.openembedded.org/mt/100987453/3617484
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#7 lore raw
Quoted 64 lines · Max Krummenacher
Quoted 61 lines · Max Krummenacher via lists.openembedded.org
Quoted 38 lines · Peter Kjellerstedt
Quoted 38 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

Quoted 8 lines
Quoted 5 lines

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

From the bugzilla entry [1] which added the feature and from the commit
adding the class [2] it looks to me that the class should simplify adding binaries externally built for the target.
Having the users of the class having to add the used libc / compiler shared objects to not trigger a qa warning seems really wrong to me.

Additionally I don't see the advantage in not installing the base dependencies. Doing anything usefull in a build would need to build them anyway for some other recipe, so one would save creating a few hard links. Do I miss something here?

Quoted 6 lines
Quoted 2 lines

So IMHO a recipe which inherits the class and really does not like the default dependencies should add the INHIBIT_DEFAULT_DEPS = "1".

Adding the missing links, sorry about that:
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=1592
[2] https://www.openembedded.org/pipermail/openembedded-core/2012-September/067782.html

Thanks for bringing this to light Max. I have no opinion in this. I understand not wanting to implicitly depending on anything. After all, explicit is always nice for those that don't want to navigate the full include chain to figure out recipe dependencies. It's also nicer for a minimal build (though arguably not in this case because these are core packages we're depending on).

If this is going to be the standard moving forward please let me know so I can update this recipe accordingly.

#8 lore raw
Quoted 68 lines · Randolph Sapp
Quoted 67 lines · Max Krummenacher
Quoted 63 lines · Max Krummenacher via lists.openembedded.org
Quoted 38 lines · Peter Kjellerstedt
Quoted 38 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

Quoted 8 lines
Quoted 5 lines

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

 From the bugzilla entry [1] which added the feature and from the commit adding the class [2] it looks to me that the class should simplify adding binaries externally built for the target.
Having the users of the class having to add the used libc / compiler shared objects to not trigger a qa warning seems really wrong to me.

Additionally I don't see the advantage in not installing the base dependencies. Doing anything usefull in a build would need to build them anyway for some other recipe, so one would save creating a few hard links. Do I miss something here?

So IMHO a recipe which inherits the class and really does not like the default dependencies should add the INHIBIT_DEFAULT_DEPS = "1".

Quoted 7 lines
Quoted 3 lines

Adding the missing links, sorry about that:
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=1592
[2] https://www.openembedded.org/pipermail/openembedded-core/2012-September/067782.html

Thanks for bringing this to light Max. I have no opinion in this. I understand not wanting to implicitly depending on anything. After all, explicit is always nice for those that don't want to navigate the full include chain to figure out recipe dependencies. It's also nicer for a minimal build (though arguably not in this case because these are core packages we're depending on).

If this is going to be the standard moving forward please let me know so I can update this recipe accordingly.

Scratch that, I have an opinion now. Removing hidden base package dependencies that QA steps explicitly rely is a bad idea. Please revert this.

#9 lore raw
Quoted 73 lines · Randolph Sapp
Quoted 72 lines · Randolph Sapp
Quoted 70 lines · Max Krummenacher
Quoted 56 lines · Max Krummenacher via lists.openembedded.org
Quoted 38 lines · Peter Kjellerstedt
Quoted 38 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

Quoted 8 lines
Quoted 5 lines

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

 From the bugzilla entry [1] which added the feature and from the commit adding the class [2] it looks to me that the class should simplify adding binaries externally built for the target.
Having the users of the class having to add the used libc / compiler shared objects to not trigger a qa warning seems really wrong to me.

Quoted 7 lines

Additionally I don't see the advantage in not installing the base dependencies. Doing anything usefull in a build would need to build them anyway for some other recipe, so one would save creating a few hard links. Do I miss something here?

So IMHO a recipe which inherits the class and really does not like the default dependencies should add the INHIBIT_DEFAULT_DEPS = "1".

Adding the missing links, sorry about that:
[1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=1592
[2] https://www.openembedded.org/pipermail/openembedded-core/2012-September/067782.html

Quoted 5 lines
Quoted 3 lines

Thanks for bringing this to light Max. I have no opinion in this. I understand not wanting to implicitly depending on anything. After all, explicit is always nice for those that don't want to navigate the full include chain to figure out recipe dependencies. It's also nicer for a minimal build (though arguably not in this case because these are core packages we're depending on).

If this is going to be the standard moving forward please let me know so I can update this recipe accordingly.

Scratch that, I have an opinion now. Removing hidden base package dependencies that QA steps explicitly rely is a bad idea. Please revert this.

Or at least have the insane.bbclass class introduce it's required dependencies itself, as that seems more logical than having a generic base group anyway.

#10 lore raw
In reply to Peter Kjellerstedt
Quoted 37 lines · Peter Kjellerstedt
Quoted 37 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

Quoted 8 lines
Quoted 5 lines

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

Was there some issue that your patch was seeking to solve? There was not much explanation in your patch or discussion about it on the mailing list before it was accepted.

Or did this just seem like something to do since this class doesn't build anything?

Just looking for background.

Your commit is also the source of another error with this the same ti-img-rogue-umlibs recipe that I've been trying to track down all last week. Max just beat me to finding it.

I'm voting to revert your patch unless there is compelling reason for your patch.

Quoted 24 lines
Quoted 11 lines

Max

Max Krummenacher (1):
Revert "bin_package.bbclass: Inhibit the default dependencies"

  meta/classes-recipe/bin_package.bbclass | 3 ---
  1 file changed, 3 deletions(-)

--
2.35.3

//Peter

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#186807): https://lists.openembedded.org/g/openembedded-core/message/186807
Mute This Topic: https://lists.openembedded.org/mt/100987453/6551054
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#11 lore raw
Quoted 57 lines

-----Original Message-----
From: Ryan Eatmon <[email protected]>
Sent: den 28 augusti 2023 19:10
To: Peter Kjellerstedt <[email protected]>; Max Krummenacher <[email protected]>; [email protected]
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: Re: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

Quoted 37 lines · Peter Kjellerstedt
Quoted 37 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

Quoted 8 lines
Quoted 5 lines

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

Quoted 6 lines

Was there some issue that your patch was seeking to solve? There was not much explanation in your patch or discussion about it on the mailing list before it was accepted.

Or did this just seem like something to do since this class doesn't build anything?

It just seemed logical that since nothing is built, there should be no need for the compiler. I did, however, miss the potential need for the runtime libraries.

Quoted 8 lines

Just looking for background.

Your commit is also the source of another error with this the same ti-img-rogue-umlibs recipe that I've been trying to track down all last week. Max just beat me to finding it.

I'm voting to revert your patch unless there is compelling reason for your patch.

If it was not obvious from my response above, I am in favor of reverting my change since the errors reported by Max obviously was not part of my use case and did not affect any of our recipes.

//Peter

A message that is not in the archive (sent off-list or not yet received): [email protected]

#13 lore raw
Quoted 78 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Peter Kjellerstedt
Sent: den 31 augusti 2023 19:28
To: Ryan Eatmon <[email protected]>; Max Krummenacher <[email protected]>; [email protected]
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: Re: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

Quoted 54 lines

-----Original Message-----
From: Ryan Eatmon <[email protected]>
Sent: den 28 augusti 2023 19:10
To: Peter Kjellerstedt <[email protected]>; Max Krummenacher <[email protected]>; [email protected]
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: Re: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

Quoted 37 lines · Peter Kjellerstedt
Quoted 37 lines

-----Original Message-----
From: Max Krummenacher <[email protected]>
Sent: den 27 augusti 2023 10:10
To: [email protected]; Peter Kjellerstedt <[email protected]>
Cc: Max Krummenacher <[email protected]>; Randolph Sapp <[email protected]>
Subject: [oe][OE-core][Patch 0/1] Revert "bin_package.bbclass: Inhibit the default dependencies"

From: Max Krummenacher <[email protected]>

Hi

With commit d1d09bd4d7 ("bin_package.bbclass: Inhibit the default dependencies") applied I'm getting a lot of these errors, i.e. qa does miss libc and compiler provided libs:

ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires ld-linux-aarch64.so.1(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libusc.so.23.1.6404501 contained in package ti-img-rogue-umlibs requires libc.so.6(GLIBC_2.17)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]
ERROR: ti-img-rogue-umlibs-23.1.6404501-r2 do_package_qa: QA Issue:
/usr/lib/libufwriter.so.23.1.6404501 contained in package ti-img-rogue- umlibs requires libstdc++.so.6(GLIBCXX_3.4.14)(64bit), but no providers found in RDEPENDS:ti-img-rogue-umlibs? [file-rdeps]

Reverting the commit makes the build pass, alternatively adding to depends in the recipe which is using the bin_package class fixes it too:

DEPENDS += " virtual/${TARGET_PREFIX}compilerlibs virtual/libc"

Quoted 8 lines
Quoted 5 lines

I'd prefer reverting removing the default dependencies over fixing each of the recipes which do use the bin_package class to actually install binaries running in the target user space.

Any opinions?

Bummer. I guess we will have to update our recipes individually instead. :(

Quoted 6 lines

Was there some issue that your patch was seeking to solve? There was not much explanation in your patch or discussion about it on the mailing list before it was accepted.

Or did this just seem like something to do since this class doesn't build anything?

It just seemed logical that since nothing is built, there should be no need for the compiler. I did, however, miss the potential need for the runtime libraries.

Quoted 6 lines

Just looking for background.

Your commit is also the source of another error with this the same ti-img-rogue-umlibs recipe that I've been trying to track down all last week. Max just beat me to finding it.

Quoted 8 lines
Quoted 2 lines

I'm voting to revert your patch unless there is compelling reason for your patch.

If it was not obvious from my response above, I am in favor of reverting my change since the errors reported by Max obviously was not part of my use case and did not affect any of our recipes.

//Peter

Please apply Max' revert. I thought it was applied back in August when this was discussed, but it apparently never happened.

//Peter