Skip to contentSkip to conversation

dt-bindings: display/panel: Add AUO G156HAN04.0 LVDS display

PATCH In review Elmar Albert 3 participants 4 messages Aug 28, 2023 – Sep 5, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: display/panel: Add AUO G156HAN04.0 LVDS display

From: Elmar Albert <[email protected]>

Document support for the AUO G156HAN04.0 LVDS display.

G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of a TFT LCD panel, a driver circuit, and LED backlight system. The screen format is intended to supportthe 16:9 FHD, 1920(H) x 1080(V) screen and 16.7M colors (RGB 8-bits ) with LED backlight driving circuit. All input signals are LVDS interface compatible.

G156HAN04.0 is designed for a display unit of notebook style personal computer and industrial machine.

---
Cc: Conor Dooley <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Thierry Reding <[email protected]>

---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-simple.yaml +2 -0
index 25b4589d4a58..cea702de664b 100644
@@ -67,6 +67,8 @@ properties:
       - auo,g121ean01
         # AU Optronics Corporation 13.3" FHD (1920x1080) TFT LCD panel
       - auo,g133han01
+        # AU Optronics Corporation 15.6" FHD (1920x1080) TFT LCD panel
+      - auo,g156han04
         # AU Optronics Corporation 15.6" (1366x768) TFT LCD panel
       - auo,g156xtn01
         # AU Optronics Corporation 18.5" FHD (1920x1080) TFT LCD panel
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/2 drm/panel: Add AUO G156HAN04.0 LVDS display support

From: Elmar Albert <[email protected]>

G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of a TFT LCD panel, a driver circuit, and LED backlight system. The screen format is intended to supportthe 16:9 FHD, 1920(H) x 1080(V) screen and 16.7M colors (RGB 8-bits ) with LED backlight driving circuit. All input signals are LVDS interface compatible.

G156HAN04.0 is designed for a display unit of notebook style personal computer and industrial machine.

---
Cc: Conor Dooley <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Thierry Reding <[email protected]>

---
 drivers/gpu/drm/panel/panel-simple.c | 36 ++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +36 -0
index 52572fde9705..4fe6dafcabf6 100644
@@ -1050,6 +1050,39 @@ static const struct panel_desc auo_g133han01 = {
 	.connector_type = DRM_MODE_CONNECTOR_LVDS,
 };
 
+static const struct display_timing auo_g156han04_timings = {
+	.pixelclock = { 137000000, 141000000, 146000000 },
+
+	.hactive = { 1920, 1920, 1920 },
+	.hfront_porch = { 60, 60, 60 },
+	.hback_porch =  { 90, 92, 111 },
+	.hsync_len =    { 32, 32, 32 },
+
+	.vactive = { 1080, 1080, 1080 },
+	.vfront_porch = { 12, 12, 12 },
+	.vback_porch =  { 24, 36, 56 },
+	.vsync_len =    {  8,  8,  8 },
+};
+
+static const struct panel_desc auo_g156han04 = {
+	.timings = &auo_g156han04_timings,
+	.num_timings = 1,
+	.bpc = 8,
+	.size = {
+		.width = 344,
+		.height = 194,
+	},
+	.delay = {
+		.prepare = 50,		/* T2 */
+		.enable = 200,		/* T3 */
+		.disable = 110,		/* T10 */
+		.unprepare = 1000,	/* T13 */
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
 static const struct drm_display_mode auo_g156xtn01_mode = {
 	.clock = 76000,
 	.hdisplay = 1366,
@@ -4118,6 +4151,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "auo,g133han01",
 		.data = &auo_g133han01,
+	}, {
+		.compatible = "auo,g156han04",
+		.data = &auo_g156han04,
 	}, {
 		.compatible = "auo,g156xtn01",
 		.data = &auo_g156xtn01,
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH 2/2] drm/panel: Add AUO G156HAN04.0 LVDS display support

Hi Elmar,

Just had a few minor comments:

Looking at past panel-simple changes, I think the prefix here should be "drm/panel: simple:"

Quoted 5 lines · Elmar Albert

From: Elmar Albert <[email protected]>

G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of a TFT LCD panel, a driver circuit, and LED backlight system. The screen format is intended to supportthe 16:9 FHD, 1920(H) x 1080(V) screen

nit: "support the"

Quoted 47 lines

and 16.7M colors (RGB 8-bits ) with LED backlight driving circuit. All input signals are LVDS interface compatible.

G156HAN04.0 is designed for a display unit of notebook style personal computer and industrial machine.

---
Cc: Conor Dooley <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: David Airlie <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Thierry Reding <[email protected]>

---
  drivers/gpu/drm/panel/panel-simple.c | 36 ++++++++++++++++++++++++++++
  1 file changed, 36 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +17 -0
index 52572fde9705..4fe6dafcabf6 100644
@@ -1050,6 +1050,39 @@ static const struct panel_desc auo_g133han01 = {
  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
  };
 
+static const struct display_timing auo_g156han04_timings = {
+	.pixelclock = { 137000000, 141000000, 146000000 },
+
+	.hactive = { 1920, 1920, 1920 },
+	.hfront_porch = { 60, 60, 60 },
+	.hback_porch =  { 90, 92, 111 },
+	.hsync_len =    { 32, 32, 32 },
+
+	.vactive = { 1080, 1080, 1080 },
+	.vfront_porch = { 12, 12, 12 },
+	.vback_porch =  { 24, 36, 56 },
+	.vsync_len =    {  8,  8,  8 },
+};
+
+static const struct panel_desc auo_g156han04 = {
+	.timings = &auo_g156han04_timings,
+	.num_timings = 1,

drivers/gpu/drm/panel/panel-simple.c static const struct panel_desc auo_g133han01 = { · line 1079

Quoted 10 lines
drivers/gpu/drm/panel/panel-simple.c +10 -0
+	.bpc = 8,
+	.size = {
+		.width = 344,
+		.height = 194,
+	},
+	.delay = {
+		.prepare = 50,		/* T2 */
+		.enable = 200,		/* T3 */
+		.disable = 110,		/* T10 */
+		.unprepare = 1000,	/* T13 */

The inclusion of the comments seems unnecessary.

Thanks,

Jessica Zhang

Quoted 22 lines
drivers/gpu/drm/panel/panel-simple.c +9 -0
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
+	.connector_type = DRM_MODE_CONNECTOR_LVDS,
+};
+
  static const struct drm_display_mode auo_g156xtn01_mode = {
  	.clock = 76000,
  	.hdisplay = 1366,
@@ -4118,6 +4151,9 @@ static const struct of_device_id platform_of_match[] = {
  	}, {
  		.compatible = "auo,g133han01",
  		.data = &auo_g133han01,
+	}, {
+		.compatible = "auo,g156han04",
+		.data = &auo_g156han04,
  	}, {
  		.compatible = "auo,g156xtn01",
  		.data = &auo_g156xtn01,
Signature · 1 line
2.34.1
Acked-by on v1 1/2
#3 lore raw
In reply to Elmar Albert
Quoted 4 lines · Elmar Albert

From: Elmar Albert <[email protected]>

Document support for the AUO G156HAN04.0 LVDS display.

Quoted 9 lines

G156HAN04.0 is a Color Active Matrix Liquid Crystal Display composed of a TFT LCD panel, a driver circuit, and LED backlight system. The screen format is intended to supportthe 16:9 FHD, 1920(H) x 1080(V) screen and 16.7M colors (RGB 8-bits ) with LED backlight driving circuit. All input signals are LVDS interface compatible.

G156HAN04.0 is designed for a display unit of notebook style personal computer and industrial machine.

Best regards,
Krzysztof