Skip to contentSkip to conversation

x86/irq: fix reporting of spurious i8259 interrupts

PATCH In review Roger Pau Monne 2 participants 2 messages Aug 28, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/irq: fix reporting of spurious i8259 interrupts

The return value of bogus_8259A_irq() is wrong: the function will return true when the IRQ is real and false when it's a spurious IRQ. This causes the "No irq handler for vector ..." message in do_IRQ() to be printed for spurious i8259 interrupts which is not intended (and not helpful).

Fix by inverting the return value of bogus_8259A_irq().

Fixes 132906348a14 ('x86/i8259: Handle bogus spurious interrupts more quietly')
---
 xen/arch/x86/i8259.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/arch/x86/i8259.c +1 -1
index 6b35be10f09a..ed9f55abe51e 100644
@@ -37,7 +37,7 @@ static bool _mask_and_ack_8259A_irq(unsigned int irq);
 
 bool bogus_8259A_irq(unsigned int irq)
 {
-    return _mask_and_ack_8259A_irq(irq);
+    return !_mask_and_ack_8259A_irq(irq);
 }
 
 static void cf_check mask_and_ack_8259A_irq(struct irq_desc *desc)
Signature · 1 line
2.41.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Roger Pau Monne

The return value of bogus_8259A_irq() is wrong: the function will return true when the IRQ is real and false when it's a spurious IRQ. This causes the "No irq handler for vector ..." message in do_IRQ() to be printed for spurious i8259 interrupts which is not intended (and not helpful).

Fix by inverting the return value of bogus_8259A_irq().

Fixes 132906348a14 ('x86/i8259: Handle bogus spurious interrupts more quietly')