Skip to contentSkip to conversation

tty: serial: meson: Add a earlycon for the S4 SoC

PATCH Superseded Lucas Tanure 2 participants 4 messages Aug 28, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tty: serial: meson: Add a earlycon for the S4 SoC

The new Amlogic S4 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it.

---
 drivers/tty/serial/meson_uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/meson_uart.c +2 -2
index 790d910dafa5..8dfaa260e545 100644
@@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
 	return 0;
 }
 
-OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
-		    meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);
 
 #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
 #else
Signature · 7 lines
2.42.0


_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
maintainer
#1 lore raw

Hi,

Quoted 13 lines · Lucas Tanure

The new Amlogic S4 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it.

---
  drivers/tty/serial/meson_uart.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/meson_uart.c +0 -0
index 790d910dafa5..8dfaa260e545 100644

drivers/tty/serial/meson_uart.c meson_serial_early_console_setup(struct earlycon_device *device, const char *opt · line 650

Quoted 7 lines
drivers/tty/serial/meson_uart.c +2 -2
@@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
  	return 0;
  }
 
-OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
-		    meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);

Not sure why you would change both lines, and where's the t7 entry ?

Neil

drivers/tty/serial/meson_uart.c meson_serial_early_console_setup(struct earlycon_device *device, const char *opt · line 653

Quoted 3 lines
drivers/tty/serial/meson_uart.c +0 -0
  #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
  #else

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#2 lore raw
Quoted 20 lines · Neil Armstrong

Hi,

Quoted 16 lines · Lucas Tanure

The new Amlogic S4 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it.

---
  drivers/tty/serial/meson_uart.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/meson_uart.c +0 -0
index 790d910dafa5..8dfaa260e545 100644
@@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
      return 0;
  }
 
Quoted 6 lines

drivers/tty/serial/meson_uart.c meson_serial_early_console_setup(struct earlycon_device *device, const char *opt · line 650

Quoted 4 lines
drivers/tty/serial/meson_uart.c +2 -2
-OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
-                 meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);

Not sure why you would change both lines, and where's the t7 entry ?

ok, but we don't need t7, right? T7 will use S4 compatible line.

Quoted 7 lines

Neil

Quoted 3 lines
drivers/tty/serial/meson_uart.c +0 -0
  #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
  #else

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#3 lore raw

Hi,

Quoted 22 lines · Lucas Tanure
Quoted 20 lines · Neil Armstrong

Hi,

Quoted 16 lines · Lucas Tanure

The new Amlogic S4 SoC does not have a always-on uart, so add OF_EARLYCON_DECLARE for it.

---
   drivers/tty/serial/meson_uart.c | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
drivers/tty/serial/meson_uart.c +0 -0
index 790d910dafa5..8dfaa260e545 100644
@@ -646,8 +646,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
       return 0;
   }
 
Quoted 7 lines
Quoted 6 lines

drivers/tty/serial/meson_uart.c meson_serial_early_console_setup(struct earlycon_device *device, const char *opt · line 650

Quoted 4 lines
drivers/tty/serial/meson_uart.c +2 -2
-OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
-                 meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart", meson_serial_early_console_setup);
+OF_EARLYCON_DECLARE(meson, "amlogic,meson-s4-uart", meson_serial_early_console_setup);

Not sure why you would change both lines, and where's the t7 entry ?

ok, but we don't need t7, right? T7 will use S4 compatible line.

Indeed, I forget you finally used amlogic,meson-s4-uart as fallback.

Please indicate this in the commit message.

I'll ack the revert then,

Thanks,
Neil

Quoted 7 lines
Quoted 7 lines

Neil

Quoted 3 lines
drivers/tty/serial/meson_uart.c +0 -0
   #define MESON_SERIAL_CONSOLE_PTR(_devname) (&meson_serial_console_##_devname)
   #else

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic