Skip to contentSkip to conversation

platform/x86: mlx-platform: Kconfig

PATCH In review Vadim Pasternak 3 participants 4 messages Aug 29, 2023 – Aug 30, 2023 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

cover platform/x86: mlx-platform: Kconfig

This fix is produced on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next

Fixes 1316e0af2dc0 ("platform: mellanox: mlx-platform: Introduce ACPI init flow")

from for-next branch.

Vadim Pasternak (1):
platform/x86: mlx-platform: Add dependency on PCI to Kconfig

 drivers/platform/x86/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 platform/x86: mlx-platform: Add dependency on PCI to Kconfig

Add dependency on PCI to avoid 'mlx-platform' compilation error in case CONFIG_PCI is not set.

Failed on i386:
CONFIG_ACPI=y
CONFIG_ISA=y

Error In function 'mlxplat_pci_fpga_device_init':
implicit declaration of function 'pci_request_region':

 6204 |         err = pci_request_region(pci_dev, 0, res_name);
      |               ^~~~~~~~~~~~~~~~~~
      |               pci_request_regions
Fixes 1316e0af2dc0 ("platform: mellanox: mlx-platform: Introduce ACPI init flow")
---
 drivers/platform/x86/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/platform/x86/Kconfig +1 -2
index a43db6731f34..2a1070543391 100644
@@ -965,8 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
 
 config MLX_PLATFORM
 	tristate "Mellanox Technologies platform support"
-	depends on ACPI
-	depends on I2C
+	depends on ACPI && I2C && PCI
 	select REGMAP
 	help
 	  This option enables system support for the Mellanox Technologies
Signature · 1 line
2.20.1
Acked-by Tested-by on v1 1/1
#2 lore raw

Re: [PATCH platform-next 1/1] platform/x86: mlx-platform: Add dependency on PCI to Kconfig

Quoted 9 lines · Vadim Pasternak

Add dependency on PCI to avoid 'mlx-platform' compilation error in case CONFIG_PCI is not set.

Failed on i386:
CONFIG_ACPI=y
CONFIG_ISA=y

Error In function 'mlxplat_pci_fpga_device_init':
implicit declaration of function 'pci_request_region':

Quoted 7 lines
 6204 |         err = pci_request_region(pci_dev, 0, res_name);
      |               ^~~~~~~~~~~~~~~~~~
      |               pci_request_regions
Fixes 1316e0af2dc0 ("platform: mellanox: mlx-platform: Introduce ACPI init flow")

Thanks.

Quoted 18 lines
---
 drivers/platform/x86/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/platform/x86/Kconfig +1 -2
index a43db6731f34..2a1070543391 100644
@@ -965,8 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
 
 config MLX_PLATFORM
 	tristate "Mellanox Technologies platform support"
-	depends on ACPI
-	depends on I2C
+	depends on ACPI && I2C && PCI
 	select REGMAP
 	help
 	  This option enables system support for the Mellanox Technologies
Signature · 1 line
~Randy
#3 lore raw

Re: [PATCH platform-next 1/1] platform/x86: mlx-platform: Add dependency on PCI to Kconfig

In reply to Vadim Pasternak

Hi,

Quoted 9 lines · Vadim Pasternak

Add dependency on PCI to avoid 'mlx-platform' compilation error in case CONFIG_PCI is not set.

Failed on i386:
CONFIG_ACPI=y
CONFIG_ISA=y

Error In function 'mlxplat_pci_fpga_device_init':
implicit declaration of function 'pci_request_region':

Quoted 7 lines
 6204 |         err = pci_request_region(pci_dev, 0, res_name);
      |               ^~~~~~~~~~~~~~~~~~
      |               pci_request_regions
Fixes 1316e0af2dc0 ("platform: mellanox: mlx-platform: Introduce ACPI init flow")

Thank you for your patch-series, I've applied the series to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

Quoted 18 lines
---
 drivers/platform/x86/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/platform/x86/Kconfig +1 -2
index a43db6731f34..2a1070543391 100644
@@ -965,8 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
 
 config MLX_PLATFORM
 	tristate "Mellanox Technologies platform support"
-	depends on ACPI
-	depends on I2C
+	depends on ACPI && I2C && PCI
 	select REGMAP
 	help
 	  This option enables system support for the Mellanox Technologies