Skip to contentSkip to conversation

perf vendor events intel: Fix modifier in tma_info_system_mem_parallel_reads

PATCH Applied Ian Rogers 2 participants 2 messages Aug 30, 2023 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf vendor events intel: Fix modifier in tma_info_system_mem_parallel_reads

The metric is using the wrong format encoding. This fix is in the converter script PR: https://github.com/intel/perfmon/pull/101

---
 tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json +1 -1
index 94cb38540b5a..2795a404bb58 100644
@@ -923,7 +923,7 @@
     },
     {
         "BriefDescription": "Average number of parallel data read requests to external memory",
-        "MetricExpr": "UNC_ARB_TRK_OCCUPANCY.DATA_READ / UNC_ARB_TRK_OCCUPANCY.DATA_READ@thresh\\=1@",
+        "MetricExpr": "UNC_ARB_TRK_OCCUPANCY.DATA_READ / UNC_ARB_TRK_OCCUPANCY.DATA_READ@cmask\\=1@",
         "MetricGroup": "Mem;MemoryBW;SoC",
         "MetricName": "tma_info_system_mem_parallel_reads",
         "PublicDescription": "Average number of parallel data read requests to external memory. Accounts for demand loads and L1/L2 prefetches"
Signature · 1 line
2.42.0.rc2.253.gd59a3bf2b4-goog
maintainer Applied
#1 lore raw

Em Wed, Aug 30, 2023 at 10:55:43AM -0700, Ian Rogers escreveu:

Quoted 2 lines

The metric is using the wrong format encoding. This fix is in the converter script PR: https://github.com/intel/perfmon/pull/101

Thanks, applied.

- Arnaldo

Quoted 21 lines
---
 tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/pmu-events/arch/x86/skylake/skl-metrics.json +1 -1
index 94cb38540b5a..2795a404bb58 100644
@@ -923,7 +923,7 @@
     },
     {
         "BriefDescription": "Average number of parallel data read requests to external memory",
-        "MetricExpr": "UNC_ARB_TRK_OCCUPANCY.DATA_READ / UNC_ARB_TRK_OCCUPANCY.DATA_READ@thresh\\=1@",
+        "MetricExpr": "UNC_ARB_TRK_OCCUPANCY.DATA_READ / UNC_ARB_TRK_OCCUPANCY.DATA_READ@cmask\\=1@",
         "MetricGroup": "Mem;MemoryBW;SoC",
         "MetricName": "tma_info_system_mem_parallel_reads",
         "PublicDescription": "Average number of parallel data read requests to external memory. Accounts for demand loads and L1/L2 prefetches"
Signature · 1 line
2.42.0.rc2.253.gd59a3bf2b4-goog
Signature · 1 line
- Arnaldo