Skip to contentSkip to conversation

scsi: imm: Add a module parameter for the transfer mode

PATCH Applied Alex Henrie 2 participants 3 messages Aug 31, 2023 – Sep 22, 2023 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: imm: Add a module parameter for the transfer mode

Fix in the imm driver the same problem that was fixed in the ppa driver by commit 68a4f84a17c1 ("scsi: ppa: Add a module parameter for the transfer mode").

Tested and confirmed working with an Iomega Z250P zip drive and a StarTech PEX1P2 AX99100 PCIe parallel port.

---
 drivers/scsi/Kconfig | 15 ----------
 drivers/scsi/imm.c   | 70 +++++++++++++++++++++++---------------------
 drivers/scsi/imm.h   |  4 ---
 3 files changed, 37 insertions(+), 52 deletions(-)
drivers/scsi/Kconfig +0 -15
index 695a57d894cd..addac7fbe37b 100644
@@ -834,21 +834,6 @@ config SCSI_IMM
 	  To compile this driver as a module, choose M here: the
 	  module will be called imm.
 
-config SCSI_IZIP_EPP16
-	bool "ppa/imm option - Use slow (but safe) EPP-16"
-	depends on SCSI_IMM
-	help
-	  EPP (Enhanced Parallel Port) is a standard for parallel ports which
-	  allows them to act as expansion buses that can handle up to 64
-	  peripheral devices.
-
-	  Some parallel port chipsets are slower than their motherboard, and
-	  so we have to control the state of the chipset's FIFO queue every
-	  now and then to avoid data loss. This will be done if you say Y
-	  here.
-
-	  Generally, saying Y is the safe option and slows things down a bit.
-
 config SCSI_IZIP_SLOW_CTR
 	bool "ppa/imm option - Assume slow parport control register"
 	depends on SCSI_PPA || SCSI_IMM
drivers/scsi/imm.c +37 -33

147 lines not on this page · raw message

drivers/scsi/imm.h +0 -4
index 411cf94af5b0..398fa5b15181 100644
@@ -100,11 +100,7 @@ static char *IMM_MODE_STRING[] =
 	[IMM_PS2]	 = "PS/2",
 	[IMM_EPP_8]	 = "EPP 8 bit",
 	[IMM_EPP_16]	 = "EPP 16 bit",
-#ifdef CONFIG_SCSI_IZIP_EPP16
-	[IMM_EPP_32]	 = "EPP 16 bit",
-#else
 	[IMM_EPP_32]	 = "EPP 32 bit",
-#endif
 	[IMM_UNKNOWN]	 = "Unknown",
 };
 
Signature · 1 line
2.42.0
#1 lore raw

Alex,

Quoted 6 lines

Fix in the imm driver the same problem that was fixed in the ppa driver by commit 68a4f84a17c1 ("scsi: ppa: Add a module parameter for the transfer mode").

Tested and confirmed working with an Iomega Z250P zip drive and a StarTech PEX1P2 AX99100 PCIe parallel port.

Applied to 6.7/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Alex Henrie
Quoted 8 lines · Alex Henrie

Fix in the imm driver the same problem that was fixed in the ppa driver by commit 68a4f84a17c1 ("scsi: ppa: Add a module parameter for the transfer mode").

Tested and confirmed working with an Iomega Z250P zip drive and a StarTech PEX1P2 AX99100 PCIe parallel port.

[...]

Applied to 6.7/scsi-queue, thanks!

[1/1] scsi: imm: Add a module parameter for the transfer mode

      https://git.kernel.org/mkp/scsi/c/b0597fd5a953
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering