gpiolib: remove unnecessary extern specifiers from the driver header
PATCH 1/1 gpiolib: remove unnecessary extern specifiers from the driver header
From: Bartosz Golaszewski <[email protected]>
'extern' doesn't do anything for function declarations. Remove it.
Signed-off-by Bartosz Golaszewski <[email protected]>
--- include/linux/gpio/driver.h | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-)
include/linux/gpio/driver.h +10 -11
@@ -529,8 +529,7 @@ struct gpio_chip {#endif /* CONFIG_OF_GPIO */ }; -extern const char *gpiochip_is_requested (struct gpio_chip *gc, -unsigned int offset); +const char *gpiochip_is_requested (struct gpio_chip *gc,unsigned int offset);/** * for_each_requested_gpio_in_range - iterates over requested GPIOs in a given range
@@ -549,9 +548,9 @@ extern const char *gpiochip_is_requested(struct gpio_chip *gc,for_each_requested_gpio_in_range (chip, i,0 , chip->ngpio, label)/* add/remove chips */ -extern int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, -struct lock_class_key *lock_key, -struct lock_class_key *request_key); +int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, + struct lock_class_key *lock_key, + struct lock_class_key *request_key);/** * gpiochip_add_data() - register a gpio_chip
@@ -599,13 +598,13 @@ static inline int gpiochip_add(struct gpio_chip *gc) {return gpiochip_add_data (gc,NULL ); } -extern void gpiochip_remove (struct gpio_chip *gc); -extern int devm_gpiochip_add_data_with_key (struct device *dev,struct gpio_chip *gc,void *data, -struct lock_class_key *lock_key, -struct lock_class_key *request_key); +void gpiochip_remove (struct gpio_chip *gc); +int devm_gpiochip_add_data_with_key (struct device *dev,struct gpio_chip *gc, +void *data,struct lock_class_key *lock_key, +struct lock_class_key *request_key); -extern struct gpio_chip *gpiochip_find (void *data, -int (*match)(struct gpio_chip *gc,void *data)); +struct gpio_chip *gpiochip_find (void *data, +int (*match)(struct gpio_chip *gc,void *data));bool gpiochip_line_is_irq (struct gpio_chip *gc,unsigned int offset);int gpiochip_reqres_irq (struct gpio_chip *gc,unsigned int offset);
Signature · 1 line
2.39.2
Quoted 3 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
'extern' doesn't do anything for function declarations. Remove it.
Reviewed-by Andy Shevchenko <[email protected]>
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 5 lines · Bartosz Golaszewski
From: Bartosz Golaszewski <[email protected]>
'extern' doesn't do anything for function declarations. Remove it.
Signed-off-by Bartosz Golaszewski <[email protected]>
Right I guess it should never be in headers, the one place where is makes sense is if you're suddenly exporting something in a C file, such as to expose it to assembly.
Reviewed-by Linus Walleij <[email protected]>
Yours,
Linus Walleij