Skip to contentSkip to conversation

staging: vme_user: Add missing '*' in multiline comments

PATCH In review Jonathan Bergh 2 participants 3 messages Sep 3, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vme_user: Add missing '*' in multiline comments

This patch resolves a warning reported by checkpatch where multiline block comments should use '*' on intermediate lines in order to adhere to the Linux kernel coding-style guidelines.

---
 drivers/staging/vme_user/vme_fake.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vme_user/vme_fake.c +2 -2
index 7c53a8a7b79b..90aaf650524d 100644
@@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size,
 {
 	kfree(vaddr);
 /*
-	dma_free_coherent(parent, size, vaddr, dma);
-*/
+ *	dma_free_coherent(parent, size, vaddr, dma);
+ */
 }
 
 /*
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 14 lines · Jonathan Bergh

This patch resolves a warning reported by checkpatch where multiline block comments should use '*' on intermediate lines in order to adhere to the Linux kernel coding-style guidelines.

---
 drivers/staging/vme_user/vme_fake.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vme_user/vme_fake.c +0 -0
index 7c53a8a7b79b..90aaf650524d 100644

drivers/staging/vme_user/vme_fake.c static void fake_free_consistent(struct device *parent, size_t size, · line 1014

Quoted 7 lines
drivers/staging/vme_user/vme_fake.c +2 -2
@@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size,
 {
 	kfree(vaddr);
 /*
-	dma_free_coherent(parent, size, vaddr, dma);
-*/
+ *	dma_free_coherent(parent, size, vaddr, dma);
+ */

As this code isn't being used, why not just delete it instead?

thanks,

greg k-h

#2 lore raw

Yes ... that would be better.

Quoted 29 lines · Greg KH
Quoted 14 lines · Jonathan Bergh

This patch resolves a warning reported by checkpatch where multiline block comments should use '*' on intermediate lines in order to adhere to the Linux kernel coding-style guidelines.

---
 drivers/staging/vme_user/vme_fake.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vme_user/vme_fake.c +0 -0
index 7c53a8a7b79b..90aaf650524d 100644

drivers/staging/vme_user/vme_fake.c static void fake_free_consistent(struct device *parent, size_t size, · line 1014

Quoted 7 lines
drivers/staging/vme_user/vme_fake.c +2 -2
@@ -1010,8 +1010,8 @@ static void fake_free_consistent(struct device *parent, size_t size,
 {
      kfree(vaddr);
 /*
-     dma_free_coherent(parent, size, vaddr, dma);
-*/
+ *   dma_free_coherent(parent, size, vaddr, dma);
+ */

As this code isn't being used, why not just delete it instead?

thanks,

greg k-h