spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative
PATCH v2 1/1 spi: spi-mpc512x-psc: Fix an unsigned comparison that can never be negative
From: Rajeshwar R Shinde <[email protected]>
In struct mpc512x_psc_spi, the variable 'irq' is declared as an unsigned int. The comparison of variable 'irq' with signed int operand is incorrect. Also, the return value from the call to platform_get_irq(pdev,0) is int and it is assigned to an unsigned int variable 'irq', thus redeclaring the type of variable 'irq' to signed int.
This fixes warning such as:
drivers/spi/spi-mpc512x-psc.c:493:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0
Signed-off-by Rajeshwar R Shinde <[email protected]>
---v1->v2
changed the commit message
--- drivers/spi/spi-mpc512x-psc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-mpc512x-psc.c +1 -1
@@ -53,7 +53,7 @@ struct mpc512x_psc_spi {int type;void __iomem *psc;struct mpc512x_psc_fifo __iomem *fifo; -unsigned int irq; +int irq;u8 bits_per_word;u32 mclk_rate;
Signature · 1 line
2.25.1