Skip to contentSkip to conversation

tcl: Add a way to skip ptests

PATCH New Khem Raj 1 participant 1 message Sep 5, 2023

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 tcl: Add a way to skip ptests

Some tests hardcode assumptions on locales, which may not be present in musl systems e.g., therefore add a way to skip such tests using -skip option.

Skip unixInit-3* test on musl

---
 meta/recipes-devtools/tcltk/tcl/run-ptest | 4 ++--
 meta/recipes-devtools/tcltk/tcl_8.6.13.bb | 5 +++++
 2 files changed, 7 insertions(+), 2 deletions(-)
meta/recipes-devtools/tcltk/tcl/run-ptest +2 -2
index a62b7030821..5b9127784ed 100644
@@ -3,9 +3,9 @@
 # clock.test needs a timezone to be set
 export TZ="Europe/London"
 export TCL_LIBRARY=library
-
+SKIPPED_TESTS=
 for i in `ls tests/*.test | awk -F/ '{print $2}'`; do
-    ./tcltest tests/all.tcl -file $i >$i.log 2>&1
+    ./tcltest tests/all.tcl -file $i -skip "$SKIPPED_TESTS" >$i.log 2>&1
     grep -q -F -e "Files with failing tests:" -e "Test files exiting with errors:" $i.log
     if [ $? -eq 0 ]; then
         echo "FAIL: $i"
meta/recipes-devtools/tcltk/tcl_8.6.13.bb +5 -0
index 9eb924b0da8..b33a78e147f 100644
@@ -86,6 +86,11 @@ do_install_ptest() {
 	cp -r ${S}/tests ${D}${PTEST_PATH}
 }
 
+do_install_ptest:append:libc-musl () {
+	# Assumes locales other than provided by musl-locales
+	sed -i -e 's|SKIPPED_TESTS=|SKIPPED_TESTS="unixInit-3*"|' ${D}${PTEST_PATH}/run-ptest
+}
+
 # Fix some paths that might be used by Tcl extensions
 BINCONFIG_GLOB = "*Config.sh"
 
Signature · 1 line
2.42.0