Skip to contentSkip to conversation

glib-2.0: explicitly enable strlcpy()

PATCH In review [email protected] 2 participants 4 messages Sep 6, 2023 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 glib-2.0: explicitly enable strlcpy()

From: Ross Burton <[email protected]>

We have glibc 2.38 which added strlcpy(), so enable the use of it explicitly in the Meson cross file for when the target doesn't support qemu-usermode (which will result in the default of not using it).

---
 meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc +1 -0
index c4648f58c78..3049e5116ec 100644
@@ -3,3 +3,4 @@ have_c99_vsnprintf = true
 have_c99_snprintf = true
 have_unix98_printf = true
 va_val_copy = true
+have_strlcpy = true
Signature · 1 line
2.34.1
#1 lore raw
Quoted 6 lines · Ross Burton

From: Ross Burton <[email protected]>

We have glibc 2.38 which added strlcpy(), so enable the use of it explicitly in the Meson cross file for when the target doesn't support qemu-usermode (which will result in the default of not using it).

will this be effective for non-target variants too ? In that case we may not have
glibc 2.38 on all distros yet.

Quoted 27 lines
---
 meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/glib-2.0/glib-2.0/meson.cross.d/common-glibc +1 -1
index c4648f58c78..3049e5116ec 100644
@@ -3,3 +3,4 @@ have_c99_vsnprintf = true
 have_c99_snprintf = true
 have_unix98_printf = true
 va_val_copy = true
+have_strlcpy = true
--

2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#187319): https://lists.openembedded.org/g/openembedded-core/message/187319
Mute This Topic: https://lists.openembedded.org/mt/101194848/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 5 lines · Khem Raj
Quoted 3 lines · Ross Burton

From: Ross Burton <[email protected]>

Quoted 7 lines
Quoted 3 lines

We have glibc 2.38 which added strlcpy(), so enable the use of it explicitly in the Meson cross file for when the target doesn't support qemu-usermode (which will result in the default of not using it).

will this be effective for non-target variants too ? In that case we may not have
glibc 2.38 on all distros yet.

The extra cross file logic is not used in native builds.

Ross

#3 lore raw
Quoted 10 lines · Ross Burton
Quoted 9 lines · Khem Raj
Quoted 6 lines · Ross Burton

From: Ross Burton <[email protected]>

We have glibc 2.38 which added strlcpy(), so enable the use of it explicitly in the Meson cross file for when the target doesn't support qemu-usermode (which will result in the default of not using it).

Quoted 5 lines
Quoted 3 lines

will this be effective for non-target variants too ? In that case we may not have
glibc 2.38 on all distros yet.

The extra cross file logic is not used in native builds.

Superb and I checked that this is already set for musl cross file so all good

Quoted 2 lines

Ross