Skip to contentSkip to conversation

arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property

PATCH Applied Fabio Estevam 3 participants 5 messages Sep 8, 2023 – Sep 25, 2023

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 arm64: dts: imx8-apalis-ixora: Remove invalid ngpios property

From: Fabio Estevam <[email protected]>

Per fsl-imx-gpio.yaml, 'ngpios' is not a valid property.

Remove it to fix the following schema warning:

imx8qm-apalis-v1.1-ixora-v1.2.dtb: gpio@5d0d0000: 'ngpios' does not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 1 -
 arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 1 -
 2 files changed, 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi +0 -1
index c6d51f116298..5438923a905c 100644
@@ -165,7 +165,6 @@ &lsio_gpio5 {
 			  "gpio5-24", "UART24-FORCEOFF", "gpio5-26",
 			  "LED-4-GREEN", "gpio5-28", "LED-4-RED", "gpio5-30",
 			  "gpio5-31";
-	ngpios = <32>;
 };
 
 /* Apalis PWM3, MXM3 pin 6 */
arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi +0 -1
index 40067ab8aa74..72136c436a70 100644
@@ -212,7 +212,6 @@ &lsio_gpio5 {
 			  "gpio5-24", "UART24-FORCEOFF", "gpio5-26",
 			  "LED-4-GREEN", "gpio5-28", "LED-4-RED", "gpio5-30",
 			  "gpio5-31";
-	ngpios = <32>;
 };
 
 /* Apalis PWM3, MXM3 pin 6 */
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author reviewer
#1 lore raw

PATCH 2/2 arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties

From: Fabio Estevam <[email protected]>

Per fsl-imx-gpio.yaml, 'pad-wakeup' and 'pad-wakeup-num' are not valid properties/

Remove them to fix the following schema warning:

imx8qm-apalis-ixora-v1.1.dtb: gpio@5d0a0000: 'pad-wakeup', 'pad-wakeup-num' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 9 ---------
 1 file changed, 9 deletions(-)
arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi +0 -9
index 9b1b522517f8..7ce342007836 100644
@@ -503,15 +503,6 @@ &lsio_gpio2 {
 			  "MXM3_185",
 			  "MXM3_187";
 
-	/*
-	 * Add GPIO2_20 as a wakeup source:
-	 * Pin:  101	SC_P_SPI3_CS0 (MXM3_37/WAKE1_MICO)
-	 * Type: 5	SC_PAD_WAKEUP_FALL_EDGE
-	 * Line: 20
-	 */
-	pad-wakeup = <IMX8QM_SPI3_CS0 5 20>;
-	pad-wakeup-num = <1>;
-
 	pcie-wifi-hog {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_pcie_wifi_refclk>;
Signature · 7 lines
2.34.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: imx8-apalis-v1.1: Remove invalid GPIO properties

Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per fsl-imx-gpio.yaml, 'pad-wakeup' and 'pad-wakeup-num' are not valid properties/

Quoted 7 lines

Remove them to fix the following schema warning:

imx8qm-apalis-ixora-v1.1.dtb: gpio@5d0a0000: 'pad-wakeup', 'pad-wakeup-num' do not match any of the regexes:
'^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#

Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Marcel Ziswiler <[email protected]>
Quoted 17 lines

---
 arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi | 9 ---------

 1 file changed, 9 deletions(-)
arch/arm64/boot/dts/freescale/imx8-apalis- renamed from arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi +0 -0

v1.1.dtsi
index 9b1b522517f8..7ce342007836 100644

arch/arm64/boot/dts/freescale/imx8-apalis-v1.1.dtsi +0 -0
@@ -503,15 +503,6 @@ &lsio_gpio2 {
                           "MXM3_185",
                           "MXM3_187";


-       /*
-        * Add GPIO2_20 as a wakeup source:
-        * Pin:  101    SC_P_SPI3_CS0 (MXM3_37/WAKE1_MICO) -        * Type: 5      SC_PAD_WAKEUP_FALL_EDGE

Quoted 8 lines

-        * Line: 20
-        */
-       pad-wakeup = <IMX8QM_SPI3_CS0 5 20>;
-       pad-wakeup-num = <1>;
-
        pcie-wifi-hog {
                pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pcie_wifi_refclk>;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v1 1/2
#3 lore raw
In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per fsl-imx-gpio.yaml, 'ngpios' is not a valid property.

Remove it to fix the following schema warning:

imx8qm-apalis-v1.1-ixora-v1.2.dtb: gpio@5d0d0000: 'ngpios' does not match any of the regexes: '^(hog-[0- 9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#

Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Marcel Ziswiler <[email protected]>
Quoted 29 lines

---
 arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi | 1 - arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi | 1 -

 2 files changed, 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8- renamed from arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi +0 -0

apalis-ixora-v1.1.dtsi
index c6d51f116298..5438923a905c 100644

arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.1.dtsi +0 -1
@@ -165,7 +165,6 @@ &lsio_gpio5 {
                           "gpio5-24", "UART24-FORCEOFF", "gpio5-26",
                           "LED-4-GREEN", "gpio5-28", "LED-4-RED", "gpio5-30",
                           "gpio5-31";
-       ngpios = <32>;
  };


 /* Apalis PWM3, MXM3 pin 6 */

arch/arm64/boot/dts/freescale/imx8- renamed from arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi +0 -0

apalis-ixora-v1.2.dtsi
index 40067ab8aa74..72136c436a70 100644

arch/arm64/boot/dts/freescale/imx8-apalis-ixora-v1.2.dtsi +0 -1
@@ -212,7 +212,6 @@ &lsio_gpio5 {
                           "gpio5-24", "UART24-FORCEOFF", "gpio5-26",
                           "LED-4-GREEN", "gpio5-28", "LED-4-RED", "gpio5-30",
                           "gpio5-31";
-       ngpios = <32>;
  };
Quoted 2 lines


 /* Apalis PWM3, MXM3 pin 6 */

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Applied
#4 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Per fsl-imx-gpio.yaml, 'ngpios' is not a valid property.

Remove it to fix the following schema warning:

imx8qm-apalis-v1.1-ixora-v1.2.dtb: gpio@5d0d0000: 'ngpios' does not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/gpio/fsl-imx-gpio.yaml#

Signed-off-by Fabio Estevam <[email protected]>

Applied both, thanks!

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel