Skip to contentSkip to conversation

arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells

PATCH Applied Fabio Estevam 3 participants 3 messages Sep 9, 2023 – Sep 25, 2023

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 arm64: dts: imx8mp-debix-som-a-bmb: Fix EEPROM #size-cells

From: Fabio Estevam <[email protected]>

The mac-address is passed as a subnode of the eeprom and its 'reg' property describe a range of addresses in the eeprom.

Therefore, #size-cells should be set to 1 instead of 0.

This fixes the following schema warnings:

imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: #size-cells:0:0: 1 was expected
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@0:reg: [[0], [12]] is too long
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@c:reg: [[12], [12]] is too long
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mac-address@0', 'mac-address@c' were unexpected)
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts +1 -1
index 0b0c95432bdc..0afd90224a59 100644
@@ -220,7 +220,7 @@ eeprom@52 {
 		reg = <0x52>;
 		pagesize = <16>;
 		#address-cells = <1>;
-		#size-cells = <0>;
+		#size-cells = <1>;
 
 		/* MACs stored in ASCII */
 		ethmac1: mac-address@0 {
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Fabio,

thanks for the fix.

Quoted 18 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The mac-address is passed as a subnode of the eeprom and its 'reg' property describe a range of addresses in the eeprom.

Therefore, #size-cells should be set to 1 instead of 0.

This fixes the following schema warnings:

imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: #size-cells:0:0: 1 was expected
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@0:reg: [[0], [12]] is too long
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@c:reg: [[12], [12]] is too long
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mac-address@0', 'mac-address@c' were unexpected)
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#

Quoted 1 line
Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Marco Felsch <[email protected]>
Applied
#2 lore raw
In reply to Fabio Estevam
Quoted 18 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The mac-address is passed as a subnode of the eeprom and its 'reg' property describe a range of addresses in the eeprom.

Therefore, #size-cells should be set to 1 instead of 0.

This fixes the following schema warnings:

imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: #size-cells:0:0: 1 was expected
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@0:reg: [[0], [12]] is too long
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: mac-address@c:reg: [[12], [12]] is too long
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
imx8mp-debix-som-a-bmb-08.dtb: eeprom@52: Unevaluated properties are not allowed ('#address-cells', '#size-cells', 'mac-address@0', 'mac-address@c' were unexpected)
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#

Quoted 1 line
Signed-off-by Fabio Estevam <[email protected]>

Applied, thanks!