staging: vme_user: Fix block comments where '*' on each line should be aligned
PATCH 2/2 staging: vme_user: Fix block comments where '*' on each line should be aligned
Fixed checkpatch warnings where lines with '*' in block comments should be aligned and were not as well as incorrect tab spacings at the start of comment lines.
--- drivers/staging/vme_user/vme_tsi148.h | 140 +++++++++++++------------- 1 file changed, 70 insertions(+), 70 deletions(-)
drivers/staging/vme_user/vme_tsi148.h +70 -70
@@ -251,28 +251,28 @@ static const int TSI148_LCSR_VIACK[8] = { 0, TSI148_LCSR_VIACK1,*/ #define TSI148_LCSR_VMEFL 0x250 -/* -* VME exception. -* offset 260 +/* +* VME exception. +* offset 0x260 */ #define TSI148_LCSR_VEAU 0x260#define TSI148_LCSR_VEAL 0x264#define TSI148_LCSR_VEAT 0x268 -/* -* PCI error -* offset 270 -*/ +/* +* PCI error +* offset 0x270 +*/ #define TSI148_LCSR_EDPAU 0x270#define TSI148_LCSR_EDPAL 0x274#define TSI148_LCSR_EDPXA 0x278#define TSI148_LCSR_EDPXS 0x27C#define TSI148_LCSR_EDPAT 0x280 -/* -* Inbound Translations -* offset 300 -*/ +/* +* Inbound Translations +* offset 0x300 +*/ #define TSI148_LCSR_IT0_ITSAU 0x300#define TSI148_LCSR_IT0_ITSAL 0x304#define TSI148_LCSR_IT0_ITEAU 0x308
@@ -359,53 +359,53 @@ static const int TSI148_LCSR_IT[8] = { TSI148_LCSR_IT0, TSI148_LCSR_IT1,#define TSI148_LCSR_OFFSET_ITOFL 0x14#define TSI148_LCSR_OFFSET_ITAT 0x18 -/* -* Inbound Translation GCSR -* offset 400 -*/ +/* +* Inbound Translation GCSR +* offset 0x400 +*/ #define TSI148_LCSR_GBAU 0x400#define TSI148_LCSR_GBAL 0x404#define TSI148_LCSR_GCSRAT 0x408 -/* -* Inbound Translation CRG -* offset 40C -*/ +/* +* Inbound Translation CRG +* offset 0x40C +*/ #define TSI148_LCSR_CBAU 0x40C#define TSI148_LCSR_CBAL 0x410#define TSI148_LCSR_CSRAT 0x414 -/* -* Inbound Translation CR/CSR -* CRG -* offset 418 -*/ +/* +* Inbound Translation CR/CSR +* CRG +* offset 0x418 +*/ #define TSI148_LCSR_CROU 0x418#define TSI148_LCSR_CROL 0x41C#define TSI148_LCSR_CRAT 0x420 -/* -* Inbound Translation Location Monitor -* offset 424 -*/ +/* +* Inbound Translation Location Monitor +* offset 0x424 +*/ #define TSI148_LCSR_LMBAU 0x424#define TSI148_LCSR_LMBAL 0x428#define TSI148_LCSR_LMAT 0x42C -/* -* VMEbus Interrupt Control. -* offset 430 -*/ +/* +* VMEbus Interrupt Control. +* offset 0x430 +*/ #define TSI148_LCSR_BCU 0x430#define TSI148_LCSR_BCL 0x434#define TSI148_LCSR_BPGTR 0x438#define TSI148_LCSR_BPCTR 0x43C#define TSI148_LCSR_VICR 0x440 -/* -* Local Bus Interrupt Control. -* offset 448 -*/ +/* +* Local Bus Interrupt Control. +* offset 0x448 +*/ #define TSI148_LCSR_INTEN 0x448#define TSI148_LCSR_INTEO 0x44C#define TSI148_LCSR_INTS 0x450
@@ -413,10 +413,10 @@ static const int TSI148_LCSR_IT[8] = { TSI148_LCSR_IT0, TSI148_LCSR_IT1,#define TSI148_LCSR_INTM1 0x458#define TSI148_LCSR_INTM2 0x45C -/* -* DMA Controllers -* offset 500 -*/ +/* +* DMA Controllers +* offset 0x500 +*/ #define TSI148_LCSR_DCTL0 0x500#define TSI148_LCSR_DSTA0 0x504#define TSI148_LCSR_DCSAU0 0x508
@@ -480,27 +480,27 @@ static const int TSI148_LCSR_DMA[TSI148_MAX_DMA] = { TSI148_LCSR_DMA0,#define TSI148_LCSR_OFFSET_DCNT 0x40#define TSI148_LCSR_OFFSET_DDBS 0x44 -/* -* GCSR Register Group -*/ +/* +* GCSR Register Group +*/ -/* -* GCSR CRG -* offset 00 600 - DEVI/VENI -* offset 04 604 - CTRL/GA/REVID -* offset 08 608 - Semaphore3/2/1/0 -* offset 0C 60C - Seamphore7/6/5/4 -*/ +/* +* GCSR CRG +* offset 0x00 0x600 - DEVI/VENI +* offset 0x04 0x604 - CTRL/GA/REVID +* offset 0x08 0x608 - Semaphore3/2/1/0 +* offset 0x0C 0x60C - Seamphore7/6/5/4 +*/ #define TSI148_GCSR_ID 0x600#define TSI148_GCSR_CSR 0x604#define TSI148_GCSR_SEMA0 0x608#define TSI148_GCSR_SEMA1 0x60C -/* -* Mail Box -* GCSR CRG -* offset 10 610 - Mailbox0 -*/ +/* +* Mail Box +* GCSR CRG +* offset 0x10 0x610 - Mailbox0 +*/ #define TSI148_GCSR_MBOX0 0x610#define TSI148_GCSR_MBOX1 0x614#define TSI148_GCSR_MBOX2 0x618
@@ -511,27 +511,27 @@ static const int TSI148_GCSR_MBOX[4] = { TSI148_GCSR_MBOX0,TSI148_GCSR_MBOX2 , TSI148_GCSR_MBOX3 }; -/* -* CR/CSR -*/ +/* +* CR/CSR +*/ -/* -* CR/CSR CRG -* offset 7FFF4 FF4 - CSRBCR -* offset 7FFF8 FF8 - CSRBSR -* offset 7FFFC FFC - CBAR -*/ +/* +* CR/CSR CRG +* offset 0x7FFF4 0xFF4 - CSRBCR +* offset 0x7FFF8 0xFF8 - CSRBSR +* offset 0x7FFFC 0xFFC - CBAR +*/ #define TSI148_CSRBCR 0xFF4#define TSI148_CSRBSR 0xFF8#define TSI148_CBAR 0xFFC -/* -* TSI148 Register Bit Definitions -*/ +/* +* TSI148 Register Bit Definitions +*/ -/* -* PFCS Register Set -*/ +/* +* PFCS Register Set +*/ #define TSI148_PCFS_CMMD_SERR BIT(8)/* SERR_L out pin ssys err */ #define TSI148_PCFS_CMMD_PERR BIT(6)/* PERR_L out pin parity */ #define TSI148_PCFS_CMMD_MSTR BIT(2)/* PCI bus master */
Signature · 1 line
2.34.1
Greg KH
maintainerQuoted 14 lines · Jonathan Bergh
Fixed checkpatch warnings where lines with '*' in block comments should be aligned and were not as well as incorrect tab spacings at the start of comment lines.
Signed-off-by Jonathan Bergh <[email protected]>--- drivers/staging/vme_user/vme_tsi148.h | 140 +++++++++++++------------- 1 file changed, 70 insertions(+), 70 deletions(-)drivers/staging/vme_user/vme_tsi148.h +0
-0
drivers/staging/vme_user/vme_tsi148.h static const int TSI148_LCSR_VIACK[8] = { 0, TSI148_LCSR_VIACK1, · line 256
Quoted 9 lines
drivers/staging/vme_user/vme_tsi148.h +3
-3@@ -251,28 +251,28 @@ static const int TSI148_LCSR_VIACK[8] = { 0, TSI148_LCSR_VIACK1,*/ #define TSI148_LCSR_VMEFL 0x250 -/* -* VME exception. -* offset 260 +/* +* VME exception. +* offset 0x260
This change is not documented :(
Also I have two 2/2 patches, yet they are both different :(
Please fix this up and send a whole new series, properly versioned, as-is, I have no idea what to do here.
thanks,
greg k-h
Quoted 27 lines · Greg KH
Quoted 14 lines · Jonathan Bergh
Fixed checkpatch warnings where lines with '*' in block comments should be aligned and were not as well as incorrect tab spacings at the start of comment lines.
Signed-off-by Jonathan Bergh <[email protected]>--- drivers/staging/vme_user/vme_tsi148.h | 140 +++++++++++++------------- 1 file changed, 70 insertions(+), 70 deletions(-)drivers/staging/vme_user/vme_tsi148.h +0
-0drivers/staging/vme_user/vme_tsi148.h static const int TSI148_LCSR_VIACK[8] = { 0, TSI148_LCSR_VIACK1, · line 256
Quoted 9 lines
drivers/staging/vme_user/vme_tsi148.h +3
-3@@ -251,28 +251,28 @@ static const int TSI148_LCSR_VIACK[8] = { 0, TSI148_LCSR_VIACK1,*/ #define TSI148_LCSR_VMEFL 0x250 -/* -* VME exception. -* offset 260 +/* +* VME exception. +* offset 0x260 This change is not documented :(
Quoted 4 lines
Also I have two 2/2 patches, yet they are both different :(
Please fix this up and send a whole new series, properly versioned, as-is, I have no idea what to do here.
Great, thanks for your help with these.