Skip to contentSkip to conversation

Support AMD Pensando Elba SoC

PATCH In review Brad Larson 4 participants 15 messages Sep 13, 2023 – Sep 27, 2023

Subsystems (6)
lore
Share & tools
lore

Brad Larson

author maintainer
#0 lore raw

v16 cover Support AMD Pensando Elba SoC

This series enables support for AMD Pensando Elba SoC based platforms.

The Elba SoC has the following features:
- Sixteen ARM64 A72 cores
- Dual DDR 4/5 memory controllers
- 32 lanes of PCIe Gen3/4 to the Host
- Network interfaces: Dual 200GE, Quad 100GE, 50GE, 25GE, 10GE and also a single 1GE management port.
- Storage/crypto offloads and 144 programmable P4 cores.
- QSPI and EMMC for SoC storage
- Two SPI interfaces for peripheral management
- I2C bus for platform management

== V16 changes ==
Rebase to 6.6.0-rc1

== V15 changes ==
Rebase to 6.5.0-rc1 and drop these patches (merged into 6.4.0)
- v14-0002-dt-bindings-spi-cdns-Add-compatible-for-AMD-Pens.patch
- v14-0007-spi-cadence-quadspi-Add-compatible-for-AMD-Pensa.patch

v14-0006-arm64-dts-Add-AMD-Pensando-Elba-SoC-support.patch
- The first cell in the cpu reg property is always zero. Change address-cells to <1> and dropped the leading zero from all cpu* reg<>
- Added read-only and spare partitions to flash0

v14-0008-soc-amd-Add-support-for-AMD-Pensando-SoC-Control.patch
- Drop custom ioctl and use existing miscdevice interface.
- Makefile change to only compile for ARCH_PENSANDO

== V14 changes ==
Updated email list using get_maintainer.pl

Rebase to 6.4.0-rc1 and drop these patches (merged into 6.3.0)
- v13-0002-dt-bindings-mmc-cdns-Add-AMD-Pensando-Elba-SoC.patch
- v13-0004-dt-bindings-spi-dw-Add-AMD-Pensando-Elba-SoC-SPI.patch
- v13-0010-spi-dw-Add-support-for-AMD-Pensando-Elba-SoC.patch
- v13-0011-mmc-sdhci-cadence-Enable-device-specific-overrid.patch
- v13-0012-mmc-sdhci-cadence-Support-device-specific-init-d.patch
- v13-0013-mmc-sdhci-cadence-Add-AMD-Pensando-Elba-SoC-supp.patch
- v13-0014-mmc-sdhci-cadence-Support-mmc-hardware-reset.patch

v14-0003-dt-bindings-soc-amd-amd-pensando-elba-ctrl-Add-P.patch
- Change GPL-2.0-only or BSD-2-Clause to GPL-2.0-only OR BSD-2-Clause

v14-0006-arm64-dts-Add-AMD-Pensando-Elba-SoC-support.patch
- Fix dtbs_check l2-cache* property issue by adding required cache-level and cache-unified properties
- Observed the issue after updating dtschema from 2023.1 to 2023.4 and yamllint from 1.26.3 to 1.30.0

v14-0008-soc-amd-Add-support-for-AMD-Pensando-SoC-Control.patch
- Save 8 bytes of code size by swapping spi_device and reset_controller_dev in penctrl_device
- Code simplification and clarity from review inputs
- Set penctrl_spi_driver.driver.name to match compatible pensando-elba-ctrl
- Remove unused include in amd-pensando-ctrl.h
- Fix compile error, class_create() API changed

== V13 changes == v13-0013-mmc-sdhci-cadence-Add-AMD-Pensando-Elba-SoC-supp
- Use GENMASK(7, 3) in elba_priv_writel() to set all byte enables
- Add a variable 'shift' with GENMASK(1, 0) in elba_write_w() and elba_write_b() to set the byte enable variable.

v13-0015-soc-amd-Add-support-for-AMD-Pensando-SoC-Control
- Update include list in pensando-ctrl.c
- Change variable spi_dev to spi throughout
- Removed unneeded variable initialization, simplification of error checks, remove extra castings, and use dev_err_probe()
- Sort the includes in amd-pensando-ctrl.h
- Updates to cleanup if there is an error in penctrl_spi_probe()

== V12 changes == v12-0004-dt-bindings-spi-dw-Add-AMD-Pensando-Elba-SoC-SPI
- Correct property amd,pensando-elba-syscon description

v12-0010-spi-dw-Add-support-for-AMD-Pensando-Elba-SoC
- Add a newline in function dw_spi_elba_init()

v12-0015-soc-amd-Add-support-for-AMD-Pensando-SoC-Control
- Fix gcc-12.1.0 warning:

== V11 changes == v11-0002-dt-bindings-mmc-cdns-Add-AMD-Pensando-Elba-SoC
- Remove resets description and reset-names
- Add descriptions for amd,pensando-elba-sd4hc reg items

v11-0003-dt-bindings-spi-cdns-Add-compatible-for-AMD-Pens
- Removed redundant if/then for amd,pensando-elba-qspi

v11-0005-dt-bindings-soc-amd-amd-pensando-elba-ctrl-Add-P
- Fixed the compatible which should have stayed as 'amd,pensando-elba-ctrl', the commit message, and the filename.
- Reference spi-peripheral-props
- Delete spi-max-frequency
- Remove num-cs from example

v11-0008-arm64-dts-Add-AMD-Pensando-Elba-SoC-support
- Delete reset-names
- Fix spi0 compatible to be specific 'amd,pensando-elba-ctrl'

v11-0010-spi-dw-Add-support-for-AMD-Pensando-Elba-SoC
- Simplify dw_spi_elb_init by using syscon_regmap_lookup_by_phandle()

v11-0013-mmc-sdhci-cadence-Add-AMD-Pensando-Elba-SoC-supp
- Remove elba-drv_init() call to platform_get_resource() since that check is done inside devm_platform_ioremap_resource()
- Move spin_lock_init() before error check
- Remove extra parentheses

v11-0015-soc-amd-Add-support-for-AMD-Pensando-SoC-Control
- Fix the compatible to be specific 'amd,pensando-elba-ctrl'
- Cast arguments flagged with a gcc-12.1.0 warning:

== V10 changes ==
Binding property amd,pensando-elba-syscon was merged in 6.2

v10-0002-dt-bindings-mmc-cdns-Add-AMD-Pensando-Elba-SoC
- Move reset-names property definition next to existing resets prop
- Move allOf to the bottom and set resets/reset-names required only for pensando
- Fix reg maxItems for existing, must be 1

v10-0003-dt-bindings-spi-cdns-Add-compatible-for-AMD-Pens
- Fix cdns,fifo-depth, only amd,pensando-elba-qspi is 1024 bytes

v10-0004-dt-bindings-spi-dw-Add-AMD-Pensando-Elba-SoC-SPI
- Move definition of amd,pensando-elba-syscon into properties with a better description
- Add amd,pensando-elba-syscon: false for non elba designs

v10-0005-dt-bindings-soc-amd-amd-pensando-elbasr-Add-AMD-
- Property renamed to amd,pensando-ctrl
- Driver is renamed and moved to soc/drivers/amd affecting binding
- Delete cs property, driver handles device node creation from parent num-cs fixing schema reg error in a different way

v10-0010-spi-dw-Add-support-for-AMD-Pensando-Elba-SoC
- Delete struct dw_spi_elba, use regmap directly in priv

v10-0011-mmc-sdhci-cadence-Enable-device-specific-overrid
- The 1st patch adding private writel() is unchanged. The 2nd patch is split into two patches to provide for device specific init in one patch with no effect on existing designs. Then add the pensando support into the next patch. Then the 4th patch is mmc hardware reset support which is unchanged.

v10-0012-mmc-sdhci-cadence-Support-device-specific-init-i
- New patch to provide for platform specific init() with no change to existing designs.

v10-0013-mmc-sdhci-cadence-Add-AMD-Pensando-Elba-SoC-supp
- Add Elba specific support into this 3rd patch. This builds on the private writel() enabled in patch 1 followed by platform specific init() in patch 2.
- Specify when first used the reason for the spinlock use to order byte-enable prior to write data.

v10-0015-soc-amd-Add-support-for-AMD-Pensando-SoC-Control
- Different driver implementation specific to this Pensando controller device.
- Moved to soc/amd directory under new name based on guidance. This driver is of no use to any design other than all Pensando SoC based cards.
- Removed use of builtin_driver, can be built as a module.

== V9 changes == v9-0002-dt-bindings-mmc-cdns-Add-AMD-Pensando-Elba-SoC
- Add reset-names and resets properties
- Add if/then on property amd,pensando-elba-sd4hc to set reg property values for minItems and maxItems

v9-0003-dt-bindings-spi-cdns-Add-compatible-for-AMD-Pensa
- Add 1024 to cdns,fifo-depth property to resolve dtbs_check error

v9-0004-dt-bindings-spi-dw-Add-AMD-Pensando-Elba-SoC-SPI-
- Define property amd,pensando-elba-syscon
- Move compatible amd,pensando-elba-spi ahead of baikal,bt1-ssi

v9-0006-dt-bindings-mfd-amd-pensando-elbasr-Add-AMD-Pensa
- Instead of four nodes, one per chip-select, a single node is used with reset-cells in the parent.
- No MFD API is used anymore in the driver so it made sense to move this to drivers/spi.
- This driver is common for all Pensando SoC based designs so changed the name to pensando-sr.c to not make it Elba SoC specific.
- Added property cs for the chip-select number which is used by the driver to create /dev/pensr0.<cs>

v9-0009-arm64-dts-Add-AMD-Pensando-Elba-SoC-support
- Single node for spi0 system-controller and squash the reset-controller child into parent

v9-0010-spi-cadence-quadspi-Add-compatible-for-AMD-Pensan
- Rebase to linux-next 6.2.0-rc1

v9-0011-spi-dw-Add-support-for-AMD-Pensando-Elba-SoC
- Add use of macros GENMASK() and BIT()
- Change ELBA_SPICS_SHIFT() to ELBA_SPICS_OFFSET()

v9-0012-mmc-sdhci-cadence-Enable-device-specific-override
- No change to this patch but as some patches are deleted and this is a respin the three successive patches to sdhci-cadence.c are patches 12, 13, and 14 which do the following:
1. Add ability for Cadence specific design to have priv writel().
2. Add Elba SoC support that requires its own priv writel() for byte-lane control .
3. Add support for mmc hardware reset.

v9-0014-mmc-sdhci-cadence-Support-mmc-hardware-reset
- Previously patch 17/17
- Changed delay after reset_control_assert() from 9 to 3 usec
- Renamed sdhci_mmc_hw_reset() to sdhci_cdns_mmc_hw_reset()

v9-0015-spi-pensando-sr-Add-AMD-Pensando-SoC-System-Resou
- Previously patch 14/17
- After the change to the device tree node and squashing reset-cells into the parent simplified this to not use any MFD API and move it to drivers/spi/pensando-sr.c.
- Change the naming to remove elba since this driver is common for all Pensando SoC designs .
- Default yes SPI_PENSANDO_SR for ARCH_PENSANDO

== V6 changes ==
- Updated copyright and SPDX

v6-0001-dt-bindings-arm-add-AMD-Pensando-boards
- Delete 'Device Tree Bindings' in title

v6-0002-dt-bindings-mmc-cdns-Add-AMD-Pensando-Elba-SoC
- Change if/then for Elba which has a second reg for byte-lane control

v6-0003-dt-bindings-spi-cdns-Add-compatible-for-AMD-Pensa
- no change

v6-0004-dt-bindings-spi-dw-Add-AMD-Pensando-Elba-SoC-SPI-
- Add amd,pensando-elba-syscon

v6-0005-dt-bindings-mfd-syscon-Add-amd-pensando-elba-sysc
- no change

v6-0006-dt-bindings-mfd-amd-pensando-elbasr-Add-AMD-Pensa
- Expand description, rename nodes and change compatible usage

v6-0007-dt-bindings-reset-amd-pensando-elbasr-reset-Add-A
- Delete nodename pattern and changed spi0 to spi
- File amd,pensando-elba-reset.h is deleted as there is only one reset used.
- Update example

v6-0008-MAINTAINERS-Add-entry-for-AMD-PENSANDO
- no change

v6-0009-arm64-Add-config-for-AMD-Pensando-SoC-platforms
- no change

v6-0010-arm64-dts-Add-AMD-Pensando-Elba-SoC-support
- Update node names and add amd,pensando-elba-syscon
- Delete use of amd,pensando-elba-reset.h which had a single definition

v6-0011-spi-cadence-quadspi-Add-compatible-for-AMD-Pensan
- Remove (void) cast

v6-0012-spi-dw-Add-support-for-AMD-Pensando-Elba-SoC
- Update use of amd,pensando-elba-syscon

v6-0013-mmc-sdhci-cadence-Enable-device-specific-override
- Change this patch to add a priv_writel() callback where all existing designs use writel(). This separates the Elba support into three patches. The second patch is added to the end of the sequence for Elba support. The third patch enables mmc hardware reset.

v6-0014-mfd-pensando-elbasr-Add-AMD-Pensando-Elba-System-
- Updates from review comments
- Use spi_message_init_with_transfers instead of init/add_tail API

v6-0015-reset-elbasr-Add-AMD-Pensando-Elba-SR-Reset-Contr
- Remove use of amd,pensando-elba-reset.h and use BIT()

v6-0016-mmc-sdhci-cadence-Add-AMD-Pensando-Elba-SoC-suppo
- Elba sdhci-cadence.c support added in this patch to build on 0013 which just adds a callback to override priv_writel()

v6-0017-mmc-sdhci-cadence-Support-mmc-hardware-reset
- New patch where Elba has a reset-controller for mmc hardware reset. The reset is implemented by a register in the cpld.

== V5 changes ==
- Change to AMD Pensando instead of Pensando.
- No reference to spidev in the device tree. Add multi-function driver pensando-elbasr and sub-device reset-elbasr which provides mfd and /dev interface to the cpld.
- Rebase to linux-next tag next-20220609 5.19.0-rc1
- Redo the email list after rebase and using scripts/get_maintainer.pl

== V4 changes ==
The version of dtschema used is 2022.3.2.

v4-0001-dt-bindings-arm-add-Pensando-boards.patch
- Add description and board compatible

v4-0003-dt-bindings-mmc-Add-Pensando-Elba-SoC-binding.patch
- Change from elba-emmc to elba-sd4hc to match file convention
- Use minItems: 1 and maxItems: 2 to pass schema check

v4-0005-dt-bindings-spi-dw-Add-Pensando-Elba-SoC-SPI-Control.patch
- Add required property pensando,syscon-spics to go with pensando,elba-spi

v4-0006-MAINTAINERS-Add-entry-for-PENSANDO.patch
- Change Maintained to Supported

v4-0007-arm64-Add-config-for-Pensando-SoC-platforms.patch
- Fix a typo on interface max speed

v4-0008-spi-cadence-quadspi-Add-compatible-for-Pensando-Elba.patch
- Update due to spi-cadence-quadspi.c changes

v4-0009-mmc-sdhci-cadence-Add-Pensando-Elba-SoC-support.patch
- Change from elba-emmc to elba-sd4hc to match file convention

v4-0010-spi-dw-Add-support-for-Pensando-Elba-SoC.patch
- Use more descriptive dt property pensando,syscon-spics
- Minor changes from review input

v4-0011-arm64-dts-Add-Pensando-Elba-SoC-support.patch
- Changed to dual copyright (GPL-2.0+ OR MIT)
- Minor changes from review input

== V3 changes == v3-0001-gpio-Add-Elba-SoC-gpio-driver-for-spi-cs-control.patch
- This patch is deleted. Elba SOC specific gpio spics control is integrated into spi-dw-mmio.c.

v3-0002-spi-cadence-quadspi-Add-QSPI-support-for-Pensando-El.patch
- Changed compatible to "pensando,elba-qspi" to be more descriptive in spi-cadence-quadspi.c.

- Arnd wondered if moving to DT properties for quirks may be the way to go. Feedback I've received on other patches was don't mix two efforts in one patch so I'm currently just adding the Elba support to the current design.

v3-0003-spi-dw-Add-support-for-Pensando-Elba-SoC-SPI.patch
- Changed the implementation to use existing dw_spi_set_cs() and integrated Elba specific CS control into spi-dw-mmio.c. The native designware support is for two chip-selects while Elba provides 4 chip-selects. Instead of adding a new file for this support in gpio-elba-spics.c the support is in one file (spi-dw-mmio.c).

v3-0004-spidev-Add-Pensando-CPLD-compatible.patch
- This patch is deleted. The addition of compatible "pensando,cpld" to spidev.c is not added and an existing compatible is used in the device tree to enable.

v3-0005-mmc-sdhci-cadence-Add-Pensando-Elba-SoC-support.patch
- Ulf and Yamada-san agreed the amount of code for this support is not enough to need a new file. The support is added into sdhci-cadence.c and new files sdhci-cadence-elba.c and sdhci-cadence.h are deleted.
- Redundant defines are removed (e.g. use SDHCI_CDNS_HRS04 and remove SDIO_REG_HRS4).
- Removed phy init function sd4_set_dlyvr() and used existing sdhci_cdns_phy_init(). Init values are from DT properties.
- Replace devm_ioremap_resource(&pdev->dev, iomem) with devm_platform_ioremap_resource(pdev, 1)
- Refactored the elba priv_writ_l() and elba_write_l() to remove a little redundant code.
- The config option CONFIG_MMC_SDHCI_CADENCE_ELBA goes away.
- Only C syntax and Elba functions are prefixed with elba_

v3-0006-arm64-Add-config-for-Pensando-SoC-platforms.patch
- Added a little more info to the platform help text to assist users to decide on including platform support or not.

v3-0007-arm64-dts-Add-Pensando-Elba-SoC-support.patch
- Node names changed to DT generic names
- Changed from using 'spi@' which is reserved
- The elba-flash-parts.dtsi is kept separate as it is included in multiple dts files.
- SPDX license tags at the top of each file
- The compatible = "pensando,elba" and 'model' are now together in the board file.
- UIO nodes removed
- Ordered nodes by increasing unit address
- Removed an unreferenced container node.
- Dropped deprecated 'device_type' for uart0 node.

v3-0010-dt-bindings-spi-cadence-qspi-Add-support-for-Pensand.patch
- Updated since the latest documentation has been converted to yaml

v3-0011-dt-bindings-gpio-Add-Pensando-Elba-SoC-support.patch
- This patch is deleted since the Elba gpio spics is added to the spi dw driver and documented there.

Because of the deletion of patches and merging of code the new patchset is not similar. A changelog is added into the patches for merged code to be helpful on the history.

== V2 changes ==
- 01 Fix typo, return code value and log message.
- 03 Remove else clause, intrinsic DW chip-select is never used.
- 08-11 Split out dts and bindings to sub-patches
- 10 Converted existing cadence-quadspi.txt to YAML schema
- 13 New driver should use <linux/gpio/driver.h>

Brad Larson (6):
dt-bindings: arm: add AMD Pensando boards
dt-bindings: soc: amd: amd,pensando-elba-ctrl: Add Pensando SoC
Controller
MAINTAINERS: Add entry for AMD PENSANDO
arm64: Add config for AMD Pensando SoC platforms
arm64: dts: Add AMD Pensando Elba SoC support
soc: amd: Add support for AMD Pensando SoC Controller

 .../devicetree/bindings/arm/amd,pensando.yaml |  26 ++
 .../soc/amd/amd,pensando-elba-ctrl.yaml       |  58 ++++
 MAINTAINERS                                   |  10 +
 arch/arm64/Kconfig.platforms                  |  12 +
 arch/arm64/boot/dts/amd/Makefile              |   1 +
 arch/arm64/boot/dts/amd/elba-16core.dtsi      | 197 +++++++++++
 arch/arm64/boot/dts/amd/elba-asic-common.dtsi |  80 +++++
 arch/arm64/boot/dts/amd/elba-asic.dts         |  28 ++
 arch/arm64/boot/dts/amd/elba-flash-parts.dtsi | 117 +++++++
 arch/arm64/boot/dts/amd/elba.dtsi             | 191 +++++++++++
 drivers/soc/Kconfig                           |   1 +
 drivers/soc/Makefile                          |   1 +
 drivers/soc/amd/Kconfig                       |  16 +
 drivers/soc/amd/Makefile                      |   2 +
 drivers/soc/amd/pensando-ctrl.c               | 311 ++++++++++++++++++
 include/uapi/linux/amd-pensando-ctrl.h        |  26 ++
 16 files changed, 1077 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/amd,pensando.yaml
 create mode 100644 Documentation/devicetree/bindings/soc/amd/amd,pensando-elba-ctrl.yaml
 create mode 100644 arch/arm64/boot/dts/amd/elba-16core.dtsi
 create mode 100644 arch/arm64/boot/dts/amd/elba-asic-common.dtsi
 create mode 100644 arch/arm64/boot/dts/amd/elba-asic.dts
 create mode 100644 arch/arm64/boot/dts/amd/elba-flash-parts.dtsi
 create mode 100644 arch/arm64/boot/dts/amd/elba.dtsi
 create mode 100644 drivers/soc/amd/Kconfig
 create mode 100644 drivers/soc/amd/Makefile
 create mode 100644 drivers/soc/amd/pensando-ctrl.c
 create mode 100644 include/uapi/linux/amd-pensando-ctrl.h

base-commit: 7bc675554773f09d88101bf1ccfc8537dc7c0be9

Signature · 1 line
2.17.1
author maintainer
#1 lore raw

PATCH v16 1/6 dt-bindings: arm: add AMD Pensando boards

Document the compatible for AMD Pensando Elba SoC boards.

---
 .../devicetree/bindings/arm/amd,pensando.yaml | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/amd,pensando.yaml
Documentation/devicetree/bindings/arm/amd,pensando.yaml new file +26 -0
new file mode 100644
index 000000000000..e5c2591834a8
@@ -0,0 +1,26 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/amd,pensando.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AMD Pensando SoC Platforms
+
+maintainers:
+  - Brad Larson <[email protected]>
+
+properties:
+  $nodename:
+    const: "/"
+  compatible:
+    oneOf:
+
+      - description: Boards with Pensando Elba SoC
+        items:
+          - enum:
+              - amd,pensando-elba-ortano
+          - const: amd,pensando-elba
+
+additionalProperties: true
+
+...
Signature · 1 line
2.17.1
author maintainer
#2 lore raw

PATCH v16 2/6 dt-bindings: soc: amd: amd,pensando-elba-ctrl: Add Pensando SoC Controller

In reply to Brad Larson

Support the AMD Pensando Elba SoC Controller which is a SPI connected device providing a miscellaneous set of essential board control/status registers. This device is present in all Pensando SoC based designs.

---

v14 changes:
- Change GPL-2.0-only or BSD-2-Clause to GPL-2.0-only OR BSD-2-Clause

v11 changes:
- Fixed the compatible which should have stayed as 'amd,pensando-elba-ctrl', the commit message, and the filename
- Reference spi-peripheral-props
- Delete spi-max-frequency
- Remove num-cs from example

v10 changes:
- Property renamed to amd,pensando-ctrl
- Driver is renamed and moved to soc/drivers/amd affecting binding
- Delete cs property, driver handles device node creation from parent num-cs fixing schema reg error in a different way

v9 changes:
- Instead of four nodes, one per chip-select, a single node is used with reset-cells in the parent.
- No MFD API is used anymore in the driver so it made sense to move this to drivers/spi.
- This driver is common for all Pensando SoC based designs so changed the name to pensando-sr.c to not make it Elba SoC specific.
- Added property cs for the chip-select number which is used by the driver to create /dev/pensr0.<cs>

---
 .../soc/amd/amd,pensando-elba-ctrl.yaml       | 58 +++++++++++++++++++
 1 file changed, 58 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/amd/amd,pensando-elba-ctrl.yaml
Documentation/devicetree/bindings/soc/amd/amd,pensando-elba-ctrl.yaml new file +58 -0
new file mode 100644
index 000000000000..e96978ad1e37
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/amd/amd,pensando-elba-ctrl.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AMD Pensando Elba SoC Controller
+
+description:
+  The AMD Pensando Elba SoC Controller is a SPI connected device with essential
+  control/status registers accessed on chip select 0.  This device is present
+  in all Pensando SoC based designs.
+
+maintainers:
+  - Brad Larson <[email protected]>
+
+properties:
+  compatible:
+    enum:
+      - amd,pensando-elba-ctrl
+
+  reg:
+    maxItems: 1
+
+  '#reset-cells':
+    const: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - '#reset-cells'
+
+allOf:
+  - $ref: /schemas/spi/spi-peripheral-props.yaml#
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        system-controller@0 {
+            compatible = "amd,pensando-elba-ctrl";
+            reg = <0>;
+            spi-max-frequency = <12000000>;
+            interrupt-parent = <&porta>;
+            interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+            #reset-cells = <1>;
+        };
+    };
+
+...
Signature · 1 line
2.17.1
author maintainer
#3 lore raw

PATCH v16 3/6 MAINTAINERS: Add entry for AMD PENSANDO

In reply to Brad Larson

Add entry for AMD PENSANDO maintainer and files

---
 MAINTAINERS | 10 ++++++++++
 1 file changed, 10 insertions(+)
MAINTAINERS +10 -0
index 2833e2da63e0..28c1e29425a5 100644
@@ -1815,6 +1815,16 @@ N:	allwinner
 N:	sun[x456789]i
 N:	sun[25]0i
 
+ARM/AMD PENSANDO ARM64 ARCHITECTURE
+M:	Brad Larson <[email protected]>
+L:	[email protected] (moderated for non-subscribers)
+S:	Supported
+F:	Documentation/devicetree/bindings/*/amd,pensando*
+F:	Documentation/devicetree/bindings/soc/amd/amd,pensando*
+F:	arch/arm64/boot/dts/amd/elba*
+F:	drivers/soc/amd/
+F:	include/uapi/linux/amd-pensando*
+
 ARM/Amlogic Meson SoC CLOCK FRAMEWORK
 M:	Neil Armstrong <[email protected]>
 M:	Jerome Brunet <[email protected]>
Signature · 1 line
2.17.1
author maintainer
#4 lore raw

PATCH v16 4/6 arm64: Add config for AMD Pensando SoC platforms

In reply to Brad Larson

Add ARCH_PENSANDO configuration option for AMD Pensando SoC based platforms.

---

v16 changes:
- Updated the help description to be more precise

---
 arch/arm64/Kconfig.platforms | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm64/Kconfig.platforms +12 -0
index 6069120199bb..24335565bad5 100644
@@ -244,6 +244,18 @@ config ARCH_NPCM
 	  General support for NPCM8xx BMC (Arbel).
 	  Nuvoton NPCM8xx BMC based on the Cortex A35.
 
+config ARCH_PENSANDO
+	bool "AMD Pensando Platforms"
+	help
+	  This enables support for the ARMv8 based AMD Pensando SoC
+	  family to include the Elba SoC.
+
+	  AMD Pensando SoCs support a range of Distributed Services
+	  Cards in PCIe format installed into servers.  The Elba
+	  SoC includes 16 Cortex A-72 CPU cores, 144 P4-programmable
+	  cores for a minimal latency/jitter datapath, and network
+	  interfaces up to 200 Gb/s.
+
 config ARCH_QCOM
 	bool "Qualcomm Platforms"
 	select GPIOLIB
Signature · 1 line
2.17.1
author maintainer
#5 lore raw

PATCH v16 5/6 arm64: dts: Add AMD Pensando Elba SoC support

In reply to Brad Larson

Add AMD Pensando common and Elba SoC specific device nodes

---

v15 changes:
- The first cell in the cpu reg property is always zero. Change address-cells to <1> and dropped the leading zero from all cpu* reg<>
- Added read-only and spare partitions to flash0

v14 changes:
- Fix dtbs_check l2-cache* property issue by adding required cache-level and cache-unified properties
- Observed the issue after updating dtschema from 2023.1 to 2023.4 and yamllint from 1.26.3 to 1.30.0

v11 changes:
- Delete reset-names
- Fix spi0 compatible to be specific 'amd,pensando-elba-ctrl'

v9 changes:
- Single node for spi0 system-controller and squash the reset-controller child into parent

---
 arch/arm64/boot/dts/amd/Makefile              |   1 +
 arch/arm64/boot/dts/amd/elba-16core.dtsi      | 197 ++++++++++++++++++
 arch/arm64/boot/dts/amd/elba-asic-common.dtsi |  80 +++++++
 arch/arm64/boot/dts/amd/elba-asic.dts         |  28 +++
 arch/arm64/boot/dts/amd/elba-flash-parts.dtsi | 117 +++++++++++
 arch/arm64/boot/dts/amd/elba.dtsi             | 191 +++++++++++++++++
 6 files changed, 614 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amd/elba-16core.dtsi
 create mode 100644 arch/arm64/boot/dts/amd/elba-asic-common.dtsi
 create mode 100644 arch/arm64/boot/dts/amd/elba-asic.dts
 create mode 100644 arch/arm64/boot/dts/amd/elba-flash-parts.dtsi
 create mode 100644 arch/arm64/boot/dts/amd/elba.dtsi
arch/arm64/boot/dts/amd/Makefile +1 -0
index 68103a8b0ef5..8502cc2afbc5 100644
@@ -1,2 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
+dtb-$(CONFIG_ARCH_PENSANDO) += elba-asic.dtb
 dtb-$(CONFIG_ARCH_SEATTLE) += amd-overdrive-rev-b0.dtb amd-overdrive-rev-b1.dtb
arch/arm64/boot/dts/amd/elba-16core.dtsi new file +197 -0

197 lines not on this page · raw message

arch/arm64/boot/dts/amd/elba-asic-common.dtsi new file +80 -0

80 lines not on this page · raw message

arch/arm64/boot/dts/amd/elba-asic.dts new file +28 -0
new file mode 100644
index 000000000000..c3f4da2f7449
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+/*
+ * Device Tree file for AMD Pensando Elba Board.
+ *
+ * Copyright 2020-2022 Advanced Micro Devices, Inc.
+ */
+
+/dts-v1/;
+
+#include "elba.dtsi"
+#include "elba-16core.dtsi"
+#include "elba-asic-common.dtsi"
+#include "elba-flash-parts.dtsi"
+
+/ {
+	model = "AMD Pensando Elba Board";
+	compatible = "amd,pensando-elba-ortano", "amd,pensando-elba";
+
+	aliases {
+		serial0 = &uart0;
+		spi0 = &spi0;
+		spi1 = &qspi;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
arch/arm64/boot/dts/amd/elba-flash-parts.dtsi new file +117 -0

117 lines not on this page · raw message

arch/arm64/boot/dts/amd/elba.dtsi new file +191 -0

191 lines not on this page · raw message

Signature · 1 line
2.17.1
author maintainer
#7 lore raw

PATCH v16 6/6 soc: amd: Add support for AMD Pensando SoC Controller

In reply to Brad Larson

The Pensando SoC controller is a SPI connected companion device that is present in all Pensando SoC board designs. The essential board management registers are accessed on chip select 0 with board mgmt IO support accessed using additional chip selects.

---

v15 changes:
- Drop custom ioctl and use existing miscdevice interface.
- Delete unused definitions in amd-pensando-ctrl.h
- Makefile change to compile for ARCH_PENSANDO

v14 changes:
- Save 8 bytes of code size by swapping spi_device and reset_controller_dev in penctrl_device
- Code simplification and clarity from review inputs
- Set penctrl_spi_driver.driver.name to match compatible pensando-elba-ctrl
- Remove unused include in amd-pensando-ctrl.h
- Rebase to linux-next 6.4.0-rc1 class_create() API change

v13 changes:
- Update include list in pensando-ctrl.c
- Change variable spi_dev to spi throughout
- Removed unneeded variable initialization, simplification of error checks, remove extra castings, and use dev_err_probe()
- Sort the includes in amd-pensando-ctrl.h
- Updates to cleanup if there is an error in penctrl_spi_probe()

v12 changes:
- Fix gcc-12.1.0 warning

v11 changes:
- Fix the compatible to be specific 'amd,pensando-elba-ctrl'

v10 changes:
- Different driver implementation specific to this Pensando controller device.
- Moved to soc/amd directory under new name based on guidance. This driver is of no use to any design other than all Pensando SoC based cards.
- Removed use of builtin_driver, can be built as a module.

v9 changes:
- Previously patch 14/17
- After the change to the device tree node and squashing reset-cells into the parent simplified this to not use any MFD API and move it to drivers/spi/pensando-sr.c.
- Change the naming to remove elba since this driver is common for all Pensando SoC designs .
- Default yes SPI_PENSANDO_SR for ARCH_PENSANDO

---
 drivers/soc/Kconfig                    |   1 +
 drivers/soc/Makefile                   |   1 +
 drivers/soc/amd/Kconfig                |  16 ++
 drivers/soc/amd/Makefile               |   2 +
 drivers/soc/amd/pensando-ctrl.c        | 311 +++++++++++++++++++++++++
 include/uapi/linux/amd-pensando-ctrl.h |  26 +++
 6 files changed, 357 insertions(+)
 create mode 100644 drivers/soc/amd/Kconfig
 create mode 100644 drivers/soc/amd/Makefile
 create mode 100644 drivers/soc/amd/pensando-ctrl.c
 create mode 100644 include/uapi/linux/amd-pensando-ctrl.h
drivers/soc/Kconfig +1 -0
index d21e75d69294..1a8a42141e78 100644
@@ -2,6 +2,7 @@
 menu "SOC (System On Chip) specific Drivers"
 
 source "drivers/soc/actions/Kconfig"
+source "drivers/soc/amd/Kconfig"
 source "drivers/soc/amlogic/Kconfig"
 source "drivers/soc/apple/Kconfig"
 source "drivers/soc/aspeed/Kconfig"
drivers/soc/Makefile +1 -0
index 0706a27d13be..dbd651fcbecc 100644
@@ -3,6 +3,7 @@
 # Makefile for the Linux Kernel SOC specific device drivers.
 #
 
+obj-$(CONFIG_ARCH_PENSANDO)	+= amd/
 obj-y				+= apple/
 obj-y				+= aspeed/
 obj-$(CONFIG_ARCH_AT91)		+= atmel/
drivers/soc/amd/Kconfig new file +16 -0
new file mode 100644
index 000000000000..011d5339d14e
@@ -0,0 +1,16 @@
+# SPDX-License-Identifier: GPL-2.0-only
+menu "AMD Pensando SoC drivers"
+
+config AMD_PENSANDO_CTRL
+	tristate "AMD Pensando SoC Controller"
+	depends on SPI_MASTER=y
+	depends on (ARCH_PENSANDO && OF) || COMPILE_TEST
+	default ARCH_PENSANDO
+	select REGMAP_SPI
+	select MFD_SYSCON
+	help
+	  Enables AMD Pensando SoC controller device support.  This is a SPI
+	  attached companion device in all Pensando SoC board designs which
+	  provides essential board control/status registers and management IO
+	  support.
+endmenu
drivers/soc/amd/Makefile new file +2 -0
new file mode 100644
index 000000000000..a2de0424f68d
@@ -0,0 +1,2 @@
+# SPDX-License-Identifier: GPL-2.0-only
+obj-$(CONFIG_AMD_PENSANDO_CTRL)	+= pensando-ctrl.o
drivers/soc/amd/pensando-ctrl.c new file +311 -0

311 lines not on this page · raw message

include/uapi/linux/amd-pensando-ctrl.h new file +26 -0
new file mode 100644
index 000000000000..626b85e3fdb5
@@ -0,0 +1,26 @@
+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+/*
+ * Userspace interface for /dev/penctrl
+ *
+ * This file can be used by applications that need to communicate
+ * with the AMD Pensando SoC controller device via the ioctl interface.
+ */
+#ifndef _UAPI_LINUX_AMD_PENSANDO_CTRL_H
+#define _UAPI_LINUX_AMD_PENSANDO_CTRL_H
+
+#include <linux/types.h>
+
+#define PENCTRL_SPI_CMD_REGRD	0x0b
+#define PENCTRL_SPI_CMD_REGWR	0x02
+#define PENCTRL_MAX_MSG_LEN	16
+#define PENCTRL_REG_CTRL0	0x10
+
+struct penctrl_spi_xfer {
+	__u64 tx_buf;
+	__u64 rx_buf;
+	__u32 len;
+	__u32 speed_hz;
+	__u64 compat;
+};
+
+#endif /* _UAPI_LINUX_AMD_PENSANDO_CTRL_H */
Signature · 1 line
2.17.1
Reviewed-by on v16 5/6
#6 lore raw

Re: [PATCH v16 5/6] arm64: dts: Add AMD Pensando Elba SoC support

In reply to Brad Larson
Quoted 690 lines · Brad Larson

Add AMD Pensando common and Elba SoC specific device nodes

---

v15 changes:
- The first cell in the cpu reg property is always zero. Change address-cells to <1> and dropped the leading zero from all cpu* reg<>
- Added read-only and spare partitions to flash0

v14 changes:
- Fix dtbs_check l2-cache* property issue by adding required cache-level and cache-unified properties
- Observed the issue after updating dtschema from 2023.1 to 2023.4 and yamllint from 1.26.3 to 1.30.0

v11 changes:
- Delete reset-names
- Fix spi0 compatible to be specific 'amd,pensando-elba-ctrl'

v9 changes:
- Single node for spi0 system-controller and squash the reset-controller child into parent

---
  arch/arm64/boot/dts/amd/Makefile              |   1 +
  arch/arm64/boot/dts/amd/elba-16core.dtsi      | 197 ++++++++++++++++++
  arch/arm64/boot/dts/amd/elba-asic-common.dtsi |  80 +++++++
  arch/arm64/boot/dts/amd/elba-asic.dts         |  28 +++
  arch/arm64/boot/dts/amd/elba-flash-parts.dtsi | 117 +++++++++++
  arch/arm64/boot/dts/amd/elba.dtsi             | 191 +++++++++++++++++
  6 files changed, 614 insertions(+)

create mode 100644 arch/arm64/boot/dts/amd/elba-16core.dtsi create mode 100644 arch/arm64/boot/dts/amd/elba-asic-common.dtsi create mode 100644 arch/arm64/boot/dts/amd/elba-asic.dts create mode 100644 arch/arm64/boot/dts/amd/elba-flash-parts.dtsi create mode 100644 arch/arm64/boot/dts/amd/elba.dtsi

arch/arm64/boot/dts/amd/Makefile +1 -0
index 68103a8b0ef5..8502cc2afbc5 100644
@@ -1,2 +1,3 @@
  # SPDX-License-Identifier: GPL-2.0
+dtb-$(CONFIG_ARCH_PENSANDO) += elba-asic.dtb
  dtb-$(CONFIG_ARCH_SEATTLE) += amd-overdrive-rev-b0.dtb amd-overdrive-rev-b1.dtb
arch/arm64/boot/dts/amd/elba-16core.dtsi new file +197 -0
new file mode 100644
index 000000000000..568bcc39ce9f
@@ -0,0 +1,197 @@
+// SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+/*
+ * Copyright 2020-2023 Advanced Micro Devices, Inc.
+ */
+
+/ {
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu-map {
+			cluster0 {
+				core0 { cpu = <&cpu0>; };
+				core1 { cpu = <&cpu1>; };
+				core2 { cpu = <&cpu2>; };
+				core3 { cpu = <&cpu3>; };
+			};
+
+			cluster1 {
+				core0 { cpu = <&cpu4>; };
+				core1 { cpu = <&cpu5>; };
+				core2 { cpu = <&cpu6>; };
+				core3 { cpu = <&cpu7>; };
+			};
+
+			cluster2 {
+				core0 { cpu = <&cpu8>; };
+				core1 { cpu = <&cpu9>; };
+				core2 { cpu = <&cpu10>; };
+				core3 { cpu = <&cpu11>; };
+			};
+
+			cluster3 {
+				core0 { cpu = <&cpu12>; };
+				core1 { cpu = <&cpu13>; };
+				core2 { cpu = <&cpu14>; };
+				core3 { cpu = <&cpu15>; };
+			};
+		};
+
+		/* CLUSTER 0 */
+		cpu0: cpu@0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x0>;
+			next-level-cache = <&l2_0>;
+			enable-method = "psci";
+		};
+
+		cpu1: cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x1>;
+			next-level-cache = <&l2_0>;
+			enable-method = "psci";
+		};
+
+		cpu2: cpu@2 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x2>;
+			next-level-cache = <&l2_0>;
+			enable-method = "psci";
+		};
+
+		cpu3: cpu@3 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x3>;
+			next-level-cache = <&l2_0>;
+			enable-method = "psci";
+		};
+
+		l2_0: l2-cache0 {
+			compatible = "cache";
+			cache-unified;
+			cache-level = <2>;
+		};
+
+		/* CLUSTER 1 */
+		cpu4: cpu@100 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x100>;
+			next-level-cache = <&l2_1>;
+			enable-method = "psci";
+		};
+
+		cpu5: cpu@101 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x101>;
+			next-level-cache = <&l2_1>;
+			enable-method = "psci";
+		};
+
+		cpu6: cpu@102 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x102>;
+			next-level-cache = <&l2_1>;
+			enable-method = "psci";
+		};
+
+		cpu7: cpu@103 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x103>;
+			next-level-cache = <&l2_1>;
+			enable-method = "psci";
+		};
+
+		l2_1: l2-cache1 {
+			compatible = "cache";
+			cache-unified;
+			cache-level = <2>;
+		};
+
+		/* CLUSTER 2 */
+		cpu8: cpu@200 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x200>;
+			next-level-cache = <&l2_2>;
+			enable-method = "psci";
+		};
+
+		cpu9: cpu@201 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x201>;
+			next-level-cache = <&l2_2>;
+			enable-method = "psci";
+		};
+
+		cpu10: cpu@202 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x202>;
+			next-level-cache = <&l2_2>;
+			enable-method = "psci";
+		};
+
+		cpu11: cpu@203 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x203>;
+			next-level-cache = <&l2_2>;
+			enable-method = "psci";
+		};
+
+		l2_2: l2-cache2 {
+			compatible = "cache";
+			cache-unified;
+			cache-level = <2>;
+		};
+
+		/* CLUSTER 3 */
+		cpu12: cpu@300 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x300>;
+			next-level-cache = <&l2_3>;
+			enable-method = "psci";
+		};
+
+		cpu13: cpu@301 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x301>;
+			next-level-cache = <&l2_3>;
+			enable-method = "psci";
+		};
+
+		cpu14: cpu@302 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x302>;
+			next-level-cache = <&l2_3>;
+			enable-method = "psci";
+		};
+
+		cpu15: cpu@303 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a72";
+			reg = <0x303>;
+			next-level-cache = <&l2_3>;
+			enable-method = "psci";
+		};
+
+		l2_3: l2-cache3 {
+			compatible = "cache";
+			cache-unified;
+			cache-level = <2>;
+		};
+	};
+};
arch/arm64/boot/dts/amd/elba-asic-common.dtsi new file +80 -0
new file mode 100644
index 000000000000..1a615788f54e
@@ -0,0 +1,80 @@
+// SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+/*
+ * Copyright 2020-2022 Advanced Micro Devices, Inc.
+ */
+
+&ahb_clk {
+	clock-frequency = <400000000>;
+};
+
+&emmc_clk {
+	clock-frequency = <200000000>;
+};
+
+&flash_clk {
+	clock-frequency = <400000000>;
+};
+
+&ref_clk {
+	clock-frequency = <156250000>;
+};
+
+&qspi {
+	status = "okay";
+
+	flash0: flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <40000000>;
+		spi-rx-bus-width = <2>;
+		m25p,fast-read;
+		cdns,read-delay = <0>;
+		cdns,tshsl-ns = <0>;
+		cdns,tsd2d-ns = <0>;
+		cdns,tchsh-ns = <0>;
+		cdns,tslch-ns = <0>;
+	};
+};
+
+&gpio0 {
+	status = "okay";
+};
+
+&emmc {
+	bus-width = <8>;
+	cap-mmc-hw-reset;
+	resets = <&rstc 0>;
+	status = "okay";
+};
+
+&wdt0 {
+	status = "okay";
+};
+
+&i2c0 {
+	clock-frequency = <100000>;
+	status = "okay";
+
+	rtc@51 {
+		compatible = "nxp,pcf85263";
+		reg = <0x51>;
+	};
+};
+
+&spi0 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	num-cs = <4>;
+	cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>,
+		   <&porta 7 GPIO_ACTIVE_LOW>;
+	status = "okay";
+
+	rstc: system-controller@0 {
+		compatible = "amd,pensando-elba-ctrl";
+		reg = <0>;
+		spi-max-frequency = <12000000>;
+		interrupt-parent = <&porta>;
+		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
+		#reset-cells = <1>;
+	};
+};
arch/arm64/boot/dts/amd/elba-asic.dts new file +28 -0
new file mode 100644
index 000000000000..c3f4da2f7449
@@ -0,0 +1,28 @@
+// SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+/*
+ * Device Tree file for AMD Pensando Elba Board.
+ *
+ * Copyright 2020-2022 Advanced Micro Devices, Inc.
+ */
+
+/dts-v1/;
+
+#include "elba.dtsi"
+#include "elba-16core.dtsi"
+#include "elba-asic-common.dtsi"
+#include "elba-flash-parts.dtsi"
+
+/ {
+	model = "AMD Pensando Elba Board";
+	compatible = "amd,pensando-elba-ortano", "amd,pensando-elba";
+
+	aliases {
+		serial0 = &uart0;
+		spi0 = &spi0;
+		spi1 = &qspi;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
arch/arm64/boot/dts/amd/elba-flash-parts.dtsi new file +117 -0
new file mode 100644
index 000000000000..9bffdf23511f
@@ -0,0 +1,117 @@
+// SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+/*
+ * Copyright 2020-2023 Advanced Micro Devices, Inc.
+ */
+
+&flash0 {
+	partitions {
+		compatible = "fixed-partitions";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		partition@0 {
+			label = "rsvd";
+			reg = <0x0 0x10000>;
+			read-only;
+		};
+
+		partition@10000 {
+			label = "flash";
+			reg = <0x10000 0xfff0000>;
+		};
+
+		partition@f0000 {
+			label = "golduenv";
+			reg = <0xf0000 0x10000>;
+		};
+
+		partition@100000 {
+			label = "boot0";
+			reg = <0x100000 0x80000>;
+		};
+
+		partition@180000 {
+			label = "golduboot";
+			reg = <0x180000 0x200000>;
+		};
+
+		partition@380000 {
+			label = "brdcfg0";
+			reg = <0x380000 0x10000>;
+		};
+
+		partition@390000 {
+			label = "brdcfg1";
+			reg = <0x390000 0x10000>;
+		};
+
+		partition@400000 {
+			label = "goldfw";
+			reg = <0x400000 0x3c00000>;
+		};
+
+		partition@4010000 {
+			label = "fwmap";
+			reg = <0x4010000 0x20000>;
+		};
+
+		partition@4030000 {
+			label = "fwsel";
+			reg = <0x4030000 0x20000>;
+		};
+
+		partition@4090000 {
+			label = "bootlog";
+			reg = <0x4090000 0x20000>;
+		};
+
+		partition@40b0000 {
+			label = "panicbuf";
+			reg = <0x40b0000 0x20000>;
+		};
+
+		partition@40d0000 {
+			label = "uservars";
+			reg = <0x40d0000 0x20000>;
+		};
+
+		partition@4200000 {
+			label = "uboota";
+			reg = <0x4200000 0x400000>;
+		};
+
+		partition@4600000 {
+			label = "ubootb";
+			reg = <0x4600000 0x400000>;
+		};
+
+		partition@4a00000 {
+			label = "mainfwa";
+			reg = <0x4a00000 0x1000000>;
+		};
+
+		partition@5a00000 {
+			label = "mainfwb";
+			reg = <0x5a00000 0x1000000>;
+		};
+
+		partition@6a00000 {
+			label = "diaguboot";
+			reg = <0x6a00000 0x400000>;
+		};
+
+		partition@6e00000 {
+			label = "spare";
+			reg = <0x6e00000 0x1200000>;
+		};
+
+		partition@8000000 {
+			label = "diagfw";
+			reg = <0x8000000 0x7fe0000>;
+		};
+
+		partition@ffe0000 {
+			label = "ubootenv";
+			reg = <0xffe0000 0x10000>;
+		};
+	};
+};
arch/arm64/boot/dts/amd/elba.dtsi new file +191 -0
new file mode 100644
index 000000000000..674890cf2a34
@@ -0,0 +1,191 @@
+// SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
+/*
+ * Copyright 2020-2022 Advanced Micro Devices, Inc.
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include "dt-bindings/interrupt-controller/arm-gic.h"
+
+/ {
+	model = "Elba ASIC Board";
+	compatible = "amd,pensando-elba";
+	interrupt-parent = <&gic>;
+	#address-cells = <2>;
+	#size-cells = <2>;
+
+	dma-coherent;
+
+	ahb_clk: oscillator0 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+	};
+
+	emmc_clk: oscillator2 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+	};
+
+	flash_clk: oscillator3 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+	};
+
+	ref_clk: oscillator4 {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+	};
+
+	psci {
+		compatible = "arm,psci-0.2";
+		method = "smc";
+	};
+
+	timer {
+		compatible = "arm,armv8-timer";
+		interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_PPI 14 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_PPI 11 IRQ_TYPE_LEVEL_LOW>,
+			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>;
+	};
+
+	pmu {
+		compatible = "arm,cortex-a72-pmu";
+		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
+	};
+
+	soc: soc {
+		compatible = "simple-bus";
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;
+
+		i2c0: i2c@400 {
+			compatible = "snps,designware-i2c";
+			reg = <0x0 0x400 0x0 0x100>;
+			clocks = <&ahb_clk>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			i2c-sda-hold-time-ns = <480>;
+			interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
+		wdt0: watchdog@1400 {
+			compatible = "snps,dw-wdt";
+			reg = <0x0 0x1400 0x0 0x100>;
+			clocks = <&ahb_clk>;
+			interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
+		qspi: spi@2400 {
+			compatible = "amd,pensando-elba-qspi", "cdns,qspi-nor";
+			reg = <0x0 0x2400 0x0 0x400>,
+			      <0x0 0x7fff0000 0x0 0x1000>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&flash_clk>;
+			cdns,fifo-depth = <1024>;
+			cdns,fifo-width = <4>;
+			cdns,trigger-address = <0x7fff0000>;
+			status = "disabled";
+		};
+
+		spi0: spi@2800 {
+			compatible = "amd,pensando-elba-spi";
+			reg = <0x0 0x2800 0x0 0x100>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			amd,pensando-elba-syscon = <&syscon>;
+			clocks = <&ahb_clk>;
+			interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+			num-cs = <2>;
+			status = "disabled";
+		};
+
+		gpio0: gpio@4000 {
+			compatible = "snps,dw-apb-gpio";
+			reg = <0x0 0x4000 0x0 0x78>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+
+			porta: gpio-port@0 {
+				compatible = "snps,dw-apb-gpio-port";
+				reg = <0>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				ngpios = <8>;
+				interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
+				interrupt-controller;
+				interrupt-parent = <&gic>;
+				#interrupt-cells = <2>;
+			};
+
+			portb: gpio-port@1 {
+				compatible = "snps,dw-apb-gpio-port";
+				reg = <1>;
+				gpio-controller;
+				#gpio-cells = <2>;
+				ngpios = <8>;
+			};
+		};
+
+		uart0: serial@4800 {
+			compatible = "ns16550a";
+			reg = <0x0 0x4800 0x0 0x100>;
+			clocks = <&ref_clk>;
+			interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
+			reg-shift = <2>;
+			reg-io-width = <4>;
+		};
+
+		gic: interrupt-controller@800000 {
+			compatible = "arm,gic-v3";
+			reg = <0x0 0x800000 0x0 0x200000>,	/* GICD */
+			      <0x0 0xa00000 0x0 0x200000>,	/* GICR */
+			      <0x0 0x60000000 0x0 0x2000>,	/* GICC */
+			      <0x0 0x60010000 0x0 0x1000>,	/* GICH */
+			      <0x0 0x60020000 0x0 0x2000>;	/* GICV */
+			#address-cells = <2>;
+			#size-cells = <2>;
+			#interrupt-cells = <3>;
+			ranges;
+			interrupt-controller;
+			interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+
+			/*
+			 * Elba specific pre-ITS is enabled using the
+			 * existing property socionext,synquacer-pre-its
+			 */
+			gic_its: msi-controller@820000 {
+				compatible = "arm,gic-v3-its";
+				reg = <0x0 0x820000 0x0 0x10000>;
+				msi-controller;
+				#msi-cells = <1>;
+				socionext,synquacer-pre-its =
+							<0xc00000 0x1000000>;
+			};
+		};
+
+		emmc: mmc@30440000 {
+			compatible = "amd,pensando-elba-sd4hc", "cdns,sd4hc";
+			reg = <0x0 0x30440000 0x0 0x10000>,
+			      <0x0 0x30480044 0x0 0x4>;	/* byte-lane ctrl */
+			clocks = <&emmc_clk>;
+			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
+			cdns,phy-input-delay-sd-highspeed = <0x4>;
+			cdns,phy-input-delay-legacy = <0x4>;
+			cdns,phy-input-delay-sd-uhs-sdr50 = <0x6>;
+			cdns,phy-input-delay-sd-uhs-ddr50 = <0x16>;
+			mmc-ddr-1_8v;
+			status = "disabled";
+		};
+
+		syscon: syscon@307c0000 {
+			compatible = "amd,pensando-elba-syscon", "syscon";
+			reg = <0x0 0x307c0000 0x0 0x3000>;
+		};
+	};
+};
#8 lore raw

Re: [PATCH v16 6/6] soc: amd: Add support for AMD Pensando SoC Controller

In reply to Brad Larson
Quoted 5 lines · Brad Larson

The Pensando SoC controller is a SPI connected companion device that is present in all Pensando SoC board designs. The essential board management registers are accessed on chip select 0 with board mgmt IO support accessed using additional chip selects.

...

drivers/soc/amd/pensando-ctrl.c line 22

Quoted 11 lines
drivers/soc/amd/pensando-ctrl.c new file +11 -0
+#include <linux/cdev.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/fs.h>
+#include <linux/init.h>
+#include <linux/miscdevice.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/reset-controller.h>
+#include <linux/spi/spi.h>

types.h ?

Quoted 1 line

+#include <linux/uaccess.h>

...

drivers/soc/amd/pensando-ctrl.c line 40

Quoted 4 lines
drivers/soc/amd/pensando-ctrl.c new file +3 -0
+       struct penctrl_device *penctrl;
 
+       u8 tx_buf[PENCTRL_MAX_MSG_LEN];
+       u8 rx_buf[PENCTRL_MAX_MSG_LEN];

These are not DMA-safe, is this a problem?

Quoted 7 lines
drivers/soc/amd/pensando-ctrl.c new file +7 -0
+       struct spi_transfer t[2] = {};
+       struct penctrl_spi_xfer *msg;
+       struct spi_device *spi;
+       unsigned int num_msgs;
+       struct spi_message m;
+       u32 size;
+       int ret;

...

drivers/soc/amd/pensando-ctrl.c line 60

Quoted 3 lines
drivers/soc/amd/pensando-ctrl.c new file +3 -0
+       /* Verify and prepare SPI message */
+       size = _IOC_SIZE(cmd);
+       num_msgs = size / sizeof(struct penctrl_spi_xfer);

sizeof (*msg) ?

Quoted 1 line

+ if (num_msgs > 2 || size == 0 || size % sizeof(struct penctrl_spi_xfer)) {

Dito.

Quoted 3 lines
drivers/soc/amd/pensando-ctrl.c new file +3 -0
+               ret = -EINVAL;
+               goto out_unlock;
+       }

...

drivers/soc/amd/pensando-ctrl.c line 69

Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +5 -0
+       msg = memdup_user((struct penctrl_spi_xfer *)arg, size);
+       if (IS_ERR(msg)) {
+               ret = PTR_ERR(msg);
+               goto out_unlock;
+       }

Wondering if you can start using cleanup.h.

...

drivers/soc/amd/pensando-ctrl.c line 98

Quoted 7 lines
drivers/soc/amd/pensando-ctrl.c new file +6 -0
+       /* Perform the transfer */
+       mutex_lock(&spi_lock);
+       ret = spi_sync(spi, &m);
+       mutex_unlock(&spi_lock);
 
+       if (ret || (num_msgs == 1))
+               goto out_unlock;

Second conditional will return 0. Is it by design? Since it's not so obvious I would split these conditionals.

...

Quoted 1 line

+ spi->chip_select = current_cs;

spi_set_chipselect()

...

drivers/soc/amd/pensando-ctrl.c line 142

Quoted 8 lines
drivers/soc/amd/pensando-ctrl.c new file +7 -0
+static int penctrl_regs_read(struct penctrl_device *penctrl, u32 reg, u32 *val)
+{
+       struct spi_device *spi = penctrl->spi;
+       struct spi_transfer t[2] = {};
+       struct spi_message m;
 
+       u8 txbuf[3];
+       u8 rxbuf[1];

Not DMA-safe. Is it a problem?

drivers/soc/amd/pensando-ctrl.c line 147

Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +4 -0
+       int ret;
 
+       txbuf[0] = PENCTRL_SPI_CMD_REGRD;
+       txbuf[1] = reg;
+       txbuf[2] = 0;

Can be assigned in the definition block

       u8 txbuf[] = { ... };

drivers/soc/amd/pensando-ctrl.c line 151

Quoted 4 lines
drivers/soc/amd/pensando-ctrl.c new file +3 -0
+       t[0].tx_buf = txbuf;
+       t[0].len = sizeof(txbuf);
 
+       rxbuf[0] = 0;

Ditto.

    u8 rxbuf[] = { 0 };
Quoted 11 lines
drivers/soc/amd/pensando-ctrl.c new file +11 -0
+       t[1].rx_buf = rxbuf;
+       t[1].len = sizeof(rxbuf);
+
+       spi_message_init_with_transfers(&m, t, ARRAY_SIZE(t));
+       ret = spi_sync(spi, &m);
+       if (ret)
+               return ret;
+
+       *val = rxbuf[0];
+       return 0;
+}

...

drivers/soc/amd/pensando-ctrl.c line 174

Quoted 11 lines
drivers/soc/amd/pensando-ctrl.c new file +10 -0
+static int penctrl_regs_write(struct penctrl_device *penctrl, u32 reg, u32 val)
+{
+       struct spi_device *spi = penctrl->spi;
+       struct spi_transfer t = {};
+       struct spi_message m;
+       u8 txbuf[4];
 
+       txbuf[0] = PENCTRL_SPI_CMD_REGWR;
+       txbuf[1] = reg;
+       txbuf[2] = val;
+       txbuf[3] = 0;

Can be assigned in the definition block.

Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +5 -0
+       t.tx_buf = txbuf;
+       t.len = sizeof(txbuf);
+       spi_message_init_with_transfers(&m, &t, 1);
+       return spi_sync(spi, &m);
+}

...

Review

Quoted 2 lines
(quoted diff) +2 -0
+       struct penctrl_device *penctrl =
+               container_of(rcdev, struct penctrl_device, rcdev);

One line?

...

Quoted 1 line

+ spi->chip_select = 0;

spi_set_chipselect()

...

Review

Quoted 2 lines
(quoted diff) +2 -0
+       struct penctrl_device *penctrl =
+               container_of(rcdev, struct penctrl_device, rcdev);

One line?

...

Quoted 1 line

+ spi->chip_select = 0;

spi_set_chipselect()

...

drivers/soc/amd/pensando-ctrl.c line 257

Quoted 6 lines
drivers/soc/amd/pensando-ctrl.c new file +6 -0
+static int penctrl_spi_probe(struct spi_device *spi)
+{
+       int i, ret;
+
+       /* Allocate driver data */
+       penctrl = kzalloc(sizeof(*penctrl), GFP_KERNEL);

devm_kzalloc() ?

Quoted 20 lines
drivers/soc/amd/pensando-ctrl.c new file +20 -0
+       if (!penctrl)
+               return -ENOMEM;
+
+       penctrl->spi = spi;
+       mutex_init(&spi_lock);
+
+       for (i = 0; i < ARRAY_SIZE(penctrl_devices); i++) {
+               ret = misc_register(&penctrl_devices[i]);
+               if (ret) {
+                       dev_err(&spi->dev, "Failed to register device %s\n",
+                               penctrl_devices[i].name);
+                       goto cleanup;
+               }
+       }
+
+       /* Register reset controller */
+       penctrl->rcdev.dev = &spi->dev;
+       penctrl->rcdev.ops = &penctrl_reset_ops;
+       penctrl->rcdev.owner = THIS_MODULE;
+       penctrl->rcdev.of_node = spi->dev.of_node;

drivers/soc/amd/pensando-ctrl.c line 287

Quoted 10 lines
drivers/soc/amd/pensando-ctrl.c new file +9 -0
+       penctrl->rcdev.nr_resets = 1;
+       device_set_node(penctrl->rcdev.dev, dev_fwnode(&spi->dev));
+
+       ret = reset_controller_register(&penctrl->rcdev);
+       if (ret)
+               return dev_err_probe(&spi->dev, ret,
+                                    "failed to register reset controller\n");
+       return 0;
 
+cleanup:

err_cleanup: ?

Quoted 1 line

+ for (i = 0; i < ARRAY_SIZE(penctrl_devices); i++) {

  while (i--) {
Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +5 -0
+               if (penctrl_devices[i].this_device)
+                       misc_deregister(&penctrl_devices[i]);
+       }
+       return ret;
+}
Signature · 7 lines
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#11 lore raw

Re: [PATCH v16 6/6] soc: amd: Add support for AMD Pensando SoC Controller

In reply to Brad Larson
Quoted 5 lines · Brad Larson

The Pensando SoC controller is a SPI connected companion device that is present in all Pensando SoC board designs. The essential board management registers are accessed on chip select 0 with board mgmt IO support accessed using additional chip selects.

Quoted 7 lines

---

v15 changes:
- Drop custom ioctl and use existing miscdevice interface.
- Delete unused definitions in amd-pensando-ctrl.h
- Makefile change to compile for ARCH_PENSANDO

Hi Brad,

I'm sorry I've been out of the loop for so long, and I hope we can find a way to manage your SoC support soon. My impression is that the normal support patches (1, 3, 4, and 5) are largely uncontroversial, while the SoC controller support seems like we are still not converging onto something that is ready to merge, so I would suggest you split the two parts and send the basic support for inclusion in linux-6.7 while we continue to discuss the soc controller driver.

Please remove any references to the soc controller from the dts files and send that first series to:[email protected] cc:linux-arm-kernel (and the other interested parties) so I can pick those up.

Regarding the soc controller driver, let me try to give you my impression of where we are:

- you have gone through 16 revisions already, which is way too much for a public review, we should have been able to find a solution earlier than that, and this is partly our fault on the reviewer side, and I'm sorry about that.

- Andy's latest comments and a lot of the earlier reviews were focused on implementation details. While those comments are helpful suggestions for improving the code, they miss the larger point about the system design that I'm worried about and probably don't help you actually get it merged.

- The main problem I still see is that this driver completely bypasses our normal kernel abstractions and instead creates a low-level passthrough interface for handling kernel functionality in userspace. This creates a liability both for the user ABI and the kernel implementation and prevents any

- There is a chance that your design is in fact the best way to handle this particular hardware, but it is your job to write a convincing explanation of why this platform is different from all the others in the patch description. Your current one-paragraph text does not explain this at all.

I would suggest you prioritize getting the other patches included for the moment, but we can keep discussion the API design for this driver either in this thread or on the #armlinux IRC channel (irc.libera.chat) in parallel if you like. In order to help you here, I would need either the documentation of the SPI software interface, or the source code for the userspace tool.

Arnd

#12 lore raw

Re: [PATCH v16 6/6] soc: amd: Add support for AMD Pensando SoC Controller

Quoted 1 line · Arnd Bergmann

On Wed, Sep 13, 2023, at 17:49, Brad Larson wrote:

...

Quoted 29 lines
Quoted 4 lines

v15 changes:
- Drop custom ioctl and use existing miscdevice interface.
- Delete unused definitions in amd-pensando-ctrl.h
- Makefile change to compile for ARCH_PENSANDO

Hi Brad,

I'm sorry I've been out of the loop for so long, and I hope we can find a way to manage your SoC support soon. My impression is that the normal support patches (1, 3, 4, and 5) are largely uncontroversial, while the SoC controller support seems like we are still not converging onto something that is ready to merge, so I would suggest you split the two parts and send the basic support for inclusion in linux-6.7 while we continue to discuss the soc controller driver.

Please remove any references to the soc controller from the dts files and send that first series to:[email protected] cc:linux-arm-kernel (and the other interested parties) so I can pick those up.

Regarding the soc controller driver, let me try to give you my impression of where we are:

- you have gone through 16 revisions already, which is way too much for a public review, we should have been able to find a solution earlier than that, and this is partly our fault on the reviewer side, and I'm sorry about that.

Quoted 5 lines

- Andy's latest comments and a lot of the earlier reviews were focused on implementation details. While those comments are helpful suggestions for improving the code, they miss the larger point about the system design that I'm worried about and probably don't help you actually get it merged.

True. The fact that the new versions left the design remaining make me think that the ABI was settled down.

Quoted 21 lines

- The main problem I still see is that this driver completely bypasses our normal kernel abstractions and instead creates a low-level passthrough interface for handling kernel functionality in userspace. This creates a liability both for the user ABI and the kernel implementation and prevents any

- There is a chance that your design is in fact the best way to handle this particular hardware, but it is your job to write a convincing explanation of why this platform is different from all the others in the patch description. Your current one-paragraph text does not explain this at all.

I would suggest you prioritize getting the other patches included for the moment, but we can keep discussion the API design for this driver either in this thread or on the #armlinux IRC channel (irc.libera.chat) in parallel if you like. In order to help you here, I would need either the documentation of the SPI software interface, or the source code for the userspace tool.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
author maintainer
#13 lore raw

Re: [PATCH v16 6/6] soc: amd: Add support for AMD Pensando SoC Controller

In reply to Arnd Bergmann

Hi Arnd,

Thanks for the reply and guidance!

Quoted 16 lines · Arnd Bergmann
Quoted 5 lines · Brad Larson

The Pensando SoC controller is a SPI connected companion device that is present in all Pensando SoC board designs. The essential board management registers are accessed on chip select 0 with board mgmt IO support accessed using additional chip selects.

Quoted 7 lines

---

v15 changes:
- Drop custom ioctl and use existing miscdevice interface.
- Delete unused definitions in amd-pensando-ctrl.h
- Makefile change to compile for ARCH_PENSANDO

Hi Brad,

Quoted 8 lines

I'm sorry I've been out of the loop for so long, and I hope we can find a way to manage your SoC support soon. My impression is that the normal support patches (1, 3, 4, and 5) are largely uncontroversial, while the SoC controller support seems like we are still not converging onto something that is ready to merge, so I would suggest you split the two parts and send the basic support for inclusion in linux-6.7 while we continue to discuss the soc controller driver.

I've sent a patchset with only patches 1, 3, 4, and 5. Correctness is the priority for upstream inclusion.

Quoted 4 lines

Please remove any references to the soc controller from the dts files and send that first series to:[email protected] cc:linux-arm-kernel (and the other interested parties) so I can pick those up.

Yes, I've removed the node for which the compatible driver is the problem.

Quoted 37 lines

Regarding the soc controller driver, let me try to give you my impression of where we are:

- you have gone through 16 revisions already, which is way too much for a public review, we should have been able to find a solution earlier than that, and this is partly our fault on the reviewer side, and I'm sorry about that.

- Andy's latest comments and a lot of the earlier reviews were focused on implementation details. While those comments are helpful suggestions for improving the code, they miss the larger point about the system design that I'm worried about and probably don't help you actually get it merged.

- The main problem I still see is that this driver completely bypasses our normal kernel abstractions and instead creates a low-level passthrough interface for handling kernel functionality in userspace. This creates a liability both for the user ABI and the kernel implementation and prevents any

- There is a chance that your design is in fact the best way to handle this particular hardware, but it is your job to write a convincing explanation of why this platform is different from all the others in the patch description. Your current one-paragraph text does not explain this at all.

I would suggest you prioritize getting the other patches included for the moment, but we can keep discussion the API design for this driver either in this thread or on the #armlinux IRC channel (irc.libera.chat) in parallel if you like. In order to help you here, I would need either the documentation of the SPI software interface, or the source code for the userspace tool.

Quoted 1 line

Arnd

I'll redirect and reframe what the SoC driver is doing to #armlinux IRC to find an appropriate solution.

Regards,
Brad

#14 lore raw

Re: [PATCH v16 6/6] soc: amd: Add support for AMD Pensando SoC Controller

Quoted 11 lines · Brad Larson
Quoted 9 lines · Arnd Bergmann

On Wed, Sep 13, 2023, at 17:49, Brad Larson wrote:
I'm sorry I've been out of the loop for so long, and I hope we can find a way to manage your SoC support soon. My impression is that the normal support patches (1, 3, 4, and 5) are largely uncontroversial, while the SoC controller support seems like we are still not converging onto something that is ready to merge, so I would suggest you split the two parts and send the basic support for inclusion in linux-6.7 while we continue to discuss the soc controller driver.

Quoted 2 lines

I've sent a patchset with only patches 1, 3, 4, and 5. Correctness is the priority for upstream inclusion.

Ok, I took a look already and it all looks good. I should be able to pick it up into linux-next in the next few days when I open my branches for 6.7.

Quoted 2 lines

I'll redirect and reframe what the SoC driver is doing to #armlinux IRC to find an appropriate solution.

Ok.

Arnd

author maintainer
#9 lore raw

Re: [PATCH v16 6/6] soc: amd: Add support for AMD Pensando SoC Controller

In reply to Andy Shevchenko

Hi Andy,

Quoted 6 lines · On Thu, Sep 21, 2023 at 18:19:57 +0300 Andy Shevchenko…
Quoted 5 lines · Brad Larson

The Pensando SoC controller is a SPI connected companion device that is present in all Pensando SoC board designs. The essential board management registers are accessed on chip select 0 with board mgmt IO support accessed using additional chip selects.

...

Quoted 5 lines
Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +5 -0
+#include <linux/cdev.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/fs.h>
+#include <linux/init.h>
Quoted 8 lines

drivers/soc/amd/pensando-ctrl.c line 22

Quoted 6 lines
drivers/soc/amd/pensando-ctrl.c new file +6 -0
+#include <linux/miscdevice.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/mutex.h>
+#include <linux/reset-controller.h>
+#include <linux/spi/spi.h>

types.h ?

I'll add types.h

Quoted 1 line
Quoted 1 line

+#include <linux/uaccess.h>

...

Quoted 6 lines

drivers/soc/amd/pensando-ctrl.c line 40

Quoted 4 lines
drivers/soc/amd/pensando-ctrl.c new file +3 -0
+       struct penctrl_device *penctrl;
 
+       u8 tx_buf[PENCTRL_MAX_MSG_LEN];
+       u8 rx_buf[PENCTRL_MAX_MSG_LEN];

These are not DMA-safe, is this a problem?

It's not a problem, the peripheral is PIO FIFO driven only.

Quoted 7 lines
Quoted 7 lines
drivers/soc/amd/pensando-ctrl.c new file +7 -0
+       struct spi_transfer t[2] = {};
+       struct penctrl_spi_xfer *msg;
+       struct spi_device *spi;
+       unsigned int num_msgs;
+       struct spi_message m;
+       u32 size;
+       int ret;

...

Quoted 5 lines

drivers/soc/amd/pensando-ctrl.c line 60

Quoted 3 lines
drivers/soc/amd/pensando-ctrl.c new file +3 -0
+       /* Verify and prepare SPI message */
+       size = _IOC_SIZE(cmd);
+       num_msgs = size / sizeof(struct penctrl_spi_xfer);

sizeof (*msg) ?

Yes, more compact for here and below.

Quoted 8 lines
Quoted 2 lines

+ if (num_msgs > 2 || size == 0 || size % sizeof(struct penctrl_spi_xfer)) {

Dito.

Quoted 3 lines
drivers/soc/amd/pensando-ctrl.c new file +3 -0
+               ret = -EINVAL;
+               goto out_unlock;
+       }

...

Quoted 7 lines

drivers/soc/amd/pensando-ctrl.c line 69

Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +5 -0
+       msg = memdup_user((struct penctrl_spi_xfer *)arg, size);
+       if (IS_ERR(msg)) {
+               ret = PTR_ERR(msg);
+               goto out_unlock;
+       }

Wondering if you can start using cleanup.h.

Perhaps if recommended, I don't see DEFINE_(FREE,UNLOCK,...) being used.

...

Quoted 10 lines

drivers/soc/amd/pensando-ctrl.c line 98

Quoted 7 lines
drivers/soc/amd/pensando-ctrl.c new file +6 -0
+       /* Perform the transfer */
+       mutex_lock(&spi_lock);
+       ret = spi_sync(spi, &m);
+       mutex_unlock(&spi_lock);
 
+       if (ret || (num_msgs == 1))
+               goto out_unlock;

Second conditional will return 0. Is it by design? Since it's not so obvious I would split these conditionals.

I'll split this to be clear, yes return 0 for success.

...

Quoted 3 lines
Quoted 1 line

+ spi->chip_select = current_cs;

spi_set_chipselect()

Yes, I'll change to inline function spi_set_chipselect(spi, 0, current_cs). The second arg must be legacy as its unused.

...

Quoted 11 lines

drivers/soc/amd/pensando-ctrl.c line 142

Quoted 8 lines
drivers/soc/amd/pensando-ctrl.c new file +7 -0
+static int penctrl_regs_read(struct penctrl_device *penctrl, u32 reg, u32 *val)
+{
+       struct spi_device *spi = penctrl->spi;
+       struct spi_transfer t[2] = {};
+       struct spi_message m;
 
+       u8 txbuf[3];
+       u8 rxbuf[1];

Not DMA-safe. Is it a problem?

Not a problem, the peripheral is PIO only using FIFOs.

Quoted 10 lines

drivers/soc/amd/pensando-ctrl.c line 147

Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +4 -0
+       int ret;
 
+       txbuf[0] = PENCTRL_SPI_CMD_REGRD;
+       txbuf[1] = reg;
+       txbuf[2] = 0;

Can be assigned in the definition block

      u8 txbuf[] = { ... };

I'll change that here and below.

Quoted 20 lines

drivers/soc/amd/pensando-ctrl.c line 151

Quoted 4 lines
drivers/soc/amd/pensando-ctrl.c new file +3 -0
+       t[0].tx_buf = txbuf;
+       t[0].len = sizeof(txbuf);
 
+       rxbuf[0] = 0;

Ditto.

   u8 rxbuf[] = { 0 };
Quoted 11 lines
drivers/soc/amd/pensando-ctrl.c new file +11 -0
+       t[1].rx_buf = rxbuf;
+       t[1].len = sizeof(rxbuf);
+
+       spi_message_init_with_transfers(&m, t, ARRAY_SIZE(t));
+       ret = spi_sync(spi, &m);
+       if (ret)
+               return ret;
+
+       *val = rxbuf[0];
+       return 0;
+}

...

Quoted 19 lines

drivers/soc/amd/pensando-ctrl.c line 174

Quoted 11 lines
drivers/soc/amd/pensando-ctrl.c new file +10 -0
+static int penctrl_regs_write(struct penctrl_device *penctrl, u32 reg, u32 val)
+{
+       struct spi_device *spi = penctrl->spi;
+       struct spi_transfer t = {};
+       struct spi_message m;
+       u8 txbuf[4];
 
+       txbuf[0] = PENCTRL_SPI_CMD_REGWR;
+       txbuf[1] = reg;
+       txbuf[2] = val;
+       txbuf[3] = 0;

Can be assigned in the definition block.

Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +5 -0
+       t.tx_buf = txbuf;
+       t.len = sizeof(txbuf);
+       spi_message_init_with_transfers(&m, &t, 1);
+       return spi_sync(spi, &m);
+}

...

Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+       struct penctrl_device *penctrl =
+               container_of(rcdev, struct penctrl_device, rcdev);

One line?

I'll check/change.

Quoted 6 lines

...

Quoted 1 line

+ spi->chip_select = 0;

spi_set_chipselect()

Yes, spi_set_chipselect(spi, 0, 0);

...

Quoted 4 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+       struct penctrl_device *penctrl =
+               container_of(rcdev, struct penctrl_device, rcdev);

One line?

I'll check/change.

...

Quoted 3 lines
Quoted 1 line

+ spi->chip_select = 0;

spi_set_chipselect()

Yes, spi_set_chipselect(spi, 0, 0);

...

Quoted 8 lines

drivers/soc/amd/pensando-ctrl.c line 257

Quoted 6 lines
drivers/soc/amd/pensando-ctrl.c new file +6 -0
+static int penctrl_spi_probe(struct spi_device *spi)
+{
+       int i, ret;
+
+       /* Allocate driver data */
+       penctrl = kzalloc(sizeof(*penctrl), GFP_KERNEL);

devm_kzalloc() ?

Yes will change to devm_kzalloc().

Quoted 29 lines
Quoted 28 lines
drivers/soc/amd/pensando-ctrl.c new file +28 -0
+       if (!penctrl)
+               return -ENOMEM;
+
+       penctrl->spi = spi;
+       mutex_init(&spi_lock);
+
+       for (i = 0; i < ARRAY_SIZE(penctrl_devices); i++) {
+               ret = misc_register(&penctrl_devices[i]);
+               if (ret) {
+                       dev_err(&spi->dev, "Failed to register device %s\n",
+                               penctrl_devices[i].name);
+                       goto cleanup;
+               }
+       }
+
+       /* Register reset controller */
+       penctrl->rcdev.dev = &spi->dev;
+       penctrl->rcdev.ops = &penctrl_reset_ops;
+       penctrl->rcdev.owner = THIS_MODULE;
+       penctrl->rcdev.of_node = spi->dev.of_node;
+       penctrl->rcdev.nr_resets = 1;
+       device_set_node(penctrl->rcdev.dev, dev_fwnode(&spi->dev));
+
+       ret = reset_controller_register(&penctrl->rcdev);
+       if (ret)
+               return dev_err_probe(&spi->dev, ret,
+                                    "failed to register reset controller\n");
+       return 0;
Quoted 3 lines
Quoted 1 line

+cleanup:

err_cleanup: ?

Will use err_cleanup:

Quoted 4 lines
Quoted 1 line

+ for (i = 0; i < ARRAY_SIZE(penctrl_devices); i++) {

while (i--) {

Yes, can change to while(), order doesn't matter.

Quoted 5 lines

drivers/soc/amd/pensando-ctrl.c line 293

Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +5 -0
+               if (penctrl_devices[i].this_device)
+                       misc_deregister(&penctrl_devices[i]);
+       }
+       return ret;
+}

Regards,
Brad

#10 lore raw

Re: [PATCH v16 6/6] soc: amd: Add support for AMD Pensando SoC Controller

Quoted 2 lines · Brad Larson
Quoted 1 line · On Thu, Sep 21, 2023 at 18:19:57 +0300 Andy Shevchenko…

On Thu, Sep 14, 2023 at 12:52 AM Brad Larson <[email protected]> wrote:

...

Quoted 6 lines
Quoted 4 lines

drivers/soc/amd/pensando-ctrl.c line 40

Quoted 2 lines
drivers/soc/amd/pensando-ctrl.c new file +2 -0
+       u8 tx_buf[PENCTRL_MAX_MSG_LEN];
+       u8 rx_buf[PENCTRL_MAX_MSG_LEN];

These are not DMA-safe, is this a problem?

It's not a problem, the peripheral is PIO FIFO driven only.

The question was about the SPI controller itself.
Also, depending on the driver it may or may not require DMA-safe pointers. I believe with the new pump queue used in the SPI core all drivers that are using it are DMA-safe and the caller needs no additional care.

...

Quoted 9 lines
Quoted 7 lines

drivers/soc/amd/pensando-ctrl.c line 69

Quoted 5 lines
drivers/soc/amd/pensando-ctrl.c new file +5 -0
+       msg = memdup_user((struct penctrl_spi_xfer *)arg, size);
+       if (IS_ERR(msg)) {
+               ret = PTR_ERR(msg);
+               goto out_unlock;
+       }

Wondering if you can start using cleanup.h.

Perhaps if recommended, I don't see DEFINE_(FREE,UNLOCK,...) being used.

It's guard()() and scoped_guard() for locks and __free() for the allocations.

Plenty of uses in a few modules already (talking about Linux Next snapshot).

...

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

+ spi->chip_select = current_cs;

spi_set_chipselect()

Yes, I'll change to inline function spi_set_chipselect(spi, 0, current_cs). The second arg must be legacy as its unused.

Actually, it's a placeholder for the future support of indexed CS'.

...

Quoted 6 lines
Quoted 4 lines

drivers/soc/amd/pensando-ctrl.c line 142

Quoted 2 lines
drivers/soc/amd/pensando-ctrl.c new file +2 -0
+       u8 txbuf[3];
+       u8 rxbuf[1];

Not DMA-safe. Is it a problem?

Not a problem, the peripheral is PIO only using FIFOs.

Same as somewhere above.

Signature · 2 lines
With Best Regards,
Andy Shevchenko