Skip to contentSkip to conversation

Remove libclone library from containers suite

PATCH Superseded Andrea Cervesato 2 participants 2 messages Sep 14, 2023

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove libclone library from containers suite

From: Andrea Cervesato <[email protected]>

---
 testcases/kernel/containers/Makefile          |   4 -
 testcases/kernel/containers/Makefile.inc      |   6 -
 testcases/kernel/containers/README            |   2 -
 testcases/kernel/containers/libclone/Makefile |  27 ----
 .../kernel/containers/libclone/libclone.c     | 142 ------------------
 .../kernel/containers/libclone/libclone.h     |  81 ----------
 .../kernel/containers/pidns/pidns_helper.h    |  34 -----
 7 files changed, 296 deletions(-)
 delete mode 100644 testcases/kernel/containers/libclone/Makefile
 delete mode 100644 testcases/kernel/containers/libclone/libclone.c
 delete mode 100644 testcases/kernel/containers/libclone/libclone.h
 delete mode 100644 testcases/kernel/containers/pidns/pidns_helper.h
testcases/kernel/containers/Makefile +0 -4
index 4285546e7..c645d8a51 100644
@@ -5,12 +5,8 @@ top_srcdir		?= ../../..
 
 include $(top_srcdir)/include/mk/env_pre.mk
 
-LIBDIR			:= libclone
-
 FILTER_OUT_DIRS		:= $(LIBDIR)
 
-LIB			:= $(LIBDIR)/libclone.a
-
 LDLIBS			:= -ldl -lltp
 
 INSTALL_TARGETS		:= *.sh
testcases/kernel/containers/Makefile.inc +0 -6
index 179809bc1..f8a5e1774 100644
@@ -20,12 +20,6 @@
 # Ngie Cooper, July 2009
 #
 
-# DO NOT USE THIS FILE FOR containers / libclone!!!
-
-LIBDIR			:= ../libclone
-
-LIBS			:= $(LIBDIR)/libclone.a
-
 CPPFLAGS		+= -I$(abs_srcdir)/$(LIBDIR)
 
 LDFLAGS			+= -L$(abs_builddir)/$(LIBDIR)
testcases/kernel/containers/README +0 -2
index c99cacd98..df909e526 100644
@@ -44,7 +44,5 @@ posixmq/*
 	enabled in the kernel without SYSV IPC support.
 utsname/*
 	Contains all the testcases related to utsname tests.
-libclone/*
-	Contains the library API for clone() .
 netns/*
         Contains the testcases related to the network NS tests.
testcases/kernel/containers/libclone/Makefile deleted +0 -27
deleted file mode 100644
index 13af52b67..000000000
@@ -1,27 +0,0 @@
-################################################################################
-##                                                                            ##
-## Copyright (c) International Business Machines  Corp., 2007                 ##
-##                                                                            ##
-## This program is free software;  you can redistribute it and#or modify      ##
-## it under the terms of the GNU General Public License as published by       ##
-## the Free Software Foundation; either version 2 of the License, or          ##
-## (at your option) any later version.                                        ##
-##                                                                            ##
-## This program is distributed in the hope that it will be useful, but        ##
-## WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY ##
-## or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License   ##
-## for more details.                                                          ##
-##                                                                            ##
-## You should have received a copy of the GNU General Public License          ##
-## along with this program;  if not, write to the Free Software               ##
-## Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA    ##
-##                                                                            ##
-################################################################################
-
-top_srcdir		?= ../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-INTERNAL_LIB		:= libclone.a
-
-include $(top_srcdir)/include/mk/lib.mk
testcases/kernel/containers/libclone/libclone.c deleted +0 -142

142 lines not on this page · raw message

testcases/kernel/containers/libclone/libclone.h deleted +0 -81

81 lines not on this page · raw message

testcases/kernel/containers/pidns/pidns_helper.h deleted +0 -34
deleted file mode 100644
index 3b356768f..000000000
@@ -1,34 +0,0 @@
-/*
-* Copyright (c) International Business Machines Corp., 2007
-* This program is free software; you can redistribute it and/or modify
-* it under the terms of the GNU General Public License as published by
-* the Free Software Foundation; either version 2 of the License, or
-* (at your option) any later version.
-*
-* This program is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See
-* the GNU General Public License for more details.
-*/
-
-#include "../libclone/libclone.h"
-#include "test.h"
-#include "safe_macros.h"
-
-static int dummy_child(void *v)
-{
-	(void) v;
-	return 0;
-}
-
-static int check_newpid(void)
-{
-	int pid, status;
-
-	pid = do_clone_unshare_test(T_CLONE, CLONE_NEWPID, dummy_child, NULL);
-	if (pid == -1)
-		tst_brkm(TCONF | TERRNO, NULL, "CLONE_NEWPID not supported");
-	SAFE_WAIT(NULL, &status);
-
-	return 0;
-}
Signature · 5 lines
2.35.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#1 lore raw

Hi!

Quoted 4 lines
---
 testcases/kernel/containers/Makefile          |   4 -
 testcases/kernel/containers/Makefile.inc      |   6 -

This is not actually complete, you need to remove the Makefile.inc completely and all traces of it and of -lclone.

And also all the library stuff in containers/Makefile, in fact the containers/Makefile should contain only the top_srcdir definitions and the single include.

Signature · 5 lines
Cyril Hrubis
[email protected]

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp