leds: cr0014114: Annotate struct cr0014114 with __counted_by
PATCH 1/1 leds: cr0014114: Annotate struct cr0014114 with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct cr0014114.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
--- drivers/leds/leds-cr0014114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-cr0014114.c +1 -1
@@ -56,7 +56,7 @@ struct cr0014114 {struct spi_device *spi;u8 *buf;unsigned long delay; -struct cr0014114_led leds[]; + struct cr0014114_led leds[] __counted_by(count); };static void cr0014114_calc_crc (u8 *buf,const size_t len)
Signature · 1 line
2.34.1
Quoted 6 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).
Quoted 8 lines
As found with Coccinelle[1], add
__counted_byfor struct cr0014114.[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Pavel Machek <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks
Signature · 1 line
Gustavo
Quoted 17 lines
--- drivers/leds/leds-cr0014114.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/leds/leds-cr0014114.c +1
-1@@ -56,7 +56,7 @@ struct cr0014114 {struct spi_device *spi;u8 *buf;unsigned long delay; -struct cr0014114_led leds[]; + struct cr0014114_led leds[] __counted_by(count); };static void cr0014114_calc_crc (u8 *buf,const size_t len)
Re: (subset) [PATCH] leds: cr0014114: Annotate struct cr0014114 with __counted_by
In reply to Kees CookQuoted 9 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor struct cr0014114.[...]
Applied, thanks!
[1/1] leds: cr0014114: Annotate struct cr0014114 with __counted_by
commit: dfd75548c30c4a27bcc4c81aed0287d2e8b62add
--
Lee Jones [李琼斯]