leds: el15203000: Annotate struct el15203000 with __counted_by
PATCH 1/1 leds: el15203000: Annotate struct el15203000 with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct el15203000.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
--- drivers/leds/leds-el15203000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-el15203000.c +1 -1
@@ -80,7 +80,7 @@ struct el15203000 {struct spi_device *spi;unsigned long delay;size_t count; -struct el15203000_led leds[]; + struct el15203000_led leds[] __counted_by(count); };#define to_el15203000_led (d) container_of(d, struct el15203000_led, ldev)
Signature · 1 line
2.34.1
Quoted 6 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).
Quoted 8 lines
As found with Coccinelle[1], add
__counted_byfor struct el15203000.[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc Pavel Machek <[email protected]>Cc Lee Jones <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks
Signature · 1 line
Gustavo
Quoted 17 lines
--- drivers/leds/leds-el15203000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/leds/leds-el15203000.c +1
-1@@ -80,7 +80,7 @@ struct el15203000 {struct spi_device *spi;unsigned long delay;size_t count; -struct el15203000_led leds[]; + struct el15203000_led leds[] __counted_by(count); };#define to_el15203000_led (d) container_of(d, struct el15203000_led, ldev)
Re: (subset) [PATCH] leds: el15203000: Annotate struct el15203000 with __counted_by
In reply to Kees CookQuoted 9 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time checking viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor struct el15203000.[...]
Applied, thanks!
[1/1] leds: el15203000: Annotate struct el15203000 with __counted_by
commit: 1d6d5c03fabeb5e5bb7fd7ac3319a8c5471be9e8
--
Lee Jones [李琼斯]